From: David Wei <dw@davidwei.uk>
To: Mina Almasry <almasrymina@google.com>
Cc: Shailend Chand <shailend@google.com>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
hramamurthy@google.com, jeroendb@google.com, kuba@kernel.org,
pabeni@redhat.com, pkaligineedi@google.com, rushilg@google.com,
willemb@google.com, ziweixiao@google.com
Subject: Re: [PATCH net-next v2 10/10] gve: Implement queue api
Date: Thu, 9 May 2024 10:46:54 -0700 [thread overview]
Message-ID: <246d09a5-e3f2-425a-be68-8abbe3c98eb3@davidwei.uk> (raw)
In-Reply-To: <CAHS8izO4EjXB4U=oq0zFTdJRnqXPzRJLo9fVqtSHPAFnKoU9aQ@mail.gmail.com>
On 2024-05-08 10:09, Mina Almasry wrote:
> On Tue, May 7, 2024 at 2:06 PM David Wei <dw@davidwei.uk> wrote:
>>
>> On 2024-05-06 11:47, Mina Almasry wrote:
>>> On Mon, May 6, 2024 at 11:09 AM David Wei <dw@davidwei.uk> wrote:
>>>>
>>>> On 2024-05-01 16:25, Shailend Chand wrote:
>>>>> The new netdev queue api is implemented for gve.
>>>>>
>>>>> Tested-by: Mina Almasry <almasrymina@google.com>
>>>>> Reviewed-by: Mina Almasry <almasrymina@google.com>
>>>>> Reviewed-by: Praveen Kaligineedi <pkaligineedi@google.com>
>>>>> Reviewed-by: Harshitha Ramamurthy <hramamurthy@google.com>
>>>>> Signed-off-by: Shailend Chand <shailend@google.com>
>>>>> ---
>>>>> drivers/net/ethernet/google/gve/gve.h | 6 +
>>>>> drivers/net/ethernet/google/gve/gve_dqo.h | 6 +
>>>>> drivers/net/ethernet/google/gve/gve_main.c | 177 +++++++++++++++++--
>>>>> drivers/net/ethernet/google/gve/gve_rx.c | 12 +-
>>>>> drivers/net/ethernet/google/gve/gve_rx_dqo.c | 12 +-
>>>>> 5 files changed, 189 insertions(+), 24 deletions(-)
>>>>>
>>>>
>>>> [...]
>>>>
>>>>> +static const struct netdev_queue_mgmt_ops gve_queue_mgmt_ops = {
>>>>> + .ndo_queue_mem_size = sizeof(struct gve_rx_ring),
>>>>> + .ndo_queue_mem_alloc = gve_rx_queue_mem_alloc,
>>>>> + .ndo_queue_mem_free = gve_rx_queue_mem_free,
>>>>> + .ndo_queue_start = gve_rx_queue_start,
>>>>> + .ndo_queue_stop = gve_rx_queue_stop,
>>>>> +};
>>>>
>>>> Shailend, Mina, do you have code that calls the ndos somewhere?
>>>
>>> I plan to rebase the devmem TCP series on top of these ndos and submit
>>> that, likely sometime this week. The ndos should be used from an
>>> updated version of [RFC,net-next,v8,04/14] netdev: support binding
>>> dma-buf to netdevice
>>
>> Now that queue API ndos have merged, could you please send this as a
>> separate series and put it somewhere where it can be re-used e.g.
>> netdev_rx_queue.c?
>>
>
> Definitely happy to put it in a generic place like netdev_rx_queue.c
> like you did, but slight pushback to putting it into its own series.
> With the ndos merged finally, I can take our devmem TCP series out of
> RFC and I am eager to do so. Making it dependent on a change that is
> in another series means it must remain RFC.
>
> What I can do here is put this change into its own patch in the devmem
> TCP series. Once that is reviewed the maintainers may apply that patch
> out of the series. I can also put it in its own series and keep devmem
> TCP in RFC for now if you insist :D
No, that's fine. Please put it at the front of the series once you're
ready. I'll cherrypick it into our series.
>
>
next prev parent reply other threads:[~2024-05-09 17:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 23:25 [PATCH net-next v2 00/10] gve: Implement queue api Shailend Chand
2024-05-01 23:25 ` [PATCH net-next v2 01/10] queue_api: define " Shailend Chand
2024-05-01 23:25 ` [PATCH net-next v2 02/10] gve: Make the GQ RX free queue funcs idempotent Shailend Chand
2024-05-01 23:25 ` [PATCH net-next v2 03/10] gve: Add adminq funcs to add/remove a single Rx queue Shailend Chand
2024-05-01 23:25 ` [PATCH net-next v2 04/10] gve: Make gve_turn(up|down) ignore stopped queues Shailend Chand
2024-05-01 23:25 ` [PATCH net-next v2 05/10] gve: Make gve_turnup work for nonempty queues Shailend Chand
2024-05-01 23:25 ` [PATCH net-next v2 06/10] gve: Avoid rescheduling napi if on wrong cpu Shailend Chand
2024-05-01 23:25 ` [PATCH net-next v2 07/10] gve: Reset Rx ring state in the ring-stop funcs Shailend Chand
2024-05-01 23:25 ` [PATCH net-next v2 08/10] gve: Account for stopped queues when reading NIC stats Shailend Chand
2024-05-01 23:25 ` [PATCH net-next v2 09/10] gve: Alloc and free QPLs with the rings Shailend Chand
2024-05-01 23:25 ` [PATCH net-next v2 10/10] gve: Implement queue api Shailend Chand
2024-05-06 18:09 ` David Wei
2024-05-06 18:47 ` Mina Almasry
2024-05-07 21:06 ` David Wei
2024-05-08 17:09 ` Mina Almasry
2024-05-09 17:46 ` David Wei [this message]
2024-05-02 15:15 ` [PATCH net-next v2 00/10] " Willem de Bruijn
2024-05-05 13:40 ` patchwork-bot+netdevbpf
2024-05-06 17:41 ` Shailend Chand
2024-05-06 18:07 ` Shailend Chand
2024-05-07 1:25 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=246d09a5-e3f2-425a-be68-8abbe3c98eb3@davidwei.uk \
--to=dw@davidwei.uk \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hramamurthy@google.com \
--cc=jeroendb@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=rushilg@google.com \
--cc=shailend@google.com \
--cc=willemb@google.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).