Netdev Archive mirror
 help / color / mirror / Atom feed
From: Serge Semin <fancer.lancer@gmail.com>
To: Yanteng Si <siyanteng@loongson.cn>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, peppe.cavallaro@st.com,
	 alexandre.torgue@foss.st.com, joabreu@synopsys.com,
	Jose.Abreu@synopsys.com,  chenhuacai@kernel.org,
	linux@armlinux.org.uk, guyinggang@loongson.cn,
	 netdev@vger.kernel.org, chris.chenfeiyang@gmail.com,
	siyanteng01@gmail.com
Subject: Re: [PATCH net-next v12 07/15] net: stmmac: dwmac-loongson: Add ref and ptp clocks for Loongson
Date: Fri, 3 May 2024 21:21:56 +0300	[thread overview]
Message-ID: <26kbmvputkbfuz7zdfa2wblsgz5sn6iwucwscswwrpbu7ttwmj@3btn75ewpdwi> (raw)
In-Reply-To: <aa9e291e181017146f88238cdeec9f18759915c3.1714046812.git.siyanteng@loongson.cn>

> [PATCH net-next v12 07/15] net: stmmac: dwmac-loongson: Add ref and ptp clocks for Loongson

s/ptp/PTP

Mentioning Loongson is redundant. Just:

net: stmmac: dwmac-loongson: Init ref and PTP clocks rate

On Thu, Apr 25, 2024 at 09:06:10PM +0800, Yanteng Si wrote:
> The ref/ptp clock of gmac(amd gnet) is 125000000.

What about a log like this?

"Reference and PTP clocks rate of the Loongson GMAC devices is 125MHz.
(So is in the GNET devices which support is about to be added.) Set
the respective plat_stmmacenet_data field up in accordance with that
so to have the coalesce command and timestamping work correctly."

-Serge(y)

> 
> Signed-off-by: Feiyang Chen <chenfeiyang@loongson.cn>
> Signed-off-by: Yinggang Gu <guyinggang@loongson.cn>
> Signed-off-by: Yanteng Si <siyanteng@loongson.cn>
> ---
>  drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> index 904e288d0be0..9f208f84c1e7 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> @@ -32,6 +32,9 @@ static void loongson_default_data(struct plat_stmmacenet_data *plat)
>  	/* Disable RX queues routing by default */
>  	plat->rx_queues_cfg[0].pkt_route = 0x0;
>  
> +	plat->clk_ref_rate = 125000000;
> +	plat->clk_ptp_rate = 125000000;
> +
>  	/* Default to phy auto-detection */
>  	plat->phy_addr = -1;
>  
> -- 
> 2.31.4
> 

  reply	other threads:[~2024-05-03 18:22 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-25 13:01 [PATCH net-next v12 00/15] stmmac: Add Loongson platform support Yanteng Si
2024-04-25 13:01 ` [PATCH net-next v12 01/15] net: stmmac: Move the atds flag to the stmmac_dma_cfg structure Yanteng Si
2024-05-02 19:10   ` Serge Semin
2024-05-09 12:44     ` Yanteng Si
2024-04-25 13:01 ` [PATCH net-next v12 02/15] net: stmmac: Add multi-channel support Yanteng Si
2024-05-02 22:02   ` Serge Semin
2024-05-10 10:13     ` Yanteng Si
2024-05-13  9:45       ` Serge Semin
2024-05-13  9:49         ` Yanteng Si
2024-04-25 13:01 ` [PATCH net-next v12 03/15] net: stmmac: Export dwmac1000_dma_ops Yanteng Si
2024-05-03 10:27   ` Serge Semin
2024-05-13  9:46     ` Yanteng Si
2024-04-25 13:04 ` [PATCH net-next v12 04/15] net: stmmac: dwmac-loongson: Drop useless platform data Yanteng Si
2024-05-03 10:55   ` Serge Semin
2024-05-03 14:47     ` Serge Semin
2024-05-13  9:47       ` Yanteng Si
2024-05-13  9:46     ` Yanteng Si
2024-04-25 13:04 ` [PATCH net-next v12 05/15] net: stmmac: dwmac-loongson: Use PCI_DEVICE_DATA() macro for device identification Yanteng Si
2024-05-03 13:43   ` Serge Semin
2024-05-13  9:50     ` Yanteng Si
2024-04-25 13:04 ` [PATCH net-next v12 06/15] net: stmmac: dwmac-loongson: Split up the platform data initialization Yanteng Si
2024-05-03 18:08   ` Serge Semin
2024-05-13 11:07     ` Yanteng Si
2024-05-13 12:42       ` Huacai Chen
2024-05-13 14:04       ` Serge Semin
2024-05-18 10:38         ` yanteng si
2024-04-25 13:06 ` [PATCH net-next v12 07/15] net: stmmac: dwmac-loongson: Add ref and ptp clocks for Loongson Yanteng Si
2024-05-03 18:21   ` Serge Semin [this message]
2024-05-09 13:01     ` Yanteng Si
2024-04-25 13:06 ` [PATCH net-next v12 08/15] net: stmmac: dwmac-loongson: Add phy mask for Loongson GMAC Yanteng Si
2024-05-03 18:28   ` Serge Semin
2024-05-13 10:23     ` Yanteng Si
2024-04-25 13:06 ` [PATCH net-next v12 09/15] net: stmmac: dwmac-loongson: Add phy_interface " Yanteng Si
2024-04-25 14:36   ` Russell King (Oracle)
2024-04-26 10:16     ` Yanteng Si
2024-04-26 11:00       ` Russell King (Oracle)
2024-05-03 21:01         ` Serge Semin
2024-05-07  8:22           ` Russell King (Oracle)
2024-04-25 13:10 ` [PATCH net-next v12 10/15] net: stmmac: dwmac-loongson: Add full PCI support Yanteng Si
2024-05-04 20:46   ` Serge Semin
2024-05-13 10:49     ` Yanteng Si
2024-04-25 13:10 ` [PATCH net-next v12 11/15] net: stmmac: dwmac-loongson: Add loongson_dwmac_config_legacy Yanteng Si
2024-05-04 21:28   ` Serge Semin
2024-05-13 10:12     ` Yanteng Si
2024-04-25 13:10 ` [PATCH net-next v12 12/15] net: stmmac: dwmac-loongson: Fixed failure to set network speed to 1000 Yanteng Si
2024-05-04 22:13   ` Serge Semin
2024-05-13 10:16     ` Yanteng Si
2024-04-25 13:11 ` [PATCH net-next v12 13/15] net: stmmac: dwmac-loongson: Add Loongson GNET support Yanteng Si
2024-04-26  5:12   ` Yanteng Si
2024-05-05 21:50   ` Serge Semin
2024-05-17  8:12     ` Yanteng Si
2024-05-17  9:48       ` Serge Semin
2024-05-17 11:14         ` yanteng si
2024-05-06 10:39   ` Serge Semin
2024-05-07 13:35     ` Yanteng Si
2024-05-08 14:38       ` Serge Semin
2024-05-08 14:58         ` Huacai Chen
2024-05-08 15:10           ` Serge Semin
2024-05-09  8:57             ` Yanteng Si
2024-05-13 10:56               ` Serge Semin
2024-05-13 13:26                 ` Huacai Chen
2024-05-13 16:11                   ` Serge Semin
2024-05-14  4:58                     ` Huacai Chen
2024-05-14 11:33                       ` Serge Semin
2024-05-14 12:53                         ` Huacai Chen
2024-05-15  8:40                           ` Serge Semin
2024-05-15 13:55                             ` Huacai Chen
2024-05-17  8:42                               ` Yanteng Si
2024-05-17  9:07                                 ` Serge Semin
2024-05-17 10:37                                   ` Yanteng Si
2024-05-17 16:37                                     ` Serge Semin
2024-05-18 10:47                                       ` yanteng si
2024-04-25 13:11 ` [PATCH net-next v12 14/15] net: stmmac: dwmac-loongson: Move disable_force flag to _gnet_date Yanteng Si
2024-05-05 21:53   ` Serge Semin
2024-05-13 10:20     ` Yanteng Si
2024-04-25 13:11 ` [PATCH net-next v12 15/15] net: stmmac: dwmac-loongson: Add loongson module author Yanteng Si
2024-05-06  2:12   ` Huacai Chen
2024-05-06  4:44     ` Serge Semin
2024-04-25 13:19 ` [PATCH net-next v12 00/15] stmmac: Add Loongson platform support Serge Semin
2024-04-26  4:55   ` Yanteng Si
2024-04-26 11:51     ` Serge Semin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26kbmvputkbfuz7zdfa2wblsgz5sn6iwucwscswwrpbu7ttwmj@3btn75ewpdwi \
    --to=fancer.lancer@gmail.com \
    --cc=Jose.Abreu@synopsys.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew@lunn.ch \
    --cc=chenhuacai@kernel.org \
    --cc=chris.chenfeiyang@gmail.com \
    --cc=guyinggang@loongson.cn \
    --cc=hkallweit1@gmail.com \
    --cc=joabreu@synopsys.com \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    --cc=siyanteng01@gmail.com \
    --cc=siyanteng@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).