From: "Arinzon, David" <darinzon@amazon.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
"Machulsky, Zorik" <zorik@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>,
"Bshara, Saeed" <saeedb@amazon.com>,
"Wilson, Matt" <msw@amazon.com>,
"Liguori, Anthony" <aliguori@amazon.com>,
"Bshara, Nafea" <nafea@amazon.com>,
"Belgazal, Netanel" <netanel@amazon.com>,
"Saidi, Ali" <alisaidi@amazon.com>,
"Herrenschmidt, Benjamin" <benh@amazon.com>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Dagan, Noam" <ndagan@amazon.com>,
"Agroskin, Shay" <shayagr@amazon.com>,
"Itzko, Shahar" <itzko@amazon.com>,
"Abboud, Osama" <osamaabb@amazon.com>,
"Ostrovsky, Evgeny" <evostrov@amazon.com>,
"Tabachnik, Ofir" <ofirt@amazon.com>
Subject: RE: [PATCH v1 net-next 3/6] net: ena: Add validation for completion descriptors consistency
Date: Wed, 8 May 2024 06:01:33 +0000 [thread overview]
Message-ID: <486d3c51e2014d0ebae36b25be276bf9@amazon.com> (raw)
In-Reply-To: <20240507193302.440feb6e@kernel.org>
> > + if (unlikely((status & ENA_ETH_IO_RX_CDESC_BASE_FIRST_MASK)
> >>
> > + ENA_ETH_IO_RX_CDESC_BASE_FIRST_SHIFT && count != 0)) {
> > + struct ena_com_dev *dev =
> > + ena_com_io_cq_to_ena_dev(io_cq);
> > +
> > + netdev_err(dev->net_device,
> > + "First bit is on in descriptor #%d on q_id: %d, req_id:
> %u\n",
> > + count, io_cq->qid, cdesc->req_id);
> > + return -EFAULT;
>
> This is really asking to be a devlink health reporter.
> You can dump the information to the user and get the event counter for
> free.
>
> But if you don't want to use that - please at least rate limit the message.
Hi Jakub,
Thank you for reviewing the patch.
We have an action item to review the devlink health mechanism to see how it can benefit
our solution. Thank you for raising this point.
Regarding this print, I don't expect it to be printed more than once,
as a failure here returns -EFAULT which triggers an error flow and an ENA reset sequence,
which will also stop the TX and RX queues as part of it, and no further descriptors will
be processed until the reset sequence is complete.
Please let us know if you still have concerns regarding this print.
next prev parent reply other threads:[~2024-05-08 6:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 7:04 [PATCH v1 net-next 0/6] ENA driver changes May 2024 darinzon
2024-05-06 7:04 ` [PATCH v1 net-next 1/6] net: ena: Add a counter for driver's reset failures darinzon
2024-05-06 7:04 ` [PATCH v1 net-next 2/6] net: ena: Reduce holes in ena_com structures darinzon
2024-05-06 7:04 ` [PATCH v1 net-next 3/6] net: ena: Add validation for completion descriptors consistency darinzon
2024-05-08 2:33 ` Jakub Kicinski
2024-05-08 6:01 ` Arinzon, David [this message]
2024-05-06 7:04 ` [PATCH v1 net-next 4/6] net: ena: Changes around strscpy calls darinzon
2024-05-06 7:04 ` [PATCH v1 net-next 5/6] net: ena: Change initial rx_usec interval darinzon
2024-05-06 7:04 ` [PATCH v1 net-next 6/6] net: ena: Add a field for no interrupt moderation update action darinzon
2024-05-08 2:31 ` Jakub Kicinski
2024-05-08 5:55 ` Arinzon, David
2024-05-08 15:33 ` Jakub Kicinski
2024-05-09 7:25 ` Arinzon, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486d3c51e2014d0ebae36b25be276bf9@amazon.com \
--to=darinzon@amazon.com \
--cc=akiyano@amazon.com \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=benh@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.co.uk \
--cc=evostrov@amazon.com \
--cc=itzko@amazon.com \
--cc=kuba@kernel.org \
--cc=matua@amazon.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=ndagan@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=ofirt@amazon.com \
--cc=osamaabb@amazon.com \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).