* Re: [PATCH RESEND net-next 0/3] dts: hisi: fixes can't find eth for hip05-D02
2015-12-05 7:54 [PATCH RESEND net-next 0/3] dts: hisi: fixes can't find eth for hip05-D02 yankejian
@ 2015-12-05 7:47 ` Yankejian (Hackim Yim)
2015-12-05 7:54 ` [PATCH RESEND net-next 1/3] dts: hisi: enables the ethX for D02 board yankejian
` (2 subsequent siblings)
3 siblings, 0 replies; 11+ messages in thread
From: Yankejian (Hackim Yim) @ 2015-12-05 7:47 UTC (permalink / raw
To: davem, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
xuwei5, catalin.marinas, will.deacon, wangkefeng.wang,
dingtianhong, liguozhu, Yisen.Zhuang, sboyd, haojian.zhuang,
wangzhou1, bintian.wang, long.wanglong, leo.yan
Cc: devicetree, netdev, linuxarm, linux-kernel, linux-arm-kernel
sorry, pls ignore this patchset.
On 2015/12/5 15:54, yankejian wrote:
> this patchset fixes the bug that eth can't initial successful on hip05-D02
> because the dts files doesn't match the source code.
>
> yankejian (3):
> dts: hisi: enables the ethX for D02 board
> dts: hisi: fixes no syscon error when init mdio
> arm64: hip05-d02: Document devicetree bindings for Hisilicon D02 Board
>
> .../devicetree/bindings/arm/hisilicon/hisilicon.txt | 16 ++++++++++++++++
> arch/arm64/boot/dts/hisilicon/hip05-d02.dts | 16 ++++++++++++++++
> arch/arm64/boot/dts/hisilicon/hip05.dtsi | 4 ++++
> arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi | 4 ++--
> 4 files changed, 38 insertions(+), 2 deletions(-)
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH RESEND net-next 0/3] dts: hisi: fixes can't find eth for hip05-D02
@ 2015-12-05 7:54 yankejian
2015-12-05 7:47 ` Yankejian (Hackim Yim)
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: yankejian @ 2015-12-05 7:54 UTC (permalink / raw
To: davem, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
xuwei5, catalin.marinas, will.deacon, wangkefeng.wang,
dingtianhong, liguozhu, Yisen.Zhuang, sboyd, haojian.zhuang,
wangzhou1, bintian.wang, long.wanglong, leo.yan
Cc: haifeng.wei, devicetree, linux-arm-kernel, linux-kernel, netdev,
linuxarm
this patchset fixes the bug that eth can't initial successful on hip05-D02
because the dts files doesn't match the source code.
yankejian (3):
dts: hisi: enables the ethX for D02 board
dts: hisi: fixes no syscon error when init mdio
arm64: hip05-d02: Document devicetree bindings for Hisilicon D02 Board
.../devicetree/bindings/arm/hisilicon/hisilicon.txt | 16 ++++++++++++++++
arch/arm64/boot/dts/hisilicon/hip05-d02.dts | 16 ++++++++++++++++
arch/arm64/boot/dts/hisilicon/hip05.dtsi | 4 ++++
arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi | 4 ++--
4 files changed, 38 insertions(+), 2 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH RESEND net-next 1/3] dts: hisi: enables the ethX for D02 board
2015-12-05 7:54 [PATCH RESEND net-next 0/3] dts: hisi: fixes can't find eth for hip05-D02 yankejian
2015-12-05 7:47 ` Yankejian (Hackim Yim)
@ 2015-12-05 7:54 ` yankejian
2015-12-05 7:54 ` [PATCH RESEND net-next 2/3] dts: hisi: fixes no syscon error when init mdio yankejian
2015-12-05 7:54 ` [PATCH RESEND net-next 3/3] arm64: hip05-d02: Document devicetree bindings for Hisilicon D02 Board yankejian
3 siblings, 0 replies; 11+ messages in thread
From: yankejian @ 2015-12-05 7:54 UTC (permalink / raw
To: davem, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
xuwei5, catalin.marinas, will.deacon, wangkefeng.wang,
dingtianhong, liguozhu, Yisen.Zhuang, sboyd, haojian.zhuang,
wangzhou1, bintian.wang, long.wanglong, leo.yan
Cc: haifeng.wei, devicetree, linux-arm-kernel, linux-kernel, netdev,
linuxarm
this patch enables the ethX for D02 board on hip05-d02.dts. otherwise it
cannot find hns ethX by ifconfig -a.
Signed-off-by: yankejian <yankejian@huawei.com>
---
arch/arm64/boot/dts/hisilicon/hip05-d02.dts | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/hisilicon/hip05-d02.dts b/arch/arm64/boot/dts/hisilicon/hip05-d02.dts
index ae34e25..6aa5cb2 100644
--- a/arch/arm64/boot/dts/hisilicon/hip05-d02.dts
+++ b/arch/arm64/boot/dts/hisilicon/hip05-d02.dts
@@ -34,3 +34,19 @@
&uart0 {
status = "ok";
};
+
+ð2 {
+ status = "okay";
+};
+
+ð3 {
+ status = "okay";
+};
+
+ð6 {
+ status = "okay";
+};
+
+ð7 {
+ status = "okay";
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH RESEND net-next 2/3] dts: hisi: fixes no syscon error when init mdio
2015-12-05 7:54 [PATCH RESEND net-next 0/3] dts: hisi: fixes can't find eth for hip05-D02 yankejian
2015-12-05 7:47 ` Yankejian (Hackim Yim)
2015-12-05 7:54 ` [PATCH RESEND net-next 1/3] dts: hisi: enables the ethX for D02 board yankejian
@ 2015-12-05 7:54 ` yankejian
2015-12-05 7:54 ` [PATCH RESEND net-next 3/3] arm64: hip05-d02: Document devicetree bindings for Hisilicon D02 Board yankejian
3 siblings, 0 replies; 11+ messages in thread
From: yankejian @ 2015-12-05 7:54 UTC (permalink / raw
To: davem, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
xuwei5, catalin.marinas, will.deacon, wangkefeng.wang,
dingtianhong, liguozhu, Yisen.Zhuang, sboyd, haojian.zhuang,
wangzhou1, bintian.wang, long.wanglong, leo.yan
Cc: haifeng.wei, devicetree, linux-arm-kernel, linux-kernel, netdev,
linuxarm
when linux start up, we get the log below:
"Hi-HNS_MDIO 803c0000.mdio: no syscon hisilicon,peri-c-subctrl
mdio_bus mdio@803c0000: mdio sys ctl reg has not maped "
the source code about the subctrl is dealled with syscon, but dts doesn't.
it cause such fault. so this patch adds the syscon info on dts files to
fixes it.
Signed-off-by: yankejian <yankejian@huawei.com>
---
arch/arm64/boot/dts/hisilicon/hip05.dtsi | 4 ++++
arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi | 4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hip05.dtsi b/arch/arm64/boot/dts/hisilicon/hip05.dtsi
index 4ff16d0..daaca63 100644
--- a/arch/arm64/boot/dts/hisilicon/hip05.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hip05.dtsi
@@ -246,6 +246,10 @@
clock-frequency = <200000000>;
};
+ peri_c_subctrl: sub_ctrl_c@80000000 {
+ compatible = "hisilicon,peri-c-subctrl", "syscon";
+ reg = < 0x0 0x80000000 0x0 0x10000>;
+ };
uart0: uart@80300000 {
compatible = "snps,dw-apb-uart";
reg = <0x0 0x80300000 0x0 0x10000>;
diff --git a/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi b/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi
index 606dd5a..4d4815e 100644
--- a/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi
@@ -10,8 +10,8 @@ soc0: soc@000000000 {
#address-cells = <1>;
#size-cells = <0>;
compatible = "hisilicon,hns-mdio";
- reg = <0x0 0x803c0000 0x0 0x10000
- 0x0 0x80000000 0x0 0x10000>;
+ reg = <0x0 0x803c0000 0x0 0x10000>;
+ subctrl_vbase = <&peri_c_subctrl>;
soc0_phy0: ethernet-phy@0 {
reg = <0x0>;
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH RESEND net-next 3/3] arm64: hip05-d02: Document devicetree bindings for Hisilicon D02 Board
2015-12-05 7:54 [PATCH RESEND net-next 0/3] dts: hisi: fixes can't find eth for hip05-D02 yankejian
` (2 preceding siblings ...)
2015-12-05 7:54 ` [PATCH RESEND net-next 2/3] dts: hisi: fixes no syscon error when init mdio yankejian
@ 2015-12-05 7:54 ` yankejian
2015-12-07 13:16 ` Rob Herring
3 siblings, 1 reply; 11+ messages in thread
From: yankejian @ 2015-12-05 7:54 UTC (permalink / raw
To: davem, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
xuwei5, catalin.marinas, will.deacon, wangkefeng.wang,
dingtianhong, liguozhu, Yisen.Zhuang, sboyd, haojian.zhuang,
wangzhou1, bintian.wang, long.wanglong, leo.yan
Cc: haifeng.wei, devicetree, linux-arm-kernel, linux-kernel, netdev,
linuxarm
This patch adds documentation for the devicetree bindings used by the
DT files of Hisilicon Hip05-D02 development board.
Signed-off-by: yankejian <yankejian@huawei.com>
---
.../devicetree/bindings/arm/hisilicon/hisilicon.txt | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
index 6ac7c00..5318d78 100644
--- a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
+++ b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
@@ -187,6 +187,22 @@ Example:
reg = <0xb0000000 0x10000>;
};
+Hisilicon HiP05 PERISUB system controller
+
+Required properties:
+- compatible : "hisilicon,peri-c-subctrl", "syscon";
+- reg : Register address and size
+
+The HiP05 PERISUB system controller is shared by peripheral controllers in
+HiP05 Soc to implement some basic configurations. the peripheral
+ controllers include mdio, ddr, iic, uart, timer and so on.
+
+Example:
+ /* for HiP05 PCIe-SAS system */
+ pcie_sas: system_controller@0xb0000000 {
+ compatible = "hisilicon,pcie-sas-subctrl", "syscon";
+ reg = <0xb0000000 0x10000>;
+ };
-----------------------------------------------------------------------
Hisilicon CPU controller
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH RESEND net-next 3/3] arm64: hip05-d02: Document devicetree bindings for Hisilicon D02 Board
2015-12-05 7:56 [PATCH RESEND net-next 0/3] dts: hisi: fixes can't find eth for hip05-D02 yankejian
@ 2015-12-05 7:56 ` yankejian
[not found] ` <1449302218-54374-4-git-send-email-yankejian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 11+ messages in thread
From: yankejian @ 2015-12-05 7:56 UTC (permalink / raw
To: davem, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
xuwei5, catalin.marinas, will.deacon, wangkefeng.wang,
dingtianhong, liguozhu, Yisen.Zhuang, sboyd, haojian.zhuang,
wangzhou1, bintian.wang, long.wanglong, leo.yan
Cc: devicetree, haifeng.wei, netdev, linuxarm, linux-kernel,
linux-arm-kernel
This patch adds documentation for the devicetree bindings used by the
DT files of Hisilicon Hip05-D02 development board.
Signed-off-by: yankejian <yankejian@huawei.com>
---
.../devicetree/bindings/arm/hisilicon/hisilicon.txt | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
index 6ac7c00..5318d78 100644
--- a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
+++ b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
@@ -187,6 +187,22 @@ Example:
reg = <0xb0000000 0x10000>;
};
+Hisilicon HiP05 PERISUB system controller
+
+Required properties:
+- compatible : "hisilicon,peri-c-subctrl", "syscon";
+- reg : Register address and size
+
+The HiP05 PERISUB system controller is shared by peripheral controllers in
+HiP05 Soc to implement some basic configurations. the peripheral
+ controllers include mdio, ddr, iic, uart, timer and so on.
+
+Example:
+ /* for HiP05 PCIe-SAS system */
+ pcie_sas: system_controller@0xb0000000 {
+ compatible = "hisilicon,pcie-sas-subctrl", "syscon";
+ reg = <0xb0000000 0x10000>;
+ };
-----------------------------------------------------------------------
Hisilicon CPU controller
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH RESEND net-next 3/3] arm64: hip05-d02: Document devicetree bindings for Hisilicon D02 Board
[not found] ` <1449302218-54374-4-git-send-email-yankejian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
@ 2015-12-05 22:13 ` Arnd Bergmann
2015-12-07 1:29 ` Yankejian (Hackim Yim)
0 siblings, 1 reply; 11+ messages in thread
From: Arnd Bergmann @ 2015-12-05 22:13 UTC (permalink / raw
To: yankejian
Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, xuwei5-C8/M+/jPZTeaMJb+Lgu22Q,
catalin.marinas-5wv7dgnIgG8, will.deacon-5wv7dgnIgG8,
wangkefeng.wang-hv44wF8Li93QT0dZR+AlfA,
dingtianhong-hv44wF8Li93QT0dZR+AlfA,
liguozhu-hv44wF8Li93QT0dZR+AlfA,
Yisen.Zhuang-hv44wF8Li93QT0dZR+AlfA, sboyd-sgV2jX0FEOL9JmXXK+q4OQ,
haojian.zhuang-QSEj5FYQhm4dnm+yROfE0A,
wangzhou1-C8/M+/jPZTeaMJb+Lgu22Q,
bintian.wang-hv44wF8Li93QT0dZR+AlfA,
long.wanglong-hv44wF8Li93QT0dZR+AlfA,
leo.yan-QSEj5FYQhm4dnm+yROfE0A,
haifeng.wei-hv44wF8Li93QT0dZR+AlfA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA, linuxarm-hv44wF8Li93QT0dZR+AlfA
On Saturday 05 December 2015 15:56:58 yankejian wrote:
> +Required properties:
> +- compatible : "hisilicon,peri-c-subctrl", "syscon";
> +- reg : Register address and size
> +
> +The HiP05 PERISUB system controller is shared by peripheral controllers in
> +HiP05 Soc to implement some basic configurations. the peripheral
> + controllers include mdio, ddr, iic, uart, timer and so on.
> +
> +Example:
> + /* for HiP05 PCIe-SAS system */
> + pcie_sas: system_controller@0xb0000000 {
> + compatible = "hisilicon,pcie-sas-subctrl", "syscon";
> + reg = <0xb0000000 0x10000>;
> + };
>
The compatible string in the example does not match the required properties.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH RESEND net-next 3/3] arm64: hip05-d02: Document devicetree bindings for Hisilicon D02 Board
2015-12-05 22:13 ` Arnd Bergmann
@ 2015-12-07 1:29 ` Yankejian (Hackim Yim)
0 siblings, 0 replies; 11+ messages in thread
From: Yankejian (Hackim Yim) @ 2015-12-07 1:29 UTC (permalink / raw
To: Arnd Bergmann
Cc: davem, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
xuwei5, catalin.marinas, will.deacon, wangkefeng.wang,
dingtianhong, liguozhu, Yisen.Zhuang, sboyd, haojian.zhuang,
wangzhou1, bintian.wang, long.wanglong, leo.yan, haifeng.wei,
devicetree, linux-arm-kernel, linux-kernel, netdev, linuxarm
On 2015/12/6 6:13, Arnd Bergmann wrote:
> On Saturday 05 December 2015 15:56:58 yankejian wrote:
>> +Required properties:
>> +- compatible : "hisilicon,peri-c-subctrl", "syscon";
>> +- reg : Register address and size
>> +
>> +The HiP05 PERISUB system controller is shared by peripheral controllers in
>> +HiP05 Soc to implement some basic configurations. the peripheral
>> + controllers include mdio, ddr, iic, uart, timer and so on.
>> +
>> +Example:
>> + /* for HiP05 PCIe-SAS system */
>> + pcie_sas: system_controller@0xb0000000 {
>> + compatible = "hisilicon,pcie-sas-subctrl", "syscon";
>> + reg = <0xb0000000 0x10000>;
>> + };
>>
> The compatible string in the example does not match the required properties.
>
> Arnd
>
> .
Hi, Arnd
Thanks for your suggestions. i will fixes it later.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH RESEND net-next 3/3] arm64: hip05-d02: Document devicetree bindings for Hisilicon D02 Board
2015-12-05 7:54 ` [PATCH RESEND net-next 3/3] arm64: hip05-d02: Document devicetree bindings for Hisilicon D02 Board yankejian
@ 2015-12-07 13:16 ` Rob Herring
2015-12-07 13:48 ` Bintian
0 siblings, 1 reply; 11+ messages in thread
From: Rob Herring @ 2015-12-07 13:16 UTC (permalink / raw
To: yankejian
Cc: davem, pawel.moll, mark.rutland, ijc+devicetree, galak, xuwei5,
catalin.marinas, will.deacon, wangkefeng.wang, dingtianhong,
liguozhu, Yisen.Zhuang, sboyd, haojian.zhuang, wangzhou1,
bintian.wang, long.wanglong, leo.yan, haifeng.wei, devicetree,
linux-arm-kernel, linux-kernel, netdev, linuxarm
On Sat, Dec 05, 2015 at 03:54:48PM +0800, yankejian wrote:
> This patch adds documentation for the devicetree bindings used by the
> DT files of Hisilicon Hip05-D02 development board.
>
> Signed-off-by: yankejian <yankejian@huawei.com>
> ---
> .../devicetree/bindings/arm/hisilicon/hisilicon.txt | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
> index 6ac7c00..5318d78 100644
> --- a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
> +++ b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
> @@ -187,6 +187,22 @@ Example:
> reg = <0xb0000000 0x10000>;
> };
>
> +Hisilicon HiP05 PERISUB system controller
> +
> +Required properties:
> +- compatible : "hisilicon,peri-c-subctrl", "syscon";
This should be more specific and have the SOC name in it.
> +- reg : Register address and size
> +
> +The HiP05 PERISUB system controller is shared by peripheral controllers in
> +HiP05 Soc to implement some basic configurations. the peripheral
> + controllers include mdio, ddr, iic, uart, timer and so on.
> +
> +Example:
> + /* for HiP05 PCIe-SAS system */
> + pcie_sas: system_controller@0xb0000000 {
> + compatible = "hisilicon,pcie-sas-subctrl", "syscon";
The example doesn't match.
> + reg = <0xb0000000 0x10000>;
> + };
> -----------------------------------------------------------------------
> Hisilicon CPU controller
>
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH RESEND net-next 3/3] arm64: hip05-d02: Document devicetree bindings for Hisilicon D02 Board
2015-12-07 13:16 ` Rob Herring
@ 2015-12-07 13:48 ` Bintian
2015-12-08 1:45 ` Yankejian (Hackim Yim)
0 siblings, 1 reply; 11+ messages in thread
From: Bintian @ 2015-12-07 13:48 UTC (permalink / raw
To: yankejian
Cc: Rob Herring, davem, pawel.moll, mark.rutland, ijc+devicetree,
galak, xuwei5, catalin.marinas, will.deacon, wangkefeng.wang,
dingtianhong, liguozhu, Yisen.Zhuang, sboyd, haojian.zhuang,
wangzhou1, long.wanglong, leo.yan, haifeng.wei, devicetree,
linux-arm-kernel, linux-kernel, netdev, linuxarm
On 2015/12/7 21:16, Rob Herring wrote:
> On Sat, Dec 05, 2015 at 03:54:48PM +0800, yankejian wrote:
>> This patch adds documentation for the devicetree bindings used by the
>> DT files of Hisilicon Hip05-D02 development board.
>>
>> Signed-off-by: yankejian <yankejian@huawei.com>
You may need to configure as "Kejian Yan <yankejian@huawei.com>" :)
BR,
Bintian
>> ---
>> .../devicetree/bindings/arm/hisilicon/hisilicon.txt | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
>> index 6ac7c00..5318d78 100644
>> --- a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
>> +++ b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
>> @@ -187,6 +187,22 @@ Example:
>> reg = <0xb0000000 0x10000>;
>> };
>>
>> +Hisilicon HiP05 PERISUB system controller
>> +
>> +Required properties:
>> +- compatible : "hisilicon,peri-c-subctrl", "syscon";
> This should be more specific and have the SOC name in it.
>
>> +- reg : Register address and size
>> +
>> +The HiP05 PERISUB system controller is shared by peripheral controllers in
>> +HiP05 Soc to implement some basic configurations. the peripheral
>> + controllers include mdio, ddr, iic, uart, timer and so on.
>> +
>> +Example:
>> + /* for HiP05 PCIe-SAS system */
>> + pcie_sas: system_controller@0xb0000000 {
>> + compatible = "hisilicon,pcie-sas-subctrl", "syscon";
> The example doesn't match.
>
>> + reg = <0xb0000000 0x10000>;
>> + };
>> -----------------------------------------------------------------------
>> Hisilicon CPU controller
>>
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
> .
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH RESEND net-next 3/3] arm64: hip05-d02: Document devicetree bindings for Hisilicon D02 Board
2015-12-07 13:48 ` Bintian
@ 2015-12-08 1:45 ` Yankejian (Hackim Yim)
0 siblings, 0 replies; 11+ messages in thread
From: Yankejian (Hackim Yim) @ 2015-12-08 1:45 UTC (permalink / raw
To: Bintian
Cc: Rob Herring, davem, pawel.moll, mark.rutland, ijc+devicetree,
galak, xuwei5, catalin.marinas, will.deacon, wangkefeng.wang,
dingtianhong, liguozhu, Yisen.Zhuang, sboyd, haojian.zhuang,
wangzhou1, long.wanglong, leo.yan, haifeng.wei, devicetree,
linux-arm-kernel, linux-kernel, netdev, linuxarm
On 2015/12/7 21:48, Bintian wrote:
> On 2015/12/7 21:16, Rob Herring wrote:
>> On Sat, Dec 05, 2015 at 03:54:48PM +0800, yankejian wrote:
>>> This patch adds documentation for the devicetree bindings used by the
>>> DT files of Hisilicon Hip05-D02 development board.
>>>
>>> Signed-off-by: yankejian <yankejian@huawei.com>
> You may need to configure as "Kejian Yan <yankejian@huawei.com>" :)
>
> BR,
>
> Bintian
agree, thanks
BR,
Kejian Yan
>>> ---
>>> .../devicetree/bindings/arm/hisilicon/hisilicon.txt | 16 ++++++++++++++++
>>> 1 file changed, 16 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
>>> index 6ac7c00..5318d78 100644
>>> --- a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
>>> +++ b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
>>> @@ -187,6 +187,22 @@ Example:
>>> reg = <0xb0000000 0x10000>;
>>> };
>>> +Hisilicon HiP05 PERISUB system controller
>>> +
>>> +Required properties:
>>> +- compatible : "hisilicon,peri-c-subctrl", "syscon";
>> This should be more specific and have the SOC name in it.
>>
>>> +- reg : Register address and size
>>> +
>>> +The HiP05 PERISUB system controller is shared by peripheral controllers in
>>> +HiP05 Soc to implement some basic configurations. the peripheral
>>> + controllers include mdio, ddr, iic, uart, timer and so on.
>>> +
>>> +Example:
>>> + /* for HiP05 PCIe-SAS system */
>>> + pcie_sas: system_controller@0xb0000000 {
>>> + compatible = "hisilicon,pcie-sas-subctrl", "syscon";
>> The example doesn't match.
>>
Thanks for this. I have changed this in PATCH V2 already floated.
BR
Kejian Yan
>>> + reg = <0xb0000000 0x10000>;
>>> + };
>>> -----------------------------------------------------------------------
>>> Hisilicon CPU controller
>>> --
>>> 1.9.1
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>>
>> .
>>
>
>
>
> .
>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2015-12-08 1:45 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-05 7:54 [PATCH RESEND net-next 0/3] dts: hisi: fixes can't find eth for hip05-D02 yankejian
2015-12-05 7:47 ` Yankejian (Hackim Yim)
2015-12-05 7:54 ` [PATCH RESEND net-next 1/3] dts: hisi: enables the ethX for D02 board yankejian
2015-12-05 7:54 ` [PATCH RESEND net-next 2/3] dts: hisi: fixes no syscon error when init mdio yankejian
2015-12-05 7:54 ` [PATCH RESEND net-next 3/3] arm64: hip05-d02: Document devicetree bindings for Hisilicon D02 Board yankejian
2015-12-07 13:16 ` Rob Herring
2015-12-07 13:48 ` Bintian
2015-12-08 1:45 ` Yankejian (Hackim Yim)
-- strict thread matches above, loose matches on Subject: below --
2015-12-05 7:56 [PATCH RESEND net-next 0/3] dts: hisi: fixes can't find eth for hip05-D02 yankejian
2015-12-05 7:56 ` [PATCH RESEND net-next 3/3] arm64: hip05-d02: Document devicetree bindings for Hisilicon D02 Board yankejian
[not found] ` <1449302218-54374-4-git-send-email-yankejian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-12-05 22:13 ` Arnd Bergmann
2015-12-07 1:29 ` Yankejian (Hackim Yim)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).