From: Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Simon Horman <horms@kernel.org>
Cc: gregkh@linuxfoundation.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
johannes@sipsolutions.net, philipp.g.hortmann@gmail.com,
tdavies@darkphysics.net, garyrookard@fastmail.org,
straube.linux@gmail.com, linux-staging@lists.linux.dev,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/3] lib80211: Handle const struct lib80211_crypto_ops in lib80211
Date: Sun, 12 May 2024 09:25:40 +0200 [thread overview]
Message-ID: <5dd2eceb-4108-4071-b7b5-1fcac0a9d2ef@wanadoo.fr> (raw)
In-Reply-To: <b6042eae-88cd-4f95-88d8-d1812c2930de@wanadoo.fr>
Le 11/05/2024 à 23:47, Christophe JAILLET a écrit :
> Le 11/05/2024 à 22:31, Simon Horman a écrit :
>> On Sat, May 11, 2024 at 06:32:38PM +0200, Christophe JAILLET wrote:
>>> lib80211_register_crypto_ops() and lib80211_unregister_crypto_ops()
>>> don't
>>> modify their "struct lib80211_crypto_ops *ops" argument. So, it can be
>>> declared as const.
>>>
>>> Doing so, some adjustments are needed to also constify some date in
>>> "struct lib80211_crypt_data", "struct lib80211_crypto_alg" and the
>>> return value of lib80211_get_crypto_ops().
>>>
>>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>>> ---
>>> Compile tested only.
>>
>> Hi Christophe,
>>
>> Unfortunately allmodconfig W=1 build on x86_64 with Clang says:
>>
>> .../libipw_wx.c:587:6: error: assigning to 'struct lib80211_crypto_ops
>> *' from 'const struct lib80211_crypto_ops *' discards qualifiers
>> [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
>> 587 | ops = lib80211_get_crypto_ops(alg);
>> | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> .../libipw_wx.c:590:7: error: assigning to 'struct lib80211_crypto_ops
>> *' from 'const struct lib80211_crypto_ops *' discards qualifiers
>> [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
>> 590 | ops = lib80211_get_crypto_ops(alg);
>> | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>
> Hi,
>
> I'll dig more tomorrow, but I don't see this error (with gcc), even with
> W=1.
>
> The following part of the patch is here to avoid the exact compilation
> error that you see.
>
> Strange.
>
> CJ
>
Ok, got it.
Thanks for the pointer.
I don't know how I missed this one. :(
I'll send a v2.
CJ
next prev parent reply other threads:[~2024-05-12 7:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 16:32 [PATCH 0/3] lib80211: Constify struct lib80211_crypto_ops Christophe JAILLET
2024-05-11 16:32 ` [PATCH 1/3] lib80211: Handle const struct lib80211_crypto_ops in lib80211 Christophe JAILLET
2024-05-11 20:31 ` Simon Horman
2024-05-11 21:47 ` Christophe JAILLET
2024-05-12 7:25 ` Marion & Christophe JAILLET [this message]
2024-05-12 9:25 ` kernel test robot
2024-05-13 2:14 ` kernel test robot
2024-05-11 16:32 ` [PATCH 2/3] lib80211: Constify struct lib80211_crypto_ops Christophe JAILLET
2024-05-11 16:32 ` [PATCH 3/3] staging: rtl8192e: " Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dd2eceb-4108-4071-b7b5-1fcac0a9d2ef@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=garyrookard@fastmail.org \
--cc=gregkh@linuxfoundation.org \
--cc=horms@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=philipp.g.hortmann@gmail.com \
--cc=straube.linux@gmail.com \
--cc=tdavies@darkphysics.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).