From: Christian Marangi <ansuelsmth@gmail.com>
To: Kalle Valo <kvalo@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, ath10k@lists.infradead.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
Sebastian Gottschall <s.gottschall@dd-wrt.com>,
Steve deRosier <derosier@cal-sierra.com>,
Stefan Lippers-Hollmann <s.l-h@gmx.de>
Subject: Re: [PATCH v14] ath10k: add LED and GPIO controlling support for various chipsets
Date: Fri, 10 May 2024 16:09:37 +0200 [thread overview]
Message-ID: <663e2aa4.050a0220.a4c56.1c5a@mx.google.com> (raw)
In-Reply-To: <87a5kxlqrn.fsf@kernel.org>
On Fri, May 10, 2024 at 04:50:52PM +0300, Kalle Valo wrote:
> Christian Marangi <ansuelsmth@gmail.com> writes:
>
> >>
> >> Sorry for the delay but finally I looked at this again. I decided to
> >> just remove the fixme and otherwise it looks good for me. Please check
> >> my changes:
> >>
> >> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=688130a66ed49f20ca0ce02c3987f6a474f7c93a
> >>
> >
> > All ok for me, Just I notice the ATH10K_LEDS is not exposed anymore? Is
> > that intended?
>
> Yes. It follows the same idea as other wireless drivers do, for example iwlwifi:
>
> config IWLWIFI_LEDS
> bool
> depends on LEDS_CLASS=y || LEDS_CLASS=MAC80211
> depends on IWLMVM || IWLDVM
> select LEDS_TRIGGERS
> select MAC80211_LEDS
> default y
>
> So what this patch now does:
>
> config ATH10K_LEDS
> bool
> depends on ATH10K
> depends on LEDS_CLASS=y || LEDS_CLASS=MAC80211
> default y
>
> The idea being that if LEDS_CLASS is enabled then ATH10K_LEDS is
> automatically enabled. But please let us know if something is wrong
> here.
>
Sure, was just asking some clarification about it. Not a problem for me
since we are using other pattern to handle this.
--
Ansuel
next prev parent reply other threads:[~2024-05-10 14:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-11 8:05 [PATCH v14] ath10k: add LED and GPIO controlling support for various chipsets Christian Marangi
2023-06-16 17:03 ` Kalle Valo
2023-06-16 11:35 ` Christian Marangi
2023-06-16 21:27 ` Christian Marangi
2023-08-21 10:46 ` Ansuel Smith
2024-05-09 4:50 ` Kalle Valo
2024-05-09 10:04 ` Christian Marangi
2024-05-10 8:53 ` Sebastian Gottschall
2024-05-10 13:50 ` Kalle Valo
2024-05-10 14:09 ` Christian Marangi [this message]
2024-05-09 16:37 ` Jeff Johnson
2024-05-09 16:48 ` Jeff Johnson
2024-05-10 13:52 ` Kalle Valo
2024-05-10 14:14 ` Christian Marangi
2024-05-10 14:54 ` Jeff Johnson
2024-05-11 14:17 ` Kalle Valo
2024-05-13 15:08 ` Jeff Johnson
2024-05-15 8:59 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=663e2aa4.050a0220.a4c56.1c5a@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=ath10k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=derosier@cal-sierra.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=s.gottschall@dd-wrt.com \
--cc=s.l-h@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).