Netdev Archive mirror
 help / color / mirror / Atom feed
From: Jeffery Miller <jefferymiller@google.com>
To: jtornosm@redhat.com
Cc: davem@davemloft.net, Eric Dumazet <edumazet@google.com>,
	inventor500@vivaldi.net,  jarkko.palviainen@gmail.com,
	kuba@kernel.org, linux-kernel@vger.kernel.org,
	 linux-usb@vger.kernel.org, netdev@vger.kernel.org,
	pabeni@redhat.com,  stable@vger.kernel.org,
	vadim.fedorenko@linux.dev
Subject: Re: [PATCH v2] net: usb: ax88179_178a: avoid writing the mac address before first reading
Date: Thu, 9 May 2024 16:09:16 -0500	[thread overview]
Message-ID: <CAAzPG9M+KNowPwkoYo+QftrN3u6zdN1cWq0XMvgS8UBEmWt+0g@mail.gmail.com> (raw)

Hello José,

I'm testing on the 6.6 kernel with a "0b95:1790 ASIX Electronics Corp.
AX88179 Gigabit Ethernet" device.
after applying commit 56f78615bcb1 ("net: usb: ax88179_178a: avoid
writing the mac address before first reading")
the network will no longer work after brining the device down.

After plugging in the device, it generally will work with ifconfig:
$ ifconfig eth0 <ip address>
However, if I then try bringing the devcie down and back up, it no longer works.
$ ifconfig eth0 down
$ ifconfig eth0  <ip address>
$ ethtool eth0 | grep detected
  Link detected: no

The link will continue to report as undetected.

If I revert 56f78615bcb1 the device will work after bringing it down
and back up.

If I build at commit d7a319889498 ("net: usb: ax88179_178a: avoid two
consecutive device resets") and its
parent d7a319889498^ these also work.

Is this something you have seen before with your test devices?

Regards,
Jeff

             reply	other threads:[~2024-05-09 21:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-09 21:09 Jeffery Miller [this message]
2024-05-10  6:08 ` [PATCH v2] net: usb: ax88179_178a: avoid writing the mac address before first reading Jose Ignacio Tornos Martinez
2024-05-23 22:27   ` Jeffery Miller
  -- strict thread matches above, loose matches on Subject: below --
2024-04-29 23:16 Isaac Ganoung
2024-04-30 15:27 ` Jakub Kicinski
2024-04-30 16:00   ` Jose Ignacio Tornos Martinez
2024-05-08  5:42     ` Yongqin Liu
2024-05-08  7:56       ` Jose Ignacio Tornos Martinez
2024-05-08 10:41         ` Yongqin Liu
2024-05-14  6:29           ` Yongqin Liu
2024-05-14  7:00             ` Jose Ignacio Tornos Martinez
2024-05-14  9:14               ` Yongqin Liu
2024-05-23  4:17                 ` Yongqin Liu
2024-04-17  8:55 Jose Ignacio Tornos Martinez
2024-04-18 17:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAzPG9M+KNowPwkoYo+QftrN3u6zdN1cWq0XMvgS8UBEmWt+0g@mail.gmail.com \
    --to=jefferymiller@google.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=inventor500@vivaldi.net \
    --cc=jarkko.palviainen@gmail.com \
    --cc=jtornosm@redhat.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).