From: Eric Dumazet <edumazet@google.com>
To: David Wei <dw@davidwei.uk>
Cc: Mohith Kumar Thummaluru <mohith.k.kumar.thummaluru@oracle.com>,
Yuan Fang <yf768672249@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [External] : [PATCH 1/2] tcp: fix get_tcp4_sock() output error info
Date: Thu, 9 May 2024 21:46:54 +0200 [thread overview]
Message-ID: <CANn89iLfj3fPmCC+3-ZfAAvCMVh=E3j3xTAu6At2wdK2MK0-=A@mail.gmail.com> (raw)
In-Reply-To: <9aafe0de-7e46-4255-915e-2cf2969377d0@davidwei.uk>
On Thu, May 9, 2024 at 8:09 PM David Wei <dw@davidwei.uk> wrote:
>
> On 2024-05-09 10:29, Mohith Kumar Thummaluru wrote:
> > Good catch! Thanks for this fix.
>
> If this is a fix, can you please add a Fixes tag? And in general some
> surrounding context in a cover letter? Thanks.
I do not think it is a fix, and I am not sure we want this patch anyway.
/proc interface is legacy, we do not change it.
Please use TCP_INFO or inet_diag, because
commit 5ee3afba88f5 "[TCP]: Return useful listenq info in tcp_info and
INET_DIAG_INFO."
took care of this in 2007.
Already in 2007 we were considering /proc/net/tcp as a legacy.
prev parent reply other threads:[~2024-05-09 19:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 4:43 [PATCH 1/2] tcp: fix get_tcp4_sock() output error info Yuan Fang
2024-05-09 4:43 ` [PATCH 2/2] tcp/ipv6: fix get_tcp6_sock() " Yuan Fang
2024-05-09 17:31 ` [External] : " Mohith Kumar Thummaluru
2024-05-09 17:29 ` [External] : [PATCH 1/2] tcp: fix get_tcp4_sock() " Mohith Kumar Thummaluru
2024-05-09 18:09 ` David Wei
2024-05-09 19:46 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89iLfj3fPmCC+3-ZfAAvCMVh=E3j3xTAu6At2wdK2MK0-=A@mail.gmail.com' \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mohith.k.kumar.thummaluru@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=yf768672249@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).