From: Hengqi Chen <hengqi.chen@gmail.com>
To: Qiang Wang <wangqiang.wq.frank@bytedance.com>,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, zhouchengming@bytedance.com,
songmuchun@bytedance.com, duanxiongchun@bytedance.com,
shekairui@bytedance.com
Subject: Re: [PATCH 1/2] libbpf: Use probe_name for legacy kprobe
Date: Mon, 27 Dec 2021 19:47:33 +0800 [thread overview]
Message-ID: <aebfbe2e-598e-ef57-2412-605aa15d29e4@gmail.com> (raw)
In-Reply-To: <20211225083242.38498-1-wangqiang.wq.frank@bytedance.com>
On 2021/12/25 4:32 PM, Qiang Wang wrote:
> Fix a bug in commit 46ed5fc33db9, which wrongly used the
> func_name instead of probe_name to register legacy kprobe.
>
> Fixes: 46ed5fc33db9 ("libbpf: Refactor and simplify legacy kprobe code")
> Co-developed-by: Chengming Zhou <zhouchengming@bytedance.com>
> Signed-off-by: Qiang Wang <wangqiang.wq.frank@bytedance.com>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> ---
> tools/lib/bpf/libbpf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 7c74342bb668..b7d6c951fa09 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -9735,7 +9735,7 @@ bpf_program__attach_kprobe_opts(const struct bpf_program *prog,
> gen_kprobe_legacy_event_name(probe_name, sizeof(probe_name),
> func_name, offset);
>
> - legacy_probe = strdup(func_name);
> + legacy_probe = strdup(probe_name);
> if (!legacy_probe)
> return libbpf_err_ptr(-ENOMEM);
>
Reviewed-by: Hengqi Chen <hengqi.chen@gmail.com>
Tested-by: Hengqi Chen <hengqi.chen@gmail.com>
prev parent reply other threads:[~2021-12-27 11:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-25 8:32 [PATCH 1/2] libbpf: Use probe_name for legacy kprobe Qiang Wang
2021-12-25 8:32 ` [PATCH 2/2] libbpf: Support repeated legacy kprobes on same function Qiang Wang
2021-12-27 11:39 ` Hengqi Chen
2021-12-27 12:08 ` kernel test robot
2021-12-27 11:47 ` Hengqi Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aebfbe2e-598e-ef57-2412-605aa15d29e4@gmail.com \
--to=hengqi.chen@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=duanxiongchun@bytedance.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shekairui@bytedance.com \
--cc=songliubraving@fb.com \
--cc=songmuchun@bytedance.com \
--cc=wangqiang.wq.frank@bytedance.com \
--cc=yhs@fb.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).