From: Andrew Lunn <andrew@lunn.ch>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [net-next,v4] net: ethernet: rtsn: Add support for Renesas Ethernet-TSN
Date: Fri, 10 May 2024 14:38:56 +0200 [thread overview]
Message-ID: <c12d4a97-2dda-4fd9-b58c-d923681230ea@lunn.ch> (raw)
In-Reply-To: <20240509220720.GN1385281@ragnatech.se>
On Fri, May 10, 2024 at 12:07:20AM +0200, Niklas Söderlund wrote:
> On 2024-05-09 23:12:43 +0200, Andrew Lunn wrote:
> > > + /* Link verification */
> > > + rtsn_modify(priv, MLVC, MLVC_PLV, MLVC_PLV);
> > > + ret = rtsn_reg_wait(priv, MLVC, MLVC_PLV, 0);
> > > + if (ret)
> > > + return ret;
> >
> > What is link verification?
>
> It's a part of the TSN capabilities, it verifies if the link is capable
> of preemption. AFIK it's described in IEEE802.1Qbu Frame Preemption
> Protocol.
>
> For this device in particular, this register writes enables the Link
> Verification process. Which in turn allows the IP to transmitting Verify
> frames, which if replied too with a valid Reply frame by the other node
> lets the IP know the link supports preemption.
Thanks for the explanation.
I've seen some hardware which polls the PHY for link status. Such
hardware assumes it has exclusive access to the PHY, which is
incorrect in Linux. hwmon might of swapped the PHY to a different page
in order to read a temperature sensor etc. If the hardware were to
poll at that point, rather than getting the BMSR it reads some other
random register...
I just wanted to check it was not something like this.
Andrew
prev parent reply other threads:[~2024-05-10 12:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 9:52 [net-next,v4] net: ethernet: rtsn: Add support for Renesas Ethernet-TSN Niklas Söderlund
2024-05-09 20:25 ` Andrew Lunn
2024-05-09 21:03 ` Niklas Söderlund
2024-05-09 21:12 ` Andrew Lunn
2024-05-09 22:07 ` Niklas Söderlund
2024-05-10 12:38 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c12d4a97-2dda-4fd9-b58c-d923681230ea@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).