From: Andrew Lunn <andrew@lunn.ch>
To: Thorsten Blum <thorsten.blum@toblux.com>
Cc: arnd@arndb.de, davem@davemloft.net, edumazet@google.com,
gerg@linux-m68k.org, glaubitz@physik.fu-berlin.de,
kuba@kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, nico@fluxnic.net, pabeni@redhat.com
Subject: Re: [PATCH v3] net: smc91x: Fix m68k kernel compilation for ColdFire CPU
Date: Fri, 10 May 2024 18:21:51 +0200 [thread overview]
Message-ID: <d9b4b726-7c31-4fbb-936e-e4ee505a66a1@lunn.ch> (raw)
In-Reply-To: <20240510113054.186648-2-thorsten.blum@toblux.com>
On Fri, May 10, 2024 at 01:30:55PM +0200, Thorsten Blum wrote:
> Compiling the m68k kernel with support for the ColdFire CPU family fails
> with the following error:
>
> In file included from drivers/net/ethernet/smsc/smc91x.c:80:
> drivers/net/ethernet/smsc/smc91x.c: In function ‘smc_reset’:
> drivers/net/ethernet/smsc/smc91x.h:160:40: error: implicit declaration of function ‘_swapw’; did you mean ‘swap’? [-Werror=implicit-function-declaration]
> 160 | #define SMC_outw(lp, v, a, r) writew(_swapw(v), (a) + (r))
> | ^~~~~~
> drivers/net/ethernet/smsc/smc91x.h:904:25: note: in expansion of macro ‘SMC_outw’
> 904 | SMC_outw(lp, x, ioaddr, BANK_SELECT); \
> | ^~~~~~~~
> drivers/net/ethernet/smsc/smc91x.c:250:9: note: in expansion of macro ‘SMC_SELECT_BANK’
> 250 | SMC_SELECT_BANK(lp, 2);
> | ^~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
> The function _swapw() was removed in commit d97cf70af097 ("m68k: use
> asm-generic/io.h for non-MMU io access functions"), but is still used in
> drivers/net/ethernet/smsc/smc91x.h.
>
> Use ioread16be() and iowrite16be() to resolve the error.
>
> Fixes: d97cf70af097 ("m68k: use asm-generic/io.h for non-MMU io access functions")
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
> ---
> Changes in v2:
> - Use ioread16be() and iowrite16be() directly instead of re-adding
> _swapw() as suggested by Arnd Bergmann and Andrew Lunn
>
> Changes in v3:
> - Add Fixes: tag
This is for net.
Cc: <stable@vger.kernel.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2024-05-10 16:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 12:17 [PATCH] net: smc91x: Fix m68k kernel compilation for ColdFire CPU Thorsten Blum
2024-05-09 20:36 ` Andrew Lunn
2024-05-09 21:26 ` Thorsten Blum
2024-05-09 20:47 ` Arnd Bergmann
2024-05-09 21:37 ` [PATCH v2] " Thorsten Blum
2024-05-10 11:30 ` [PATCH v3] " Thorsten Blum
2024-05-10 16:21 ` Andrew Lunn [this message]
2024-05-13 22:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9b4b726-7c31-4fbb-936e-e4ee505a66a1@lunn.ch \
--to=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gerg@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=pabeni@redhat.com \
--cc=thorsten.blum@toblux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).