From: "Christian König" <christian.koenig@amd.com>
To: Dave Airlie <airlied@gmail.com>, dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org, Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH] nouveau: reset the bo resource bus info after an eviction
Date: Mon, 11 Mar 2024 14:51:40 +0100 [thread overview]
Message-ID: <00ebc200-747b-4b61-a81f-0db13593ebdf@amd.com> (raw)
In-Reply-To: <20240311072037.287905-1-airlied@gmail.com>
Am 11.03.24 um 08:20 schrieb Dave Airlie:
> From: Dave Airlie <airlied@redhat.com>
>
> Later attempts to refault the bo won't happen and the whole
> GPU does to lunch. I think Christian's refactoring of this
> code out to the driver broke this not very well tested path.
Yeah that is certainly possible.
>
> Fixes: 141b15e59175 ("drm/nouveau: move io_reserve_lru handling into the driver v5")
> Cc: Christian König <christian.koenig@amd.com>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
Acked-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/nouveau/nouveau_bo.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
> index c6c544d7c911..a4e8f625fce6 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
> @@ -1271,6 +1271,8 @@ nouveau_ttm_io_mem_reserve(struct ttm_device *bdev, struct ttm_resource *reg)
> drm_vma_node_unmap(&nvbo->bo.base.vma_node,
> bdev->dev_mapping);
> nouveau_ttm_io_mem_free_locked(drm, nvbo->bo.resource);
> + nvbo->bo.resource->bus.offset = 0;
> + nvbo->bo.resource->bus.addr = NULL;
> goto retry;
> }
>
prev parent reply other threads:[~2024-03-11 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 7:20 [PATCH] nouveau: reset the bo resource bus info after an eviction Dave Airlie
2024-03-11 13:02 ` Timur Tabi
2024-03-11 13:51 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00ebc200-747b-4b61-a81f-0db13593ebdf@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).