From: Danilo Krummrich <dakr@redhat.com>
To: Timur Tabi <ttabi@nvidia.com>,
"airlied@redhat.com" <airlied@redhat.com>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
"lyude@redhat.com" <lyude@redhat.com>
Subject: Re: [PATCH] [v4] nouveau: add command-line GSP-RM registry support
Date: Thu, 21 Mar 2024 17:00:29 +0100 [thread overview]
Message-ID: <250692ec-db4a-4e2a-b473-31b0a88035dd@redhat.com> (raw)
In-Reply-To: <6b4a8006471041a96d41f10010c7b192a69ab620.camel@nvidia.com>
On 3/21/24 00:27, Timur Tabi wrote:
> On Mon, 2024-03-04 at 13:57 +0100, Danilo Krummrich wrote:
>>
>> Thanks for sending a new version of the patch.
>>
>> Please make sure that for future patches you include a changelog, such that
>> it's easier for reviewers to keep track of what has changed.
>
> Will do.
>
>>> .../gpu/drm/nouveau/include/nvkm/subdev/gsp.h | 6 +
>>> .../gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 375 ++++++++++++++++--
>>> 2 files changed, 357 insertions(+), 24 deletions(-)
>>
>> There are a few issues pointed out by checkpatch.pl, that I think should be fixed.
>
> checkpatch showed me nothing:
>
> $ scripts/checkpatch.pl 0001-v4-nouveau-add-command-line-GSP-RM-registry-
> support.patch
> total: 0 errors, 0 warnings, 420 lines checked
>
> 0001-v4-nouveau-add-command-line-GSP-RM-registry-support.patch has no
> obvious style problems and is ready for submission.
I used '--strict'. I think we should get the kmalloc(), the blank lines and the
alignment ones fixed.
- Danilo
prev parent reply other threads:[~2024-03-21 16:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 21:58 [PATCH] [v4] nouveau: add command-line GSP-RM registry support Timur Tabi
2024-02-20 22:02 ` Timur Tabi
2024-03-04 12:57 ` Danilo Krummrich
2024-03-20 23:27 ` Timur Tabi
2024-03-21 16:00 ` Danilo Krummrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=250692ec-db4a-4e2a-b473-31b0a88035dd@redhat.com \
--to=dakr@redhat.com \
--cc=airlied@redhat.com \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).