From: Danilo Krummrich <me@dakr.org>
To: Dave Airlie <airlied@gmail.com>
Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] nouveau/gsp: use correct size for registry rpc.
Date: Mon, 5 Feb 2024 17:40:44 +0100 [thread overview]
Message-ID: <46dc2e91-261d-4de7-bae0-3bdfc50c1975@dakr.org> (raw)
In-Reply-To: <20240130032643.2498315-1-airlied@gmail.com>
On 1/30/24 04:26, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> Timur pointed this out before, and it just slipped my mind,
> but this might help some things work better, around pcie power
> management.
>
> Fixes: 8d55b0a940bb ("nouveau/gsp: add some basic registry entries.")
> Signed-off-by: Dave Airlie <airlied@redhat.com>
Added stable CC for v6.7 and applied it to drm-misc-fixes.
> ---
> drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c
> index 9ee58e2a0eb2..5e1fa176aac4 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c
> @@ -1078,7 +1078,6 @@ r535_gsp_rpc_set_registry(struct nvkm_gsp *gsp)
> if (IS_ERR(rpc))
> return PTR_ERR(rpc);
>
> - rpc->size = sizeof(*rpc);
> rpc->numEntries = NV_GSP_REG_NUM_ENTRIES;
>
> str_offset = offsetof(typeof(*rpc), entries[NV_GSP_REG_NUM_ENTRIES]);
> @@ -1094,6 +1093,7 @@ r535_gsp_rpc_set_registry(struct nvkm_gsp *gsp)
> strings += name_len;
> str_offset += name_len;
> }
> + rpc->size = str_offset;
>
> return nvkm_gsp_rpc_wr(gsp, rpc, false);
> }
prev parent reply other threads:[~2024-02-05 16:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 3:26 [PATCH] nouveau/gsp: use correct size for registry rpc Dave Airlie
2024-02-05 16:40 ` Danilo Krummrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46dc2e91-261d-4de7-bae0-3bdfc50c1975@dakr.org \
--to=me@dakr.org \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).