From: "Michel Dänzer" <michel.daenzer@mailbox.org>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
zack.rusin@broadcom.com, lyude@redhat.com, kherbst@redhat.com,
jani.nikula@linux.intel.com, nouveau@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: Rework TTMs busy handling
Date: Wed, 10 Jan 2024 10:03:24 +0100 [thread overview]
Message-ID: <9833fda7-c80a-4132-904e-3cf7131e72d4@mailbox.org> (raw)
In-Reply-To: <6eff58f4-7956-47cf-9a66-92456d5577d3@gmail.com>
On 2024-01-09 09:34, Christian König wrote:
> Am 09.01.24 um 09:14 schrieb Thomas Hellström:
>> On Tue, 2024-01-09 at 08:47 +0100, Christian König wrote:
>>>
>>> I'm trying to make this functionality a bit more useful for years now
>>> since we multiple reports that behavior of drivers can be suboptimal
>>> when multiple placements be given.
>>>
>>> So basically instead of hacking around the TTM behavior in the driver
>>> once more I've gone ahead and changed the idle/busy placement list
>>> into idle/busy placement flags. This not only saves a bunch of code,
>>> but also allows setting some placements as fallback which are used if
>>> allocating from the preferred ones didn't worked.
>>
>> I also have some doubts about the naming "idle" vs "busy", since an
>> elaborate eviction mechanism would probably at some point want to check
>> for gpu idle vs gpu busy, and this might create some confusion moving
>> forward for people confusing busy as in memory overcommit with busy as
>> in gpu activity.
>>
>> I can't immediately think of something better, though.
>
> Yeah, I was wondering about that as well. Especially since I wanted to add some more flags in the future when for example a bandwidth quota how much memory can be moved in/out is exceeded.
>
> Something like phase1, phase2, phase3 etc..., but that's also not very descriptive either.
Maybe something like "desired" vs "fallback"?
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and Xwayland developer
next prev parent reply other threads:[~2024-01-10 9:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 7:47 Rework TTMs busy handling Christian König
2024-01-09 7:47 ` [PATCH 1/5] drm/vmwgfx: remove vmw_vram_gmr_placement Christian König
2024-01-09 7:47 ` [PATCH 2/5] drm/ttm: return ENOSPC from ttm_bo_mem_space Christian König
2024-01-09 9:17 ` Thomas Hellström
2024-01-09 7:47 ` [PATCH 3/5] drm/ttm: replace busy placement with flags v5 Christian König
2024-01-09 17:29 ` Zack Rusin
2024-01-09 7:47 ` [PATCH 4/5] drm/ttm: improve idle/busy handling v2 Christian König
2024-01-09 7:47 ` [PATCH 5/5] drm/amdgpu: use GTT only as fallback for VRAM|GTT Christian König
2024-01-09 8:14 ` Rework TTMs busy handling Thomas Hellström
2024-01-09 8:34 ` Christian König
2024-01-10 9:03 ` Michel Dänzer [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-01-26 14:09 Christian König
2024-01-12 12:51 Christian König
2024-01-16 9:57 ` Christian König
2024-01-17 3:13 ` Zack Rusin
2024-01-04 15:05 Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9833fda7-c80a-4132-904e-3cf7131e72d4@mailbox.org \
--to=michel.daenzer@mailbox.org \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=kherbst@redhat.com \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=thomas.hellstrom@linux.intel.com \
--cc=zack.rusin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).