From: Dave Airlie <airlied@gmail.com>
To: Timur Tabi <ttabi@nvidia.com>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>
Subject: Re: [PATCH] nouveau: fix devinit paths to only handle display on GSP.
Date: Tue, 9 Apr 2024 13:12:02 +1000 [thread overview]
Message-ID: <CAPM=9twzNqHeLKXaQL8RtSWD-Z1zvsyrqCgNhsd35cVFB38qFQ@mail.gmail.com> (raw)
In-Reply-To: <b7f005a5bc22cff08509ce75f8eee7925047e8ae.camel@nvidia.com>
On Mon, 8 Apr 2024 at 23:05, Timur Tabi <ttabi@nvidia.com> wrote:
>
> On Mon, 2024-04-08 at 16:42 +1000, Dave Airlie wrote:
> > This reverts:
> > nouveau/gsp: don't check devinit disable on GSP.
> > and applies a further fix.
> >
> > It turns out the open gpu driver, checks this register, but only for
> > display.
> >
> > Match that behaviour and only disable displays on turings.
>
> Why only on Turings?
The only is for disabling displays, not for the turings. The ampere
devinit path only handle displays, it never tries to disable other
engines so should be fine.
Dave.
prev parent reply other threads:[~2024-04-09 3:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 6:42 [PATCH] nouveau: fix devinit paths to only handle display on GSP Dave Airlie
2024-04-08 12:02 ` Danilo Krummrich
2024-04-08 13:04 ` Timur Tabi
2024-04-09 3:12 ` Dave Airlie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPM=9twzNqHeLKXaQL8RtSWD-Z1zvsyrqCgNhsd35cVFB38qFQ@mail.gmail.com' \
--to=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).