Nouveau Archive mirror
 help / color / mirror / Atom feed
From: Lyude Paul <lyude@redhat.com>
To: Borislav Petkov <bp@alien8.de>,
	Paul Dufresne <dufresnep@zoho.com>,
	 Danilo Krummrich <me@dakr.org>
Cc: Daniel Vetter <daniel@ffwll.ch>,
	nouveau <nouveau@lists.freedesktop.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Ben Skeggs <bskeggs@redhat.com>
Subject: Re: nouveau 0000:01:00.0: drm_WARN_ON(!found_head)
Date: Wed, 13 Dec 2023 19:29:40 -0500	[thread overview]
Message-ID: <f1a33f9001bc642fd71280559ec0f612936db2a8.camel@redhat.com> (raw)
In-Reply-To: <f10791773520f85857749c080af999821dd41a0d.camel@redhat.com>

Nevermind - I don't think I'll need the logs, I stared at the code for long
enough and I think I realized what's happening.

I will have a patch for you to test in just a moment, just waiting for it to
compile so I can verify nothing else breaks

On Wed, 2023-12-13 at 18:48 -0500, Lyude Paul wrote:
> Hopefully you're still on at this point - if you are, could you try starting
> the machine up with the following kernel module arguments passed to nouveau?
> 
> debug=disp=trace
> 
> Then see if you can find any lines that mention INHERIT? I have a feeling I'm
> just going to have to add a workaround for the time being, but I'd really love
> to know how we're managing to get that far on a hardware generation we never
> implemented that nvkm ioctl for…
> 
> On Wed, 2023-12-13 at 18:37 -0500, Lyude Paul wrote:
> > agh - thank you for repeatedly poking on this, I've been busy enough with GSP
> > work I totally missed this. Yes - I'm quite surprised that this is blowing up,
> > but considering that looks to be a GT218 I guess display state readback must
> > just work a bit differently there since that's really early on into the NV50
> > days.
> > 
> > The reason that was a drm_WARN_ON() was because it indicates that we're not
> > reading back OR -> head assignments properly. But, I'm confused how we're even
> > getting that far on a non-GSP platform. I'm going to dig into this now, but if
> > I don't figure out a good fix by the end of the day I'll just send a patch to
> > silent the warning.
> > 
> > Thanks again for bugging me about this!
> > 
> > On Wed, 2023-12-13 at 13:49 +0100, Borislav Petkov wrote:
> > > On Wed, Dec 13, 2023 at 12:39:36PM +0100, Borislav Petkov wrote:
> > > > We're getting close to releasing so I guess we either debug this or shut
> > > > up the WARN.
> > > 
> > > Not only that - panic_on_warn turns this into an explosion so you don't
> > > want that in a released kernel.
> > > 
> > 
> 

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat


      reply	other threads:[~2023-12-14  0:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-11 12:03 [Nouveau] nouveau 0000:01:00.0: drm_WARN_ON(!found_head) Borislav Petkov
2023-12-12 22:40 ` Borislav Petkov
     [not found]   ` <18c613ec092.ae61cf7d6029.4389632938517239705@zoho.com>
2023-12-13 11:39     ` Borislav Petkov
2023-12-13 12:49       ` Borislav Petkov
2023-12-13 23:37         ` Lyude Paul
2023-12-13 23:48           ` Lyude Paul
2023-12-14  0:29             ` Lyude Paul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1a33f9001bc642fd71280559ec0f612936db2a8.camel@redhat.com \
    --to=lyude@redhat.com \
    --cc=bp@alien8.de \
    --cc=bskeggs@redhat.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dufresnep@zoho.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@dakr.org \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).