ntb.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	linux-ntb@googlegroups.com, Jon Mason <jdmason@kudzu.us>
Subject: [ntb:ntb-next 4/19] drivers/ntb/hw/intel/ntb_hw_gen4.c:484:5: warning: no previous prototype for function 'intel_ntb4_mw_get_align'
Date: Sat, 6 Jun 2020 08:44:10 +0800	[thread overview]
Message-ID: <202006060807.fI92UVYB%lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3186 bytes --]

tree:   https://github.com/jonmason/ntb ntb-next
head:   e24ffef7f16796eb10533a1ad6af5bdc5be3df83
commit: 303f8eff679681b62e5ef10d81f697d0a15eb850 [4/19] ntb: intel: add hw workaround for NTB BAR alignment
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 6dd738e2f0609f7d3313b574a1d471263d2d3ba1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        git checkout 303f8eff679681b62e5ef10d81f697d0a15eb850
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

drivers/ntb/hw/intel/ntb_hw_gen4.c:459:5: warning: no previous prototype for function 'intel_ntb4_link_disable' [-Wmissing-prototypes]
int intel_ntb4_link_disable(struct ntb_dev *ntb)
^
drivers/ntb/hw/intel/ntb_hw_gen4.c:459:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int intel_ntb4_link_disable(struct ntb_dev *ntb)
^
static
>> drivers/ntb/hw/intel/ntb_hw_gen4.c:484:5: warning: no previous prototype for function 'intel_ntb4_mw_get_align' [-Wmissing-prototypes]
int intel_ntb4_mw_get_align(struct ntb_dev *ntb, int pidx, int idx,
^
drivers/ntb/hw/intel/ntb_hw_gen4.c:484:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int intel_ntb4_mw_get_align(struct ntb_dev *ntb, int pidx, int idx,
^
static
2 warnings generated.

vim +/intel_ntb4_mw_get_align +484 drivers/ntb/hw/intel/ntb_hw_gen4.c

   483	
 > 484	int intel_ntb4_mw_get_align(struct ntb_dev *ntb, int pidx, int idx,
   485				    resource_size_t *addr_align,
   486				    resource_size_t *size_align,
   487				    resource_size_t *size_max)
   488	{
   489		struct intel_ntb_dev *ndev = ntb_ndev(ntb);
   490		resource_size_t bar_size, mw_size;
   491		int bar;
   492	
   493		if (pidx != NTB_DEF_PEER_IDX)
   494			return -EINVAL;
   495	
   496		if (idx >= ndev->b2b_idx && !ndev->b2b_off)
   497			idx += 1;
   498	
   499		bar = ndev_mw_to_bar(ndev, idx);
   500		if (bar < 0)
   501			return bar;
   502	
   503		bar_size = pci_resource_len(ndev->ntb.pdev, bar);
   504	
   505		if (idx == ndev->b2b_idx)
   506			mw_size = bar_size - ndev->b2b_off;
   507		else
   508			mw_size = bar_size;
   509	
   510		if (addr_align) {
   511			if (ndev->hwerr_flags & NTB_HWERR_BAR_ALIGN)
   512				*addr_align = pci_resource_len(ndev->ntb.pdev, bar);
   513			else
   514				*addr_align = PAGE_SIZE;
   515		}
   516	
   517		if (size_align)
   518			*size_align = 1;
   519	
   520		if (size_max)
   521			*size_max = mw_size;
   522	
   523		return 0;
   524	}
   525	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 73426 bytes --]

                 reply	other threads:[~2020-06-06  0:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202006060807.fI92UVYB%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=dave.jiang@intel.com \
    --cc=jdmason@kudzu.us \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-ntb@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).