From: Kang Chen <void0red@gmail.com>
To: jdmason@kudzu.us
Cc: dave.jiang@intel.com, allenbh@gmail.com, ntb@lists.linux.dev,
linux-kernel@vger.kernel.org, Kang Chen <void0red@gmail.com>
Subject: [PATCH] ntb_tool: check null return of devm_kcalloc in tool_init_mws
Date: Sun, 26 Feb 2023 13:57:43 +0800 [thread overview]
Message-ID: <20230226055743.2522819-1-void0red@gmail.com> (raw)
devm_kcalloc may fails, tc->peers[pidx].outmws might be null
and will cause null pointer dereference later.
Signed-off-by: Kang Chen <void0red@gmail.com>
---
drivers/ntb/test/ntb_tool.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
index 5ee0afa62..eeeb4b1c9 100644
--- a/drivers/ntb/test/ntb_tool.c
+++ b/drivers/ntb/test/ntb_tool.c
@@ -998,6 +998,8 @@ static int tool_init_mws(struct tool_ctx *tc)
tc->peers[pidx].outmws =
devm_kcalloc(&tc->ntb->dev, tc->peers[pidx].outmw_cnt,
sizeof(*tc->peers[pidx].outmws), GFP_KERNEL);
+ if (tc->peers[pidx].outmws == NULL)
+ return -ENOMEM;
for (widx = 0; widx < tc->peers[pidx].outmw_cnt; widx++) {
tc->peers[pidx].outmws[widx].pidx = pidx;
--
2.34.1
next reply other threads:[~2023-02-26 5:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-26 5:57 Kang Chen [this message]
2023-02-27 15:58 ` [PATCH] ntb_tool: check null return of devm_kcalloc in tool_init_mws Dave Jiang
2023-03-06 15:28 ` Serge Semin
2023-03-07 12:20 ` [PATCH v2] " Kang Chen
2023-03-07 16:05 ` Dave Jiang
2023-03-07 16:26 ` Kang Chen
2023-03-07 16:33 ` [PATCH v3] " void0red
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230226055743.2522819-1-void0red@gmail.com \
--to=void0red@gmail.com \
--cc=allenbh@gmail.com \
--cc=dave.jiang@intel.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=ntb@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).