From: Dave Jiang <dave.jiang@intel.com>
To: Allen Hubbe <allenbh@gmail.com>
Cc: Jon Mason <jdmason@kudzu.us>, ntb@lists.linux.dev
Subject: Re: [PATCH v2] ntb: intel: add GNR support for Intel PCIe gen5 NTB
Date: Tue, 2 Aug 2022 14:01:55 -0700 [thread overview]
Message-ID: <781b9161-a6cc-a8cc-af20-a4eebcdbca6e@intel.com> (raw)
In-Reply-To: <CAJ80savTwSK49YPdLDTgXsUqOF3+P5vcU6_sjc4Kaz_3_dF0ng@mail.gmail.com>
On 8/2/2022 12:52 PM, Allen Hubbe wrote:
> On Mon, Aug 1, 2022 at 4:53 PM Dave Jiang <dave.jiang@intel.com> wrote:
>> @@ -2047,6 +2047,8 @@ static const struct pci_device_id intel_ntb_pci_tbl[] = {
>>
>> /* GEN4 */
>> {PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_NTB_B2B_ICX)},
>> + /* SPR has same dev id has ICX but different revision id */
>> + {PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_NTB_B2B_GNR)},
> comment says SPR but the id is GNR ?
The comment is in place of the SPR ID because it's the same as ICX. It's
not the comment for the following GNR id line. The only difference
between ICX and SPR is dev revision ID.
>
>> @@ -70,6 +70,8 @@
>> #define PCI_DEVICE_ID_INTEL_NTB_SS_BDX 0x6F0F
>> #define PCI_DEVICE_ID_INTEL_NTB_B2B_SKX 0x201C
>> #define PCI_DEVICE_ID_INTEL_NTB_B2B_ICX 0x347e
>> +#define PCI_DEVICE_ID_INTEL_NTB_B2B_SPR 0x347e
> PCI_DEVICE_ID_INTEL_NTB_B2B_SPR is added here, but not used?
>
> pdev_is_SPR(pdev) already exists.
> Should that use PCI_DEVICE_ID_INTEL_NTB_B2B_SPR?
Probably, but not for this patch.
>
>> @@ -225,7 +227,14 @@ static inline int pdev_is_gen4(struct pci_dev *pdev)
>> {
>> if (pdev->device == PCI_DEVICE_ID_INTEL_NTB_B2B_ICX)
>> return 1;
>> + return 0;
> return pdev->device == PCI_DEVICE_ID_INTEL_NTB_B2B_ICX;
Not a change for this patch. but I'll fix the gen5 function.
>
>> +}
>>
>> +static inline int pdev_is_gen5(struct pci_dev *pdev)
>> +{
>> + if (pdev->device == PCI_DEVICE_ID_INTEL_NTB_B2B_GNR)
>> + return 1;
>> return 0;
> return pdev->device == PCI_DEVICE_ID_INTEL_NTB_B2B_GNR;
>
prev parent reply other threads:[~2022-08-02 21:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 20:44 [PATCH v2] ntb: intel: add GNR support for Intel PCIe gen5 NTB Dave Jiang
2022-08-02 19:52 ` Allen Hubbe
2022-08-02 21:01 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=781b9161-a6cc-a8cc-af20-a4eebcdbca6e@intel.com \
--to=dave.jiang@intel.com \
--cc=allenbh@gmail.com \
--cc=jdmason@kudzu.us \
--cc=ntb@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).