From: Dave Jiang <dave.jiang@intel.com>
To: Yinhao Hu <dddddd@hust.edu.cn>, Jon Mason <jdmason@kudzu.us>,
Allen Hubbe <allenbh@gmail.com>
Cc: hust-os-kernel-patches@googlegroups.com,
Dongliang Mu <dzm91@hust.edu.cn>,
ntb@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ntb: hw: intel: remove return value check of `ndev_init_debugfs`
Date: Mon, 24 Apr 2023 08:33:46 -0700 [thread overview]
Message-ID: <9479d2e4-8147-aee2-3a2b-1cd06a4ad4e0@intel.com> (raw)
In-Reply-To: <20230422155634.483023-1-dddddd@hust.edu.cn>
On 4/22/23 8:56 AM, Yinhao Hu wrote:
> Smatch complains that:
> ndev_init_debugfs() warn: 'ndev->debugfs_dir' is an error pointer or valid
>
> Debugfs checks are generally not supposed to be checked for errors
> and it is not necessary here.
Can you please provide source on where this is true?
>
> Just delete the dead code.
>
> Signed-off-by: Yinhao Hu <dddddd@hust.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
> ---
> The issue is found by static analysis and remains untested.
> ---
> drivers/ntb/hw/intel/ntb_hw_gen1.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/ntb/hw/intel/ntb_hw_gen1.c b/drivers/ntb/hw/intel/ntb_hw_gen1.c
> index 9ab836d0d4f1..9b0b2c43f1bb 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_gen1.c
> +++ b/drivers/ntb/hw/intel/ntb_hw_gen1.c
> @@ -778,13 +778,10 @@ static void ndev_init_debugfs(struct intel_ntb_dev *ndev)
> ndev->debugfs_dir =
> debugfs_create_dir(pci_name(ndev->ntb.pdev),
> debugfs_dir);
> - if (!ndev->debugfs_dir)
> - ndev->debugfs_info = NULL;
> - else
> - ndev->debugfs_info =
> - debugfs_create_file("info", S_IRUSR,
> - ndev->debugfs_dir, ndev,
> - &intel_ntb_debugfs_info);
> + ndev->debugfs_info =
> + debugfs_create_file("info", S_IRUSR,
> + ndev->debugfs_dir, ndev,
> + &intel_ntb_debugfs_info);
> }
> }
>
prev parent reply other threads:[~2023-04-24 15:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-22 15:56 [PATCH] ntb: hw: intel: remove return value check of `ndev_init_debugfs` Yinhao Hu
2023-04-24 15:33 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9479d2e4-8147-aee2-3a2b-1cd06a4ad4e0@intel.com \
--to=dave.jiang@intel.com \
--cc=allenbh@gmail.com \
--cc=dddddd@hust.edu.cn \
--cc=dzm91@hust.edu.cn \
--cc=hust-os-kernel-patches@googlegroups.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=ntb@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).