From: Kishon Vijay Abraham I <kishon@ti.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Jonathan Corbet <corbet@lwn.net>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Arnd Bergmann <arnd@arndb.de>, Jon Mason <jdmason@kudzu.us>,
Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <allenbh@gmail.com>, Tom Joseph <tjoseph@cadence.com>,
Rob Herring <robh@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pci@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com
Subject: Re: [PATCH v2 01/14] Documentation: PCI: Add specification for the *PCI NTB* function device
Date: Fri, 12 Jun 2020 11:00:53 +0530 [thread overview]
Message-ID: <c8a5d63a-7026-2b40-4b26-5f4e481f7df4@ti.com> (raw)
In-Reply-To: <20200611151301.GB8681@bombadil.infradead.org>
Hi Matthew,
On 6/11/2020 8:43 PM, Matthew Wilcox wrote:
> On Thu, Jun 11, 2020 at 06:35:12PM +0530, Kishon Vijay Abraham I wrote:
>> +++ b/Documentation/PCI/endpoint/pci-ntb-function.rst
>> @@ -0,0 +1,344 @@
>> +.. SPDX-License-Identifier: GPL-2.0
>> +
>> +=================
>> +PCI NTB Function
>> +=================
>> +
>> +:Author: Kishon Vijay Abraham I <kishon@ti.com>
>> +
>> +PCI NTB Function allows two different systems (or hosts) to communicate
>> +with each other by configurig the endpoint instances in such a way that
>> +transactions from one system is routed to the other system.
>
> At no point in this document do you expand "NTB" into Non-Transparent
> Bridge. The above paragraph probably also needs to say something like "By
> making each host appear as a device to the other host". Although maybe
> that's not entirely accurate? It's been a few years since I last played
> with NTBs.
>
> So how about the following opening paragraph:
>
> PCI Non Transparent Bridges (NTB) allow two host systems to communicate
> with each other by exposing each host as a device to the other host.
> NTBs typically support the ability to generate interrupts on the remote
> machine, expose memory ranges as BARs and perform DMA. They also support
> scratchpads which are areas of memory within the NTB that are accessible
> from both machines.
>
> ... feel free to fix that up if my memory is out of date or corrupted.
I think that's accurate. I'll wait for review comments on the rest of the
series and I'll fix this one in my next revision.
Thanks
Kishon
next prev parent reply other threads:[~2020-06-12 5:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 13:05 [PATCH v2 00/14] Implement NTB Controller using multiple PCI EP Kishon Vijay Abraham I
2020-06-11 13:05 ` [PATCH v2 01/14] Documentation: PCI: Add specification for the *PCI NTB* function device Kishon Vijay Abraham I
2020-06-11 15:13 ` Matthew Wilcox
2020-06-12 5:30 ` Kishon Vijay Abraham I [this message]
2020-06-11 13:05 ` [PATCH v2 02/14] PCI: endpoint: Make *_get_first_free_bar() take into account 64 bit BAR Kishon Vijay Abraham I
2020-06-11 13:05 ` [PATCH v2 03/14] PCI: endpoint: Add helper API to get the 'next' unreserved BAR Kishon Vijay Abraham I
2020-06-11 13:05 ` [PATCH v2 04/14] PCI: endpoint: Make *_free_bar() to return error codes on failure Kishon Vijay Abraham I
2020-06-11 13:05 ` [PATCH v2 05/14] PCI: endpoint: Remove unused pci_epf_match_device() Kishon Vijay Abraham I
2020-06-11 13:05 ` [PATCH v2 06/14] PCI: endpoint: Add support to associate secondary EPC with EPF Kishon Vijay Abraham I
2020-06-11 13:05 ` [PATCH v2 07/14] PCI: endpoint: Add support in configfs to associate two EPCs " Kishon Vijay Abraham I
2020-06-11 13:05 ` [PATCH v2 08/14] PCI: endpoint: Add pci_epc_ops to map MSI irq Kishon Vijay Abraham I
2020-06-11 13:05 ` [PATCH v2 09/14] PCI: cadence: Implement ->msi_map_irq() ops Kishon Vijay Abraham I
2020-06-11 13:05 ` [PATCH v2 10/14] PCI: endpoint: Add EP function driver to provide NTB functionality Kishon Vijay Abraham I
2020-06-11 13:05 ` [PATCH v2 11/14] PCI: Add TI J721E device to pci ids Kishon Vijay Abraham I
2020-06-11 13:05 ` [PATCH v2 12/14] NTB: Add support for EPF PCI-Express Non-Transparent Bridge Kishon Vijay Abraham I
2020-06-11 13:05 ` [PATCH v2 13/14] NTB: tool: Enable the NTB/PCIe link on the local or remote side of bridge Kishon Vijay Abraham I
2020-06-11 13:05 ` [PATCH v2 14/14] Documentation: PCI: Add userguide for PCI endpoint NTB function Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8a5d63a-7026-2b40-4b26-5f4e481f7df4@ti.com \
--to=kishon@ti.com \
--cc=allenbh@gmail.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=dave.jiang@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdmason@kudzu.us \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=tjoseph@cadence.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).