From: Markus Elfring <Markus.Elfring@web.de>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Serge Semin <fancer.lancer@gmail.com>,
Wang Ming <machel@vivo.com>,
opensource.kernel@vivo.com, kernel-janitors@vger.kernel.org,
ntb@lists.linux.dev
Cc: LKML <linux-kernel@vger.kernel.org>,
Minjie Du <duminjie@vivo.com>, Allen Hubbe <allenbh@gmail.com>,
Dan Carpenter <error27@gmail.com>,
Dave Jiang <dave.jiang@intel.com>,
Jiasheng Jiang <jiasheng@iscas.ac.cn>,
Jon Mason <jdmason@kudzu.us>
Subject: Re: [v3] ntb: Remove error checking for debugfs_create_dir()
Date: Fri, 14 Jul 2023 19:23:54 +0200 [thread overview]
Message-ID: <e4a0a8a3-1699-83b9-d713-aa40866f1720@web.de> (raw)
In-Reply-To: <5d0cd0e0-d92e-42d3-a6d9-ec9fc3229b7b@kadam.mountain>
>>>> It is expected that most callers should _ignore_ the errors
>>>> return by debugfs_create_dir() in tool_setup_dbgfs()
>> …
>>> The patch itself is correct for sure:
>>> Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
>>
>> How does such information fit to the Linux development requirement
>> for imperative change descriptions?
>
> Markus, you already replied to this thread.
Yes.
Some patch versions were similarly affected.
> Greg, HCH, Matthew Wilcox and Krzysztof Kozlowski have all asked you to stop.
They responded in this way because of some communication factors
(which might be unclear to some degree).
> Those are respected kernel maintainers.
Yes, of course.
> You should listen to them.
This happens.
But several development discussions provide opportunities for different ideas
and corresponding advices.
> If you see a bug, that's useful.
The change acceptance can grow accordingly.
> But if you're just nitpicking the
> commit message, that's not useful.
I dare to present additional patch review concerns.
It seems that further contributors occasionally dare also to support
such open issues.
> We have explained this many times as
> clearly as we know how.
We came along recurring communication concerns
(for which a consensus is not directly achieved so far).
>> See also:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc1#n94
>>
>>
>> How do you think about to add the tag “Fixes” because of the deletion
>> of an inappropriate error detection?
>
> No. It's not a bug fix so a Fixes tag is innappropriate.
Would you eventually prefer any other solution for the discussed patch approach?
Regards,
Markus
prev parent reply other threads:[~2023-07-14 17:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 8:56 [PATCH v3] ntb: Remove error checking for debugfs_create_dir() Wang Ming
2023-07-13 9:27 ` Dan Carpenter
2023-07-13 10:07 ` 回复: " 王明-软件底层技术部
2023-07-13 10:14 ` Dan Carpenter
2023-07-13 10:23 ` 回复: " 王明-软件底层技术部
2023-07-13 16:05 ` Dave Jiang
2023-07-13 20:05 ` Markus Elfring
2023-07-14 5:57 ` Dan Carpenter
2023-07-14 6:50 ` Markus Elfring
2023-07-14 10:00 ` Serge Semin
2023-07-14 12:44 ` Markus Elfring
2023-07-14 14:03 ` Serge Semin
2023-07-14 16:56 ` [v3] " Markus Elfring
2023-07-14 14:08 ` [PATCH v3] " Dan Carpenter
2023-07-14 17:23 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4a0a8a3-1699-83b9-d713-aa40866f1720@web.de \
--to=markus.elfring@web.de \
--cc=allenbh@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=dave.jiang@intel.com \
--cc=duminjie@vivo.com \
--cc=error27@gmail.com \
--cc=fancer.lancer@gmail.com \
--cc=jdmason@kudzu.us \
--cc=jiasheng@iscas.ac.cn \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=machel@vivo.com \
--cc=ntb@lists.linux.dev \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).