NTFS3 file system kernel mode driver
 help / color / mirror / Atom feed
From: Thorsten Leemhuis <regressions@leemhuis.info>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc: ntfs3@lists.linux.dev,
	Linux kernel regressions list <regressions@lists.linux.dev>,
	Linux kernel regressions list <regressions@lists.linux.dev>
Subject: [regressions] ntfs3: empty file on update without forced cache drop
Date: Mon, 27 Nov 2023 07:18:46 +0100	[thread overview]
Message-ID: <138ed123-0f84-4d7a-8a17-67fe2418cf29@leemhuis.info> (raw)

Hi, Thorsten here, the Linux kernel's regression tracker.

Konstantin, I noticed a regression report in bugzilla.kernel.org.
Apparently it's cause by a change of yours.

As many (most?) kernel developers don't keep an eye on bugzilla, I
decided to forward it by mail. Note, you have to use bugzilla to reach
the reporter, as I sadly[1] can not CCed them in mails like this.

Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=218180 :

> The problem I am facing is the following:
> 1. I mount an NTFS partition via NTFS3
> 2. I create a file
> 3. I write to the file
> 4. The file is empty
> 5. I remount the partition
> 6. The file has the changes I made before the remount
> 
> I can avoid the remount by doing:
> sudo sysctl vm.drop_caches=3

See the ticket for more details. It according to the report happens
still happens with 6.7-rc2, but not with 6.1.y. The reporter bisected
the problem to ad26a9c84510af ("fs/ntfs3: Fixing wrong logic in
attr_set_size and ntfs_fallocate") [v6.2-rc1].

Side note: while briefly checking lore for existing problems caused by
that change I noticed two syzbot reports about it that apparently nobody
looked into:

https://lore.kernel.org/all/000000000000bdf37505f1a7fc09@google.com/
https://lore.kernel.org/all/00000000000062174006016bc386@google.com/

[TLDR for the rest of this mail: I'm adding this report to the list of
tracked Linux kernel regressions; the text you find below is based on a
few templates paragraphs you might have encountered already in similar
form.]

BTW, let me use this mail to also add the report to the list of tracked
regressions to ensure it's doesn't fall through the cracks:

#regzbot introduced: ad26a9c84510af
https://bugzilla.kernel.org/show_bug.cgi?id=218180
#regzbot title: ntfs3: empty file on update without forced cache drop
#regzbot ignore-activity

This isn't a regression? This issue or a fix for it are already
discussed somewhere else? It was fixed already? You want to clarify when
the regression started to happen? Or point out I got the title or
something else totally wrong? Then just reply and tell me -- ideally
while also telling regzbot about it, as explained by the page listed in
the footer of this mail.

Developers: When fixing the issue, remember to add 'Link:' tags pointing
to the report (e.g. the buzgzilla ticket and maybe this mail as well, if
this thread sees some discussion). See page linked in footer for details.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

[1] because bugzilla.kernel.org tells users upon registration their
"email address will never be displayed to logged out users"

             reply	other threads:[~2023-11-27  6:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-27  6:18 Thorsten Leemhuis [this message]
2023-12-05 12:49 ` [regressions] ntfs3: empty file on update without forced cache drop Linux regression tracking (Thorsten Leemhuis)
2024-01-21  9:14   ` Thorsten Leemhuis
2024-01-26 12:57     ` Konstantin Komarov
2024-01-15 11:15 ` Giovanni Santini
2024-02-11  7:28 ` Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=138ed123-0f84-4d7a-8a17-67fe2418cf29@leemhuis.info \
    --to=regressions@leemhuis.info \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=ntfs3@lists.linux.dev \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).