From: Jan Kara <jack@suse.cz>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Sterba <dsterba@suse.com>,
linux-fsdevel@vger.kernel.org,
Pankaj Raghav <p.raghav@samsung.com>,
Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
ntfs3@lists.linux.dev, Theodore Tso <tytso@mit.edu>,
Jan Kara <jack@suse.com>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 7/7] buffer: Remove set_bh_page()
Date: Mon, 31 Jul 2023 16:46:03 +0200 [thread overview]
Message-ID: <20230731144603.4ehtpamxbhhd7fv5@quack3> (raw)
In-Reply-To: <20230713035512.4139457-8-willy@infradead.org>
On Thu 13-07-23 04:55:12, Matthew Wilcox (Oracle) wrote:
> With all users converted to folio_set_bh(), remove this function.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Sure. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/buffer.c | 15 ---------------
> include/linux/buffer_head.h | 2 --
> 2 files changed, 17 deletions(-)
>
> diff --git a/fs/buffer.c b/fs/buffer.c
> index 587e4d4af9de..f0563ebae75f 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -1539,21 +1539,6 @@ void invalidate_bh_lrus_cpu(void)
> bh_lru_unlock();
> }
>
> -void set_bh_page(struct buffer_head *bh,
> - struct page *page, unsigned long offset)
> -{
> - bh->b_page = page;
> - BUG_ON(offset >= PAGE_SIZE);
> - if (PageHighMem(page))
> - /*
> - * This catches illegal uses and preserves the offset:
> - */
> - bh->b_data = (char *)(0 + offset);
> - else
> - bh->b_data = page_address(page) + offset;
> -}
> -EXPORT_SYMBOL(set_bh_page);
> -
> void folio_set_bh(struct buffer_head *bh, struct folio *folio,
> unsigned long offset)
> {
> diff --git a/include/linux/buffer_head.h b/include/linux/buffer_head.h
> index a7377877ff4e..06566aee94ca 100644
> --- a/include/linux/buffer_head.h
> +++ b/include/linux/buffer_head.h
> @@ -194,8 +194,6 @@ void buffer_check_dirty_writeback(struct folio *folio,
> void mark_buffer_dirty(struct buffer_head *bh);
> void mark_buffer_write_io_error(struct buffer_head *bh);
> void touch_buffer(struct buffer_head *bh);
> -void set_bh_page(struct buffer_head *bh,
> - struct page *page, unsigned long offset);
> void folio_set_bh(struct buffer_head *bh, struct folio *folio,
> unsigned long offset);
> bool try_to_free_buffers(struct folio *);
> --
> 2.39.2
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2023-07-31 14:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 3:55 [PATCH 0/7] More filesystem folio conversions for 6.6 Matthew Wilcox (Oracle)
2023-07-13 3:55 ` [PATCH 1/7] highmem: Add memcpy_to_folio() and memcpy_from_folio() Matthew Wilcox (Oracle)
2023-07-22 0:06 ` Andreas Grünbacher
2023-07-13 3:55 ` [PATCH 2/7] affs: Convert affs_symlink_read_folio() to use the folio Matthew Wilcox (Oracle)
2023-07-21 16:50 ` David Sterba
2023-07-13 3:55 ` [PATCH 3/7] affs: Convert data read and write to use folios Matthew Wilcox (Oracle)
2023-07-13 10:36 ` Pankaj Raghav
2023-07-21 16:51 ` David Sterba
2023-07-13 3:55 ` [PATCH 4/7] migrate: Use folio_set_bh() instead of set_bh_page() Matthew Wilcox (Oracle)
2023-07-31 14:44 ` Jan Kara
2023-07-13 3:55 ` [PATCH 5/7] ntfs3: Convert ntfs_get_block_vbo() to use a folio Matthew Wilcox (Oracle)
2023-07-13 3:55 ` [PATCH 6/7] jbd2: Use a folio in jbd2_journal_write_metadata_buffer() Matthew Wilcox (Oracle)
2023-07-31 14:43 ` Jan Kara
2023-07-13 3:55 ` [PATCH 7/7] buffer: Remove set_bh_page() Matthew Wilcox (Oracle)
2023-07-31 14:46 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731144603.4ehtpamxbhhd7fv5@quack3 \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=dsterba@suse.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=p.raghav@samsung.com \
--cc=tytso@mit.edu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).