From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "chengming.zhou@linux.dev" <chengming.zhou@linux.dev>,
"Jiang, Dave" <dave.jiang@intel.com>,
"Williams, Dan J" <dan.j.williams@intel.com>
Cc: "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dax: remove SLAB_MEM_SPREAD flag usage
Date: Wed, 28 Feb 2024 05:32:45 +0000 [thread overview]
Message-ID: <11abf2aca138b389d7ab5c2d6b75d82fb6b1bddc.camel@intel.com> (raw)
In-Reply-To: <e30fa7b9-e04b-48f8-9068-0a7afed2107e@linux.dev>
On Wed, 2024-02-28 at 11:16 +0800, Chengming Zhou wrote:
> On 2024/2/28 00:29, Dave Jiang wrote:
> >
> >
> > On 2/24/24 6:47 AM, chengming.zhou@linux.dev wrote:
> > > From: Chengming Zhou <zhouchengming@bytedance.com>
> > >
> > > The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> > > its usage so we can delete it from slab. No functional change.
> >
> > Can you please provide a Link tag to the lore post that indicates SLAB_MEM_SPREAD flag is now a no-op?
>
> Update changelog to make it clearer:
>
> The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
> removed as of v6.8-rc1, so it became a dead flag since the commit
> 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
> series[1] went on to mark it obsolete explicitly to avoid confusion
> for users. Here we can just remove all its users, which has no any
> functional change.
>
> [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/
>
> Thanks!
With the updated changelog, you can add
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
>
> > >
> > > Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> > > ---
> > > drivers/dax/super.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/dax/super.c b/drivers/dax/super.c
> > > index 54e528779877..cff0a15b7236 100644
> > > --- a/drivers/dax/super.c
> > > +++ b/drivers/dax/super.c
> > > @@ -547,7 +547,7 @@ static int dax_fs_init(void)
> > >
> > > dax_cache = kmem_cache_create("dax_cache", sizeof(struct dax_device), 0,
> > > (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
> > > - SLAB_MEM_SPREAD|SLAB_ACCOUNT),
> > > + SLAB_ACCOUNT),
> > > init_once);
> > > if (!dax_cache)
> > > return -ENOMEM;
prev parent reply other threads:[~2024-02-28 5:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-24 13:47 [PATCH] dax: remove SLAB_MEM_SPREAD flag usage chengming.zhou
2024-02-27 16:29 ` Dave Jiang
2024-02-28 3:16 ` Chengming Zhou
2024-02-28 5:32 ` Verma, Vishal L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11abf2aca138b389d7ab5c2d6b75d82fb6b1bddc.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=chengming.zhou@linux.dev \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).