From: Al Viro <viro@zeniv.linux.org.uk>
To: Xueshi Hu <xueshi.hu@smartx.com>
Cc: hch@infradead.org, dan.j.williams@intel.com,
vishal.l.verma@intel.com, dave.jiang@intel.com,
jayalk@intworks.biz, daniel@ffwll.ch, deller@gmx.de,
bcrl@kvack.org, brauner@kernel.org, jack@suse.com, tytso@mit.edu,
adilger.kernel@dilger.ca, miklos@szeredi.hu,
mike.kravetz@oracle.com, muchun.song@linux.dev,
djwong@kernel.org, willy@infradead.org,
akpm@linux-foundation.org, hughd@google.com,
nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-aio@kvack.org,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-mm@kvack.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2] fs: clean up usage of noop_dirty_folio
Date: Mon, 28 Aug 2023 15:42:42 +0100 [thread overview]
Message-ID: <20230828144242.GZ3390869@ZenIV> (raw)
In-Reply-To: <20230828075449.262510-1-xueshi.hu@smartx.com>
On Mon, Aug 28, 2023 at 03:54:49PM +0800, Xueshi Hu wrote:
> In folio_mark_dirty(), it can automatically fallback to
> noop_dirty_folio() if a_ops->dirty_folio is not registered.
>
> As anon_aops, dev_dax_aops and fb_deferred_io_aops becames empty, remove
> them too.
I'd put the last sentence as 'In dev_dax_aops and fb_deferred_io_aops replacing
.dirty_folio with NULL makes them identical to default (empty_aops) and since
we never compare ->a_ops pointer with either of those, we can remove them
completely'.
There could've been places like
#define is_fb_deferred(mapping) (mapping)->a_ops == fb_deferred_io_aops
and those would've been broken by that. The fact that there's nothing
of that sort in the tree ought to be mentioned in commit message.
Note that we *do* have places where method table comparisons are used
in predicates like that, so it's not a pure theory; sure, missing that
would've probably ended up with broken build, but that can easily be
dependent upon the config (and that, alas, is also not a pure theory -
BTDT). In this case the change is correct, fortunately...
Other than that part of commit message -
Acked-by: Al Viro <viro@zeniv.linux.org.uk>
prev parent reply other threads:[~2023-08-28 14:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 7:54 [PATCH v2] fs: clean up usage of noop_dirty_folio Xueshi Hu
2023-08-28 10:58 ` Jan Kara
2023-08-28 12:00 ` Christoph Hellwig
2023-08-28 12:18 ` Matthew Wilcox
2023-08-28 14:42 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230828144242.GZ3390869@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=brauner@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=daniel@ffwll.ch \
--cc=dave.jiang@intel.com \
--cc=deller@gmx.de \
--cc=djwong@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=jack@suse.com \
--cc=jayalk@intworks.biz \
--cc=linux-aio@kvack.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=miklos@szeredi.hu \
--cc=muchun.song@linux.dev \
--cc=nvdimm@lists.linux.dev \
--cc=tytso@mit.edu \
--cc=vishal.l.verma@intel.com \
--cc=willy@infradead.org \
--cc=xueshi.hu@smartx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).