From: alison.schofield@intel.com
To: Vishal Verma <vishal.l.verma@intel.com>
Cc: Alison Schofield <alison.schofield@intel.com>,
nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org
Subject: [ndctl PATCH] cxl/test: validate the auto region in cxl-topology.sh
Date: Tue, 21 Nov 2023 18:18:49 -0800 [thread overview]
Message-ID: <20231122021849.1208967-1-alison.schofield@intel.com> (raw)
From: Alison Schofield <alison.schofield@intel.com>
The cxl-test module sets up a region to be autodiscovered in
order to test the CXL driver handling of BIOS defined regions.
Confirm the region exists upon load of the cxl-test module.
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
---
The region does survive the ensuing shenanigans of this test.
The region state moves from committed to disabled and back
again as the memdevs, ports, and host bridges are disabled
and then re-enabled. Although that was interesting, it's not
clear that this test should be doing region error recovery
testing.
Let me know if you think otherwise?
test/cxl-topology.sh | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/test/cxl-topology.sh b/test/cxl-topology.sh
index 89d01a89ccb1..e8b9f56543b5 100644
--- a/test/cxl-topology.sh
+++ b/test/cxl-topology.sh
@@ -21,6 +21,14 @@ rc=1
# tools/testing/cxl/test/cxl.c. If that model ever changes then the
# paired update must be made to this test.
+# validate the autodiscovered region
+region=$("$CXL" list -R | jq -r ".[] | .region")
+if [[ ! $region ]]; then
+ echo "failed to find autodiscovered region"
+ err "$LINENO"
+fi
+
+
# collect cxl_test root device id
json=$($CXL list -b cxl_test)
count=$(jq "length" <<< $json)
base-commit: a871e6153b11fe63780b37cdcb1eb347b296095c
--
2.37.3
next reply other threads:[~2023-11-22 2:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 2:18 alison.schofield [this message]
2023-11-22 18:55 ` [ndctl PATCH] cxl/test: validate the auto region in cxl-topology.sh Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231122021849.1208967-1-alison.schofield@intel.com \
--to=alison.schofield@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).