From: Vishal Verma <vishal.l.verma@intel.com>
To: Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, nvdimm@lists.linux.dev,
linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
Vishal Verma <vishal.l.verma@intel.com>
Subject: [PATCH v3 0/4] dax/bus.c: Fixups for dax-bus locking
Date: Tue, 30 Apr 2024 11:44:22 -0600 [thread overview]
Message-ID: <20240430-vv-dax_abi_fixes-v3-0-e3dcd755774c@intel.com> (raw)
Commit Fixes: c05ae9d85b47 ("dax/bus.c: replace driver-core lock usage by a local rwsem")
introduced a few problems that this series aims to fix. Add back
device_lock() where it was correctly used (during device manipulation
operations), remove conditional locking in unregister_dax_dev() and
unregister_dax_mapping(), use non-interruptible versions of rwsem
locks when not called from a user process, and fix up a write vs.
read usage of an rwsem.
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
Changes in v3:
- Rebase to v6.9-rc6
- Collect review tags (Dan)
- Reword commit message for patch 2 (Dan)
- Use plain down_write() in delete_store() (Dan)
- Link to v2: https://lore.kernel.org/r/20240416-vv-dax_abi_fixes-v2-0-d5f0c8ec162e@intel.com
Changes in v2:
- Add back valid device_lock uses (Dan)
- Remove conditional locking (Dan)
- Use non-interruptible versions of rwsem locks when not called from a
user process (Dan)
- Fix up a write vs. read usage of an rwsem
- Link to v1: https://lore.kernel.org/r/20240402-vv-dax_abi_fixes-v1-1-c3e0fdbafba5@intel.com
---
Vishal Verma (4):
dax/bus.c: replace WARN_ON_ONCE() with lockdep asserts
dax/bus.c: fix locking for unregister_dax_dev / unregister_dax_mapping paths
dax/bus.c: Don't use down_write_killable for non-user processes
dax/bus.c: Use the right locking mode (read vs write) in size_show
drivers/dax/bus.c | 66 +++++++++++++++----------------------------------------
1 file changed, 18 insertions(+), 48 deletions(-)
---
base-commit: e67572cd2204894179d89bd7b984072f19313b03
change-id: 20240402-vv-dax_abi_fixes-8af3b6ff2e5a
Best regards,
--
Vishal Verma <vishal.l.verma@intel.com>
next reply other threads:[~2024-04-30 17:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 17:44 Vishal Verma [this message]
2024-04-30 17:44 ` [PATCH v3 1/4] dax/bus.c: replace WARN_ON_ONCE() with lockdep asserts Vishal Verma
2024-04-30 17:44 ` [PATCH v3 2/4] dax/bus.c: fix locking for unregister_dax_dev / unregister_dax_mapping paths Vishal Verma
2024-04-30 17:44 ` [PATCH v3 3/4] dax/bus.c: Don't use down_write_killable for non-user processes Vishal Verma
2024-04-30 17:44 ` [PATCH v3 4/4] dax/bus.c: Use the right locking mode (read vs write) in size_show Vishal Verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430-vv-dax_abi_fixes-v3-0-e3dcd755774c@intel.com \
--to=vishal.l.verma@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).