From: Davidlohr Bueso <dave@stgolabs.net>
To: Jehoon Park <jehoon.park@samsung.com>
Cc: linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Kyungsan Kim <ks0204.kim@samsung.com>,
Junhyeok Im <junhyeok.im@samsung.com>
Subject: Re: [ndctl PATCH v3 0/2] add support for Set Alert Configuration mailbox command
Date: Mon, 9 Oct 2023 20:14:02 -0700 [thread overview]
Message-ID: <3qqfaoruluq7jd2cnz4mhpq632wov5x7cfizuarlfyjedkwi5v@aimuecxmqgvy> (raw)
In-Reply-To: <20230918045514.6709-1-jehoon.park@samsung.com>
On Mon, 18 Sep 2023, Jehoon Park wrote:
>CXL 3.0 Spec 8.2.9.8.3.3 defines Set Alert Configuration mailbox command,
>which configures device's warning alerts.
>This patchset adds support for the command.
>
>The implementation is based on the 'ndctl-inject-smart'. Variable and function
>names are aligned with the implementation of 'Get Alert Configuration'.
>
>Changes in v3
>- Reorganize cover letter and commit message (Davidlohr)
>- Update details of the example in man page
>- Move 'verbose' option to the end in man page (Davidlohr)
>- Link to v2: https://lore.kernel.org/r/20230807063335.5891-1-jehoon.park@samsung.com
>
>Changes in v2
>- Rebase on the latest pending branch
>- Remove full usage text in the commit message (Vishal)
>- Correct texts in document and log_info() (Vishal)
>- Change strncmp() to strcmp() for parsing params (Vishal)
>- Link to v1: https://lore.kernel.org/r/20230711071019.7151-1-jehoon.park@samsung.com
>
>*** BLURB HERE ***
>
>Jehoon Park (2):
> libcxl: add support for Set Alert Configuration mailbox command
> cxl: add 'set-alert-config' command to cxl tool
Looks good, for the series feel free to add:
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
prev parent reply other threads:[~2023-10-10 5:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230918045208epcas2p36f0c80940e86e5165a3036414a32d7f6@epcas2p3.samsung.com>
2023-09-18 4:55 ` [ndctl PATCH v3 0/2] add support for Set Alert Configuration mailbox command Jehoon Park
[not found] ` <CGME20230918045216epcas2p4a7e7cb5aeb67c0547f6af87ba1e48f20@epcas2p4.samsung.com>
2023-09-18 4:55 ` [ndctl PATCH v3 1/2] libcxl: " Jehoon Park
[not found] ` <CGME20230918045228epcas2p181e537fc166c04d371f09cba921751b4@epcas2p1.samsung.com>
2023-09-18 4:55 ` [ndctl PATCH v3 2/2] cxl: add 'set-alert-config' command to cxl tool Jehoon Park
2023-10-10 3:14 ` Davidlohr Bueso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3qqfaoruluq7jd2cnz4mhpq632wov5x7cfizuarlfyjedkwi5v@aimuecxmqgvy \
--to=dave@stgolabs.net \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=jehoon.park@samsung.com \
--cc=jonathan.cameron@huawei.com \
--cc=junhyeok.im@samsung.com \
--cc=ks0204.kim@samsung.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).