From: Dave Jiang <dave.jiang@intel.com>
To: alison.schofield@intel.com, Vishal Verma <vishal.l.verma@intel.com>
Cc: nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org
Subject: Re: [ndctl PATCH v7 6/7] cxl/list: add --media-errors option to cxl list
Date: Thu, 8 Feb 2024 09:51:36 -0700 [thread overview]
Message-ID: <59f801c7-184e-4594-8f18-52438096d235@intel.com> (raw)
In-Reply-To: <6f03d2d26d17beb33d28c7471a4fbfc1ec8a8e21.1707351560.git.alison.schofield@intel.com>
On 2/7/24 6:01 PM, alison.schofield@intel.com wrote:
> From: Alison Schofield <alison.schofield@intel.com>
>
> The --media-errors option to 'cxl list' retrieves poison lists from
> memory devices supporting the capability and displays the returned
> media_error records in the cxl list json. This option can apply to
> memdevs or regions.
>
> Include media-errors in the -vvv verbose option.
>
> Example usage in the Documentation/cxl/cxl-list.txt update.
>
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> Documentation/cxl/cxl-list.txt | 79 +++++++++++++++++++++++++++++++++-
> cxl/filter.h | 3 ++
> cxl/list.c | 3 ++
> 3 files changed, 84 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/cxl/cxl-list.txt b/Documentation/cxl/cxl-list.txt
> index 838de4086678..5c20614ef579 100644
> --- a/Documentation/cxl/cxl-list.txt
> +++ b/Documentation/cxl/cxl-list.txt
> @@ -415,6 +415,83 @@ OPTIONS
> --region::
> Specify CXL region device name(s), or device id(s), to filter the listing.
>
> +-L::
> +--media-errors::
> + Include media-error information. The poison list is retrieved from the
> + device(s) and media_error records are added to the listing. Apply this
> + option to memdevs and regions where devices support the poison list
> + capability.
> +
> + "decoder" and "hpa" are included when the media-error is in a mapped
> + address.
> +
> + "source" will be one of: External, Internal, Injected, Vendor Specific,
> + or Unknown, as defined in CXL Specification v3.1 Table 8-140.
> +
> +----
> +# cxl list -m mem1 --media-errors
> +[
> + {
> + "memdev":"mem1",
> + "pmem_size":1073741824,
> + "ram_size":1073741824,
> + "serial":1,
> + "numa_node":1,
> + "host":"cxl_mem.1",
> + "media_errors":[
> + {
> + "dpa":0,
> + "length":64,
> + "source":"Internal"
> + },
> + {
> + "decoder":"decoder10.0",
> + "hpa":1035355557888,
> + "dpa":1073741824,
> + "length":64,
> + "source":"External"
> + },
> + {
> + "decoder":"decoder10.0",
> + "hpa":1035355566080,
> + "dpa":1073745920,
> + "length":64,
> + "source":"Injected"
> + }
> + ]
> + }
> +]
> +
> +# cxl list -r region5 --media-errors
> +[
> + {
> + "region":"region5",
> + "resource":1035355553792,
> + "size":2147483648,
> + "type":"pmem",
> + "interleave_ways":2,
> + "interleave_granularity":4096,
> + "decode_state":"commit",
> + "media_errors":[
> + {
> + "decoder":"decoder10.0",
> + "hpa":1035355557888,
> + "dpa":1073741824,
> + "length":64,
> + "source":"External"
> + },
> + {
> + "decoder":"decoder8.1",
> + "hpa":1035355553792,
> + "dpa":1073741824,
> + "length":64,
> + "source":"Internal"
> + }
> + ]
> + }
> +]
> +----
> +
> -v::
> --verbose::
> Increase verbosity of the output. This can be specified
> @@ -431,7 +508,7 @@ OPTIONS
> devices with --idle.
> - *-vvv*
> Everything *-vv* provides, plus enable
> - --health and --partition.
> + --health, --partition, --media-errors.
>
> --debug::
> If the cxl tool was built with debug enabled, turn on debug
> diff --git a/cxl/filter.h b/cxl/filter.h
> index 3f65990f835a..956a46e0c7a9 100644
> --- a/cxl/filter.h
> +++ b/cxl/filter.h
> @@ -30,6 +30,7 @@ struct cxl_filter_params {
> bool fw;
> bool alert_config;
> bool dax;
> + bool media_errors;
> int verbose;
> struct log_ctx ctx;
> };
> @@ -88,6 +89,8 @@ static inline unsigned long cxl_filter_to_flags(struct cxl_filter_params *param)
> flags |= UTIL_JSON_ALERT_CONFIG;
> if (param->dax)
> flags |= UTIL_JSON_DAX | UTIL_JSON_DAX_DEVS;
> + if (param->media_errors)
> + flags |= UTIL_JSON_MEDIA_ERRORS;
> return flags;
> }
>
> diff --git a/cxl/list.c b/cxl/list.c
> index 93ba51ef895c..0b25d78248d5 100644
> --- a/cxl/list.c
> +++ b/cxl/list.c
> @@ -57,6 +57,8 @@ static const struct option options[] = {
> "include memory device firmware information"),
> OPT_BOOLEAN('A', "alert-config", ¶m.alert_config,
> "include alert configuration information"),
> + OPT_BOOLEAN('L', "media-errors", ¶m.media_errors,
> + "include media-error information "),
> OPT_INCR('v', "verbose", ¶m.verbose, "increase output detail"),
> #ifdef ENABLE_DEBUG
> OPT_BOOLEAN(0, "debug", &debug, "debug list walk"),
> @@ -121,6 +123,7 @@ int cmd_list(int argc, const char **argv, struct cxl_ctx *ctx)
> param.fw = true;
> param.alert_config = true;
> param.dax = true;
> + param.media_errors = true;
> /* fallthrough */
> case 2:
> param.idle = true;
next prev parent reply other threads:[~2024-02-08 16:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 1:01 [ndctl PATCH v7 0/7] Support poison list retrieval alison.schofield
2024-02-08 1:01 ` [ndctl PATCH v7 1/7] libcxl: add interfaces for GET_POISON_LIST mailbox commands alison.schofield
2024-02-08 1:01 ` [ndctl PATCH v7 2/7] cxl: add an optional pid check to event parsing alison.schofield
2024-02-08 1:01 ` [ndctl PATCH v7 3/7] cxl/event_trace: add a private context for private parsers alison.schofield
2024-02-08 1:01 ` [ndctl PATCH v7 4/7] cxl/event_trace: add helpers get_field_[string|data]() alison.schofield
2024-02-08 1:01 ` [ndctl PATCH v7 5/7] cxl/list: collect and parse media_error records alison.schofield
2024-02-08 16:50 ` Dave Jiang
2024-02-29 2:45 ` Alison Schofield
2024-02-08 1:01 ` [ndctl PATCH v7 6/7] cxl/list: add --media-errors option to cxl list alison.schofield
2024-02-08 16:51 ` Dave Jiang [this message]
2024-02-08 1:01 ` [ndctl PATCH v7 7/7] cxl/test: add cxl-poison.sh unit test alison.schofield
2024-02-08 18:18 ` Dave Jiang
2024-02-22 8:04 ` Verma, Vishal L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59f801c7-184e-4594-8f18-52438096d235@intel.com \
--to=dave.jiang@intel.com \
--cc=alison.schofield@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).