* [PATCH v2] daxctl: Remove unused memory_zone and mem_zone
@ 2023-08-11 1:16 Xiao Yang
2023-10-09 9:40 ` Xiao Yang (Fujitsu)
2024-01-17 20:09 ` Dan Williams
0 siblings, 2 replies; 5+ messages in thread
From: Xiao Yang @ 2023-08-11 1:16 UTC (permalink / raw
To: vishal.l.verma, fan.ni, nvdimm; +Cc: linux-cxl, Xiao Yang
The enum memory_zone definition and mem_zone variable
have never been used so remove them.
Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
---
daxctl/device.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/daxctl/device.c b/daxctl/device.c
index d2d206b..8391343 100644
--- a/daxctl/device.c
+++ b/daxctl/device.c
@@ -55,12 +55,6 @@ static unsigned long flags;
static struct mapping *maps = NULL;
static long long nmaps = -1;
-enum memory_zone {
- MEM_ZONE_MOVABLE,
- MEM_ZONE_NORMAL,
-};
-static enum memory_zone mem_zone = MEM_ZONE_MOVABLE;
-
enum device_action {
ACTION_RECONFIG,
ACTION_ONLINE,
@@ -469,8 +463,6 @@ static const char *parse_device_options(int argc, const char **argv,
align = __parse_size64(param.align, &units);
} else if (strcmp(param.mode, "system-ram") == 0) {
reconfig_mode = DAXCTL_DEV_MODE_RAM;
- if (param.no_movable)
- mem_zone = MEM_ZONE_NORMAL;
} else if (strcmp(param.mode, "devdax") == 0) {
reconfig_mode = DAXCTL_DEV_MODE_DEVDAX;
if (param.no_online) {
@@ -494,9 +486,6 @@ static const char *parse_device_options(int argc, const char **argv,
align = __parse_size64(param.align, &units);
/* fall through */
case ACTION_ONLINE:
- if (param.no_movable)
- mem_zone = MEM_ZONE_NORMAL;
- /* fall through */
case ACTION_DESTROY:
case ACTION_OFFLINE:
case ACTION_DISABLE:
--
2.40.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH v2] daxctl: Remove unused memory_zone and mem_zone
2023-08-11 1:16 [PATCH v2] daxctl: Remove unused memory_zone and mem_zone Xiao Yang
@ 2023-10-09 9:40 ` Xiao Yang (Fujitsu)
2023-12-01 4:12 ` Ira Weiny
2024-01-17 20:09 ` Dan Williams
1 sibling, 1 reply; 5+ messages in thread
From: Xiao Yang (Fujitsu) @ 2023-10-09 9:40 UTC (permalink / raw
To: Xiao Yang (Fujitsu), vishal.l.verma@intel.com, fan.ni@gmx.us,
nvdimm@lists.linux.dev
Cc: linux-cxl@vger.kernel.org
Ping. ^_^
-----Original Message-----
From: Xiao Yang <yangx.jy@fujitsu.com>
Sent: 2023年8月11日 9:16
To: vishal.l.verma@intel.com; fan.ni@gmx.us; nvdimm@lists.linux.dev
Cc: linux-cxl@vger.kernel.org; Yang, Xiao/杨 晓 <yangx.jy@fujitsu.com>
Subject: [PATCH v2] daxctl: Remove unused memory_zone and mem_zone
The enum memory_zone definition and mem_zone variable have never been used so remove them.
Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
---
daxctl/device.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/daxctl/device.c b/daxctl/device.c index d2d206b..8391343 100644
--- a/daxctl/device.c
+++ b/daxctl/device.c
@@ -55,12 +55,6 @@ static unsigned long flags; static struct mapping *maps = NULL; static long long nmaps = -1;
-enum memory_zone {
- MEM_ZONE_MOVABLE,
- MEM_ZONE_NORMAL,
-};
-static enum memory_zone mem_zone = MEM_ZONE_MOVABLE;
-
enum device_action {
ACTION_RECONFIG,
ACTION_ONLINE,
@@ -469,8 +463,6 @@ static const char *parse_device_options(int argc, const char **argv,
align = __parse_size64(param.align, &units);
} else if (strcmp(param.mode, "system-ram") == 0) {
reconfig_mode = DAXCTL_DEV_MODE_RAM;
- if (param.no_movable)
- mem_zone = MEM_ZONE_NORMAL;
} else if (strcmp(param.mode, "devdax") == 0) {
reconfig_mode = DAXCTL_DEV_MODE_DEVDAX;
if (param.no_online) {
@@ -494,9 +486,6 @@ static const char *parse_device_options(int argc, const char **argv,
align = __parse_size64(param.align, &units);
/* fall through */
case ACTION_ONLINE:
- if (param.no_movable)
- mem_zone = MEM_ZONE_NORMAL;
- /* fall through */
case ACTION_DESTROY:
case ACTION_OFFLINE:
case ACTION_DISABLE:
--
2.40.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v2] daxctl: Remove unused memory_zone and mem_zone
2023-10-09 9:40 ` Xiao Yang (Fujitsu)
@ 2023-12-01 4:12 ` Ira Weiny
2024-01-15 0:11 ` Xiao Yang
0 siblings, 1 reply; 5+ messages in thread
From: Ira Weiny @ 2023-12-01 4:12 UTC (permalink / raw
To: Xiao Yang (Fujitsu), vishal.l.verma@intel.com, fan.ni@gmx.us,
nvdimm@lists.linux.dev
Cc: linux-cxl@vger.kernel.org
Xiao Yang (Fujitsu) wrote:
> Ping. ^_^
>
> -----Original Message-----
> From: Xiao Yang <yangx.jy@fujitsu.com>
> Sent: 2023年8月11日 9:16
> To: vishal.l.verma@intel.com; fan.ni@gmx.us; nvdimm@lists.linux.dev
> Cc: linux-cxl@vger.kernel.org; Yang, Xiao/杨 晓 <yangx.jy@fujitsu.com>
> Subject: [PATCH v2] daxctl: Remove unused memory_zone and mem_zone
>
> The enum memory_zone definition and mem_zone variable have never been used so remove them.
NIT: I don't know that they have never been used but they certainly seem
to have been moved to the library.
>
> Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] daxctl: Remove unused memory_zone and mem_zone
2023-12-01 4:12 ` Ira Weiny
@ 2024-01-15 0:11 ` Xiao Yang
0 siblings, 0 replies; 5+ messages in thread
From: Xiao Yang @ 2024-01-15 0:11 UTC (permalink / raw
To: Ira Weiny, vishal.l.verma@intel.com, fan.ni@gmx.us,
nvdimm@lists.linux.dev
Cc: linux-cxl@vger.kernel.org
Hi All,
Kindly Ping.
Best Regards,
Xiao Yang
On 2023/12/1 12:12, Ira Weiny wrote:
> Xiao Yang (Fujitsu) wrote:
>> Ping. ^_^
>>
>> -----Original Message-----
>> From: Xiao Yang <yangx.jy@fujitsu.com>
>> Sent: 2023年8月11日 9:16
>> To: vishal.l.verma@intel.com; fan.ni@gmx.us; nvdimm@lists.linux.dev
>> Cc: linux-cxl@vger.kernel.org; Yang, Xiao/杨 晓 <yangx.jy@fujitsu.com>
>> Subject: [PATCH v2] daxctl: Remove unused memory_zone and mem_zone
>>
>> The enum memory_zone definition and mem_zone variable have never been used so remove them.
>
> NIT: I don't know that they have never been used but they certainly seem
> to have been moved to the library.
>
>>
>> Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
>
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v2] daxctl: Remove unused memory_zone and mem_zone
2023-08-11 1:16 [PATCH v2] daxctl: Remove unused memory_zone and mem_zone Xiao Yang
2023-10-09 9:40 ` Xiao Yang (Fujitsu)
@ 2024-01-17 20:09 ` Dan Williams
1 sibling, 0 replies; 5+ messages in thread
From: Dan Williams @ 2024-01-17 20:09 UTC (permalink / raw
To: Xiao Yang, vishal.l.verma, fan.ni, nvdimm; +Cc: linux-cxl, Xiao Yang
Xiao Yang wrote:
> The enum memory_zone definition and mem_zone variable
> have never been used so remove them.
>
> Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
Looks good to me:
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-17 20:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-11 1:16 [PATCH v2] daxctl: Remove unused memory_zone and mem_zone Xiao Yang
2023-10-09 9:40 ` Xiao Yang (Fujitsu)
2023-12-01 4:12 ` Ira Weiny
2024-01-15 0:11 ` Xiao Yang
2024-01-17 20:09 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).