From: Ira Weiny <ira.weiny@intel.com>
To: Coly Li <colyli@suse.de>
Cc: Dan Williams <dan.j.williams@intel.com>,
Jens Axboe <axboe@kernel.dk>, Xiao Ni <xni@redhat.com>,
Geliang Tang <geliang.tang@suse.com>,
"Hannes Reinecke" <hare@suse.de>, NeilBrown <neilb@suse.de>,
Vishal L Verma <vishal.l.verma@intel.com>,
<linux-block@vger.kernel.org>, <nvdimm@lists.linux.dev>,
<linux-kernel@vger.kernel.org>
Subject: Bug in commit aa511ff8218b ("badblocks: switch to the improved badblock handling
Date: Fri, 22 Dec 2023 10:31:25 -0800 [thread overview]
Message-ID: <6585d5fda5183_9f731294b9@iweiny-mobl.notmuch> (raw)
Coly,
Yesterday I noticed that a few of our nvdimm tests were failing. I bisected
the problem to the following commit.
aa511ff8218b ("badblocks: switch to the improved badblock handling code")
Reverting this patch fixed our tests.
I've also dug into the code a bit and I believe the algorithm for
badblocks_check() is broken (not yet sure about the other calls). At the
very least I see the bb->p pointer being indexed with '-1'. :-(
I did notice that this work was due to a bug report in badblock_set().
Therefore, I'm not sure of that severity of that fix is vs a revert. But
at this point I'm not seeing an easy fix so I'm in favor of a revert.
Thanks,
Ira
next reply other threads:[~2023-12-22 18:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 18:31 Ira Weiny [this message]
2023-12-22 18:57 ` Bug in commit aa511ff8218b ("badblocks: switch to the improved badblock handling Ira Weiny
2023-12-23 0:24 ` Ira Weiny
2023-12-23 9:39 ` Coly Li
2023-12-23 17:13 ` Ira Weiny
2023-12-24 0:18 ` Coly Li
2023-12-23 6:52 ` Coly Li
2023-12-23 8:35 ` Linux regression tracking #adding (Thorsten Leemhuis)
2024-01-07 8:48 ` Linux regression tracking #update (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6585d5fda5183_9f731294b9@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=dan.j.williams@intel.com \
--cc=geliang.tang@suse.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).