From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
Cc: "x86@kernel.org" <x86@kernel.org>,
"keescook@chromium.org" <keescook@chromium.org>,
"linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
"luto@kernel.org" <luto@kernel.org>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"debug@rivosinc.com" <debug@rivosinc.com>,
"io-uring@vger.kernel.org" <io-uring@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"christophe.leroy@csgroup.eu" <christophe.leroy@csgroup.eu>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"bp@alien8.de" <bp@alien8.de>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"broonie@kernel.org" <broonie@kernel.org>
Subject: Re: [PATCH] mm: Remove mm argument from mm_get_unmapped_area()
Date: Tue, 7 May 2024 12:06:05 -0400 [thread overview]
Message-ID: <6luuf6tsdsrydtgzqpdggpsyyw7z4vcsv3q7gcvo5yufnrms5u@7we4w2mkhbcm> (raw)
In-Reply-To: <8811ab073c9d1f0c1dfdb04ae193e091839b4682.camel@intel.com>
* Edgecombe, Rick P <rick.p.edgecombe@intel.com> [240507 09:51]:
> On Mon, 2024-05-06 at 12:32 -0400, Liam R. Howlett wrote:
> >
> > I like this patch.
>
> Thanks for taking a look.
>
> >
> > I think the context of current->mm is implied. IOW, could we call it
> > get_unmapped_area() instead? There are other functions today that use
> > current->mm that don't start with current_<whatever>. I probably should
> > have responded to Dan's suggestion with my comment.
>
> Yes, get_unmapped_area() is already taken. What else to call it... It is kind of
> the process "default" get_unmapped_area(). But with Christoph's proposal it
> would basically be arch_get_unmapped_area().
unmapped_area(), but that's also taken..
arch_get_unmapped_area() are all quite close. If you look into it, many
of the arch versions were taken from the sparc 32 version. Subsequent
changes were made and they are no longer exactly the same, but I believe
functionally equivalent - rather tricky to test though.
I wanted to unite these to simplify the mm code a while back, but have
not gotten back to it. One aspect that some archs have is "cache
coloring" which does affect the VMAs.
The other difference is VDSO, which I may be looking into soon. Someone
once called me a glutton for punishment and there may be some truth in
that...
Cheers,
Liam
next prev parent reply other threads:[~2024-05-07 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 16:07 [PATCH] mm: Remove mm argument from mm_get_unmapped_area() Rick Edgecombe
2024-05-06 16:18 ` Christoph Hellwig
2024-05-07 13:51 ` Edgecombe, Rick P
2024-05-06 16:32 ` Liam R. Howlett
2024-05-07 13:51 ` Edgecombe, Rick P
2024-05-07 16:06 ` Liam R. Howlett [this message]
2024-05-07 22:38 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6luuf6tsdsrydtgzqpdggpsyyw7z4vcsv3q7gcvo5yufnrms5u@7we4w2mkhbcm \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=broonie@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=debug@rivosinc.com \
--cc=hpa@zytor.com \
--cc=io-uring@vger.kernel.org \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=nvdimm@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).