From: Alistair Popple <apopple@nvidia.com>
To: David Hildenbrand <david@redhat.com>
Cc: linux-mm@kvack.org, david@fromorbit.com,
dan.j.williams@intel.com, jhubbard@nvidia.com,
rcampbell@nvidia.com, willy@infradead.org, jgg@nvidia.com,
linux-fsdevel@vger.kernel.org, jack@suse.cz, djwong@kernel.org,
hch@lst.de, ruansy.fnst@fujitsu.com, nvdimm@lists.linux.dev,
linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
jglisse@redhat.com
Subject: Re: [RFC 01/10] mm/gup.c: Remove redundant check for PCI P2PDMA page
Date: Fri, 12 Apr 2024 11:37:00 +1000 [thread overview]
Message-ID: <87o7af5pj9.fsf@nvdebian.thelocal> (raw)
In-Reply-To: <f3b38a24-d252-49ea-88ea-ac12fab3c121@redhat.com>
David Hildenbrand <david@redhat.com> writes:
> On 11.04.24 02:57, Alistair Popple wrote:
>> PCI P2PDMA pages are not mapped with pXX_devmap PTEs therefore the
>> check in __gup_device_huge() is redundant. Remove it
>> Signed-off-by: Alistair Popple <apopple@nvidia.com>
>> ---
>> mm/gup.c | 5 -----
>> 1 file changed, 5 deletions(-)
>> diff --git a/mm/gup.c b/mm/gup.c
>> index 2f8a2d8..a9c8a09 100644
>> --- a/mm/gup.c
>> +++ b/mm/gup.c
>> @@ -2683,11 +2683,6 @@ static int __gup_device_huge(unsigned long pfn, unsigned long addr,
>> break;
>> }
>> - if (!(flags & FOLL_PCI_P2PDMA) &&
>> is_pci_p2pdma_page(page)) {
>> - undo_dev_pagemap(nr, nr_start, flags, pages);
>> - break;
>> - }
>> -
>> SetPageReferenced(page);
>> pages[*nr] = page;
>> if (unlikely(try_grab_page(page, flags))) {
>
> Rebasing on mm-unstable, you'll notice some minor conflicts, but
> nothing earth shattering :)
Thanks. Rebasing was the other thing I meant to add as a TODO in the
cover letter :)
> Acked-by: David Hildenbrand <david@redhat.com>
next prev parent reply other threads:[~2024-04-12 1:38 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 0:57 [RFC 00/10] fs/dax: Fix FS DAX page reference counts Alistair Popple
2024-04-11 0:57 ` [RFC 01/10] mm/gup.c: Remove redundant check for PCI P2PDMA page Alistair Popple
2024-04-11 12:59 ` Jason Gunthorpe
2024-04-11 13:47 ` David Hildenbrand
2024-04-12 1:37 ` Alistair Popple [this message]
2024-04-11 0:57 ` [RFC 02/10] mm/hmm: Remove dead check for HugeTLB and FS DAX Alistair Popple
2024-04-11 12:25 ` Jason Gunthorpe
2024-04-11 13:37 ` Peter Xu
2024-04-12 1:28 ` Alistair Popple
2024-04-11 0:57 ` [RFC 03/10] pci/p2pdma: Don't initialise page refcount to one Alistair Popple
2024-04-11 12:29 ` Jason Gunthorpe
2024-04-12 5:40 ` Alistair Popple
2024-04-12 17:20 ` Dan Williams
2024-05-09 21:59 ` Logan Gunthorpe
2024-05-09 23:14 ` Alistair Popple
2024-04-11 0:57 ` [RFC 04/10] fs/dax: Don't track page mapping/index Alistair Popple
2024-04-12 15:22 ` Jan Kara
2024-04-12 17:31 ` Dan Williams
2024-04-15 7:03 ` Alistair Popple
2024-04-15 20:51 ` Dan Williams
2024-04-16 0:07 ` Alistair Popple
2024-04-16 0:36 ` Dan Williams
2024-04-12 17:21 ` Dan Williams
2024-04-11 0:57 ` [RFC 05/10] fs/dax: Refactor wait for dax idle page Alistair Popple
2024-04-12 14:37 ` Jan Kara
2024-04-13 20:19 ` John Hubbard
2024-04-15 8:41 ` Alistair Popple
2024-04-11 0:57 ` [RFC 06/10] fs/dax: Add dax_page_free callback Alistair Popple
2024-04-11 0:57 ` [RFC 07/10] mm: Allow compound zone device pages Alistair Popple
2024-04-11 12:32 ` Jason Gunthorpe
2024-04-11 14:10 ` Matthew Wilcox
2024-04-12 1:38 ` Alistair Popple
2024-04-11 0:57 ` [RFC 08/10] fs/dax: Properly refcount fs dax pages Alistair Popple
2024-04-11 0:57 ` [RFC 09/10] mm/khugepage.c: Warn if trying to scan devmap pmd Alistair Popple
2024-04-11 13:45 ` David Hildenbrand
2024-04-12 1:34 ` Alistair Popple
2024-04-11 0:57 ` [RFC 10/10] mm: Remove pXX_devmap Alistair Popple
2024-04-11 12:57 ` Jason Gunthorpe
2024-04-11 17:28 ` [RFC 00/10] fs/dax: Fix FS DAX page reference counts Dan Williams
2024-04-11 17:35 ` Jason Gunthorpe
2024-04-11 17:56 ` Dan Williams
2024-04-12 3:54 ` Alistair Popple
2024-04-12 6:55 ` Alistair Popple
2024-04-12 11:53 ` Jason Gunthorpe
2024-04-12 17:32 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7af5pj9.fsf@nvdebian.thelocal \
--to=apopple@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=david@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jgg@nvidia.com \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=rcampbell@nvidia.com \
--cc=ruansy.fnst@fujitsu.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).