From: Dave Jiang <dave.jiang@intel.com>
To: alison.schofield@intel.com, Vishal Verma <vishal.l.verma@intel.com>
Cc: nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org
Subject: Re: [ndctl PATCH v7 7/7] cxl/test: add cxl-poison.sh unit test
Date: Thu, 8 Feb 2024 11:18:01 -0700 [thread overview]
Message-ID: <9aa5564b-d649-4fcc-aaba-a39851accb9c@intel.com> (raw)
In-Reply-To: <855025e88e0c261ae36dd6bd70443ebd9e7e5e6f.1707351560.git.alison.schofield@intel.com>
On 2/7/24 6:01 PM, alison.schofield@intel.com wrote:
> From: Alison Schofield <alison.schofield@intel.com>
>
> Exercise cxl list, libcxl, and driver pieces of the get poison list
> pathway. Inject and clear poison using debugfs and use cxl-cli to
> read the poison list by memdev and by region.
>
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Should circle back and use CXL CLI enabled poison injection/clear when that's available.
> ---
> test/cxl-poison.sh | 137 +++++++++++++++++++++++++++++++++++++++++++++
> test/meson.build | 2 +
> 2 files changed, 139 insertions(+)
> create mode 100644 test/cxl-poison.sh
>
> diff --git a/test/cxl-poison.sh b/test/cxl-poison.sh
> new file mode 100644
> index 000000000000..6fceb0f2c360
> --- /dev/null
> +++ b/test/cxl-poison.sh
> @@ -0,0 +1,137 @@
> +#!/bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (C) 2023 Intel Corporation. All rights reserved.
> +
> +. "$(dirname "$0")"/common
> +
> +rc=77
> +
> +set -ex
> +
> +trap 'err $LINENO' ERR
> +
> +check_prereq "jq"
> +
> +modprobe -r cxl_test
> +modprobe cxl_test
> +
> +rc=1
> +
> +# THEORY OF OPERATION: Exercise cxl-cli and cxl driver ability to
> +# inject, clear, and get the poison list. Do it by memdev and by region.
> +
> +find_memdev()
> +{
> + readarray -t capable_mems < <("$CXL" list -b "$CXL_TEST_BUS" -M |
> + jq -r ".[] | select(.pmem_size != null) |
> + select(.ram_size != null) | .memdev")
> +
> + if [ ${#capable_mems[@]} == 0 ]; then
> + echo "no memdevs found for test"
> + err "$LINENO"
> + fi
> +
> + memdev=${capable_mems[0]}
> +}
> +
> +create_x2_region()
> +{
> + # Find an x2 decoder
> + decoder="$($CXL list -b "$CXL_TEST_BUS" -D -d root | jq -r ".[] |
> + select(.pmem_capable == true) |
> + select(.nr_targets == 2) |
> + .decoder")"
> +
> + # Find a memdev for each host-bridge interleave position
> + port_dev0="$($CXL list -T -d "$decoder" | jq -r ".[] |
> + .targets | .[] | select(.position == 0) | .target")"
> + port_dev1="$($CXL list -T -d "$decoder" | jq -r ".[] |
> + .targets | .[] | select(.position == 1) | .target")"
> + mem0="$($CXL list -M -p "$port_dev0" | jq -r ".[0].memdev")"
> + mem1="$($CXL list -M -p "$port_dev1" | jq -r ".[0].memdev")"
> +
> + region="$($CXL create-region -d "$decoder" -m "$mem0" "$mem1" |
> + jq -r ".region")"
> + if [[ ! $region ]]; then
> + echo "create-region failed for $decoder"
> + err "$LINENO"
> + fi
> + echo "$region"
> +}
> +
> +# When cxl-cli support for inject and clear arrives, replace
> +# the writes to /sys/kernel/debug with the new cxl commands.
> +
> +inject_poison_sysfs()
> +{
> + memdev="$1"
> + addr="$2"
> +
> + echo "$addr" > /sys/kernel/debug/cxl/"$memdev"/inject_poison
> +}
> +
> +clear_poison_sysfs()
> +{
> + memdev="$1"
> + addr="$2"
> +
> + echo "$addr" > /sys/kernel/debug/cxl/"$memdev"/clear_poison
> +}
> +
> +validate_poison_found()
> +{
> + list_by="$1"
> + nr_expect="$2"
> +
> + poison_list="$($CXL list "$list_by" --media-errors |
> + jq -r '.[].media_errors')"
> + if [[ ! $poison_list ]]; then
> + nr_found=0
> + else
> + nr_found=$(jq "length" <<< "$poison_list")
> + fi
> + if [ "$nr_found" -ne "$nr_expect" ]; then
> + echo "$nr_expect poison records expected, $nr_found found"
> + err "$LINENO"
> + fi
> +}
> +
> +test_poison_by_memdev()
> +{
> + find_memdev
> + inject_poison_sysfs "$memdev" "0x40000000"
> + inject_poison_sysfs "$memdev" "0x40001000"
> + inject_poison_sysfs "$memdev" "0x600"
> + inject_poison_sysfs "$memdev" "0x0"
> + validate_poison_found "-m $memdev" 4
> +
> + clear_poison_sysfs "$memdev" "0x40000000"
> + clear_poison_sysfs "$memdev" "0x40001000"
> + clear_poison_sysfs "$memdev" "0x600"
> + clear_poison_sysfs "$memdev" "0x0"
> + validate_poison_found "-m $memdev" 0
> +}
> +
> +test_poison_by_region()
> +{
> + create_x2_region
> + inject_poison_sysfs "$mem0" "0x40000000"
> + inject_poison_sysfs "$mem1" "0x40000000"
> + validate_poison_found "-r $region" 2
> +
> + clear_poison_sysfs "$mem0" "0x40000000"
> + clear_poison_sysfs "$mem1" "0x40000000"
> + validate_poison_found "-r $region" 0
> +}
> +
> +# Turn tracing on. Note that 'cxl list --poison' does toggle the tracing.
> +# Turning it on here allows the test user to also view inject and clear
> +# trace events.
> +echo 1 > /sys/kernel/tracing/events/cxl/cxl_poison/enable
> +
> +test_poison_by_memdev
> +test_poison_by_region
> +
> +check_dmesg "$LINENO"
> +
> +modprobe -r cxl-test
> diff --git a/test/meson.build b/test/meson.build
> index 224adaf41fcc..2706fa5d633c 100644
> --- a/test/meson.build
> +++ b/test/meson.build
> @@ -157,6 +157,7 @@ cxl_create_region = find_program('cxl-create-region.sh')
> cxl_xor_region = find_program('cxl-xor-region.sh')
> cxl_update_firmware = find_program('cxl-update-firmware.sh')
> cxl_events = find_program('cxl-events.sh')
> +cxl_poison = find_program('cxl-poison.sh')
>
> tests = [
> [ 'libndctl', libndctl, 'ndctl' ],
> @@ -186,6 +187,7 @@ tests = [
> [ 'cxl-create-region.sh', cxl_create_region, 'cxl' ],
> [ 'cxl-xor-region.sh', cxl_xor_region, 'cxl' ],
> [ 'cxl-events.sh', cxl_events, 'cxl' ],
> + [ 'cxl-poison.sh', cxl_poison, 'cxl' ],
> ]
>
> if get_option('destructive').enabled()
next prev parent reply other threads:[~2024-02-08 18:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 1:01 [ndctl PATCH v7 0/7] Support poison list retrieval alison.schofield
2024-02-08 1:01 ` [ndctl PATCH v7 1/7] libcxl: add interfaces for GET_POISON_LIST mailbox commands alison.schofield
2024-02-08 1:01 ` [ndctl PATCH v7 2/7] cxl: add an optional pid check to event parsing alison.schofield
2024-02-08 1:01 ` [ndctl PATCH v7 3/7] cxl/event_trace: add a private context for private parsers alison.schofield
2024-02-08 1:01 ` [ndctl PATCH v7 4/7] cxl/event_trace: add helpers get_field_[string|data]() alison.schofield
2024-02-08 1:01 ` [ndctl PATCH v7 5/7] cxl/list: collect and parse media_error records alison.schofield
2024-02-08 16:50 ` Dave Jiang
2024-02-29 2:45 ` Alison Schofield
2024-02-08 1:01 ` [ndctl PATCH v7 6/7] cxl/list: add --media-errors option to cxl list alison.schofield
2024-02-08 16:51 ` Dave Jiang
2024-02-08 1:01 ` [ndctl PATCH v7 7/7] cxl/test: add cxl-poison.sh unit test alison.schofield
2024-02-08 18:18 ` Dave Jiang [this message]
2024-02-22 8:04 ` Verma, Vishal L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9aa5564b-d649-4fcc-aaba-a39851accb9c@intel.com \
--to=dave.jiang@intel.com \
--cc=alison.schofield@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).