From: Yi Zhang <yi.zhang@redhat.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: nvdimm@lists.linux.dev
Subject: Re: [patch] ndctl: test/daxctl-devices.sh: increase the namespace size
Date: Mon, 27 Nov 2023 17:28:37 +0800 [thread overview]
Message-ID: <CAHj4cs_fgf-tjx9z_W9t2hnN3sufuCphbTKjgqJ9EpoMEkQzYw@mail.gmail.com> (raw)
In-Reply-To: <x49fs1hwk0b.fsf@segfault.usersys.redhat.com>
On Wed, Nov 8, 2023 at 1:34 AM Jeff Moyer <jmoyer@redhat.com> wrote:
>
> Memory hotplug requires the namespace to be aligned to a boundary that
> depends on several factors. Upstream kernel commit fe124c95df9e
> ("x86/mm: use max memory block size on bare metal") increased the
> typical size/alignment to 2GiB from 256MiB. As a result, this test no
> longer passes on our bare metal test systems.
>
> This patch fixes the test failure by bumping the namespace size to
> 4GiB, which leaves room for aligning the start and end to 2GiB.
>
> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Thanks Jeff
Tested-by: Yi Zhang <yi.zhang@redhat.com>
>
> diff --git a/test/daxctl-devices.sh b/test/daxctl-devices.sh
> index 56c9691..dfce74b 100755
> --- a/test/daxctl-devices.sh
> +++ b/test/daxctl-devices.sh
> @@ -44,7 +44,10 @@ setup_dev()
> test -n "$testdev"
>
> "$NDCTL" destroy-namespace -f -b "$testbus" "$testdev"
> - testdev=$("$NDCTL" create-namespace -b "$testbus" -m devdax -fe "$testdev" -s 256M | \
> + # x86_64 memory hotplug can require up to a 2GiB-aligned chunk
> + # of memory. Create a 4GiB namespace, so that we will still have
> + # enough room left after aligning the start and end.
> + testdev=$("$NDCTL" create-namespace -b "$testbus" -m devdax -fe "$testdev" -s 4G | \
> jq -er '.dev')
> test -n "$testdev"
> }
>
>
--
Best Regards,
Yi Zhang
prev parent reply other threads:[~2023-11-27 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 17:28 [patch] ndctl: test/daxctl-devices.sh: increase the namespace size Jeff Moyer
2023-11-07 18:01 ` Jeff Moyer
2023-11-13 15:06 ` Dave Jiang
2023-11-27 9:28 ` Yi Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHj4cs_fgf-tjx9z_W9t2hnN3sufuCphbTKjgqJ9EpoMEkQzYw@mail.gmail.com \
--to=yi.zhang@redhat.com \
--cc=jmoyer@redhat.com \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).