From: Matthew Wilcox <willy@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Xueshi Hu <xueshi.hu@smartx.com>,
dan.j.williams@intel.com, vishal.l.verma@intel.com,
dave.jiang@intel.com, jayalk@intworks.biz, daniel@ffwll.ch,
deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk,
brauner@kernel.org, jack@suse.com, tytso@mit.edu,
adilger.kernel@dilger.ca, miklos@szeredi.hu,
mike.kravetz@oracle.com, muchun.song@linux.dev,
djwong@kernel.org, akpm@linux-foundation.org, hughd@google.com,
nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-aio@kvack.org,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-mm@kvack.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] fs: clean up usage of noop_dirty_folio
Date: Mon, 21 Aug 2023 13:20:33 +0100 [thread overview]
Message-ID: <ZONWka8NpDVGzI8h@casper.infradead.org> (raw)
In-Reply-To: <20230821111643.5vxtktznjqk42cak@quack3>
On Mon, Aug 21, 2023 at 01:16:43PM +0200, Jan Kara wrote:
> On Sat 19-08-23 20:42:25, Xueshi Hu wrote:
> > In folio_mark_dirty(), it will automatically fallback to
> > noop_dirty_folio() if a_ops->dirty_folio is not registered.
> >
> > As anon_aops, dev_dax_aops and fb_deferred_io_aops becames empty, remove
> > them too.
> >
> > Signed-off-by: Xueshi Hu <xueshi.hu@smartx.com>
>
> Yeah, looks sensible to me but for some callbacks we are oscilating between
> all users having to provide some callback and providing some default
> behavior for NULL callback. I don't have a strong opinion either way so
> feel free to add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
> But I guess let's see what Matthew thinks about this and what plans he has
> so that we don't switch back again in the near future. Matthew?
I was hoping Christoph would weigh in ;-) I don't have a strong
feeling here, but it seems to me that a NULL ->dirty_folio() should mean
"do the noop thing" rather than "do the buffer_head thing" or "do the
filemap thing". In 0af573780b0b, the buffer_head default was removed.
I think enough time has passed that we're OK to change what a NULL
->dirty_folio means (plus we also changed the name of ->set_page_dirty()
to ->dirty_folio())
So Ack to the concept. One minor change I'd request:
-bool noop_dirty_folio(struct address_space *mapping, struct folio *folio)
+static bool noop_dirty_folio(struct address_space *mapping, struct folio *folio)
{
if (!folio_test_dirty(folio))
return !folio_test_set_dirty(folio);
return false;
}
-EXPORT_SYMBOL(noop_dirty_folio);
Please inline this into folio_mark_dirty() instead of calling it.
next prev parent reply other threads:[~2023-08-21 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-19 12:42 [PATCH] fs: clean up usage of noop_dirty_folio Xueshi Hu
2023-08-21 11:16 ` Jan Kara
2023-08-21 12:20 ` Matthew Wilcox [this message]
2023-08-28 6:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZONWka8NpDVGzI8h@casper.infradead.org \
--to=willy@infradead.org \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=brauner@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=daniel@ffwll.ch \
--cc=dave.jiang@intel.com \
--cc=deller@gmx.de \
--cc=djwong@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hughd@google.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=jayalk@intworks.biz \
--cc=linux-aio@kvack.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=miklos@szeredi.hu \
--cc=muchun.song@linux.dev \
--cc=nvdimm@lists.linux.dev \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=vishal.l.verma@intel.com \
--cc=xueshi.hu@smartx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).