From: Alison Schofield <alison.schofield@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev
Subject: Re: [PATCH] tools/testing/nvdimm: Disable "missing prototypes / declarations" warnings
Date: Tue, 16 Jan 2024 21:24:12 -0800 [thread overview]
Message-ID: <ZadkfMw2hnZlRMdg@aschofie-mobl2> (raw)
In-Reply-To: <170543984331.460832.1780246477583036191.stgit@dwillia2-xfh.jf.intel.com>
On Tue, Jan 16, 2024 at 01:17:23PM -0800, Dan Williams wrote:
> Prevent warnings of the form:
>
> tools/testing/nvdimm/config_check.c:4:6: error: no previous prototype
> for ‘check’ [-Werror=missing-prototypes]
>
> ...by locally disabling some warnings.
>
> It turns out that:
>
> Commit 0fcb70851fbf ("Makefile.extrawarn: turn on missing-prototypes globally")
>
> ...in addition to expanding in-tree coverage, also impacts out-of-tree
> module builds like those in tools/testing/nvdimm/.
>
> Filter out the warning options on unit test code that does not effect
> mainline builds.
>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
> ---
> tools/testing/nvdimm/Kbuild | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/nvdimm/Kbuild b/tools/testing/nvdimm/Kbuild
> index 8153251ea389..91a3627f301a 100644
> --- a/tools/testing/nvdimm/Kbuild
> +++ b/tools/testing/nvdimm/Kbuild
> @@ -82,4 +82,6 @@ libnvdimm-$(CONFIG_NVDIMM_KEYS) += $(NVDIMM_SRC)/security.o
> libnvdimm-y += libnvdimm_test.o
> libnvdimm-y += config_check.o
>
> +KBUILD_CFLAGS := $(filter-out -Wmissing-prototypes -Wmissing-declarations, $(KBUILD_CFLAGS))
> +
> obj-m += test/
>
>
prev parent reply other threads:[~2024-01-17 5:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 21:17 [PATCH] tools/testing/nvdimm: Disable "missing prototypes / declarations" warnings Dan Williams
2024-01-17 5:24 ` Alison Schofield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZadkfMw2hnZlRMdg@aschofie-mobl2 \
--to=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).