NVDIMM Device and Persistent Memory development
 help / color / mirror / Atom feed
From: Dave Jiang <dave.jiang@intel.com>
To: Ira Weiny <ira.weiny@intel.com>, Vishal Verma <vishal.l.verma@intel.com>
Cc: <linux-cxl@vger.kernel.org>, <nvdimm@lists.linux.dev>
Subject: Re: [PATCH ndctl RESEND] test/cxl-event: Skip cxl event testing if cxl-test is not available
Date: Mon, 25 Sep 2023 15:37:27 -0700	[thread overview]
Message-ID: <a2f7c266-6bfe-d7c3-f0b0-f926ded6925a@intel.com> (raw)
In-Reply-To: <20230925-skip-cxl-events-v1-1-bdad7cceb80b@intel.com>



On 9/25/23 15:16, Ira Weiny wrote:
> CXL event testing is only appropriate when the cxl-test modules are
> available.
> 
> Return error 77 (skip) if cxl-test modules are not available.
> 
> Reported-by: Dave Jiang <dave.jiang@intel.com>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> Changes for resend:
> - iweiny: properly cc the mailing lists
> ---
>  test/cxl-events.sh | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/test/cxl-events.sh b/test/cxl-events.sh
> index 33b68daa6ade..fe702bf98ad4 100644
> --- a/test/cxl-events.sh
> +++ b/test/cxl-events.sh
> @@ -10,6 +10,8 @@ num_fatal_expected=2
>  num_failure_expected=16
>  num_info_expected=3
>  
> +rc=77
> +
>  set -ex
>  
>  trap 'err $LINENO' ERR
> @@ -18,6 +20,7 @@ check_prereq "jq"
>  
>  modprobe -r cxl_test
>  modprobe cxl_test
> +rc=1
>  
>  dev_path="/sys/bus/platform/devices"
>  
> 
> ---
> base-commit: a871e6153b11fe63780b37cdcb1eb347b296095c
> change-id: 20230925-skip-cxl-events-7f16052b9c4e
> 
> Best regards,

      reply	other threads:[~2023-09-25 22:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-25 22:16 [PATCH ndctl RESEND] test/cxl-event: Skip cxl event testing if cxl-test is not available Ira Weiny
2023-09-25 22:37 ` Dave Jiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2f7c266-6bfe-d7c3-f0b0-f926ded6925a@intel.com \
    --to=dave.jiang@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).