From: Dave Jiang <dave.jiang@intel.com>
To: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>,
<dan.j.williams@intel.com>
Cc: <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
<nvdimm@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<yusongping@huawei.com>, <artem.kuzin@huawei.com>
Subject: Re: [PATCH] drivers: nvdimm: fix memleak
Date: Thu, 17 Aug 2023 09:00:50 -0700 [thread overview]
Message-ID: <a5d425b0-9a23-e58a-52aa-db380234dc30@intel.com> (raw)
In-Reply-To: <20230817115945.771826-1-konstantin.meskhidze@huawei.com>
On 8/17/23 04:59, Konstantin Meskhidze wrote:
> Memory pointed by 'nd_pmu->pmu.attr_groups' is allocated in function
> 'register_nvdimm_pmu' and is lost after 'kfree(nd_pmu)' call in function
> 'unregister_nvdimm_pmu'.
>
> Co-developed-by: Ivanov Mikhail <ivanov.mikhail1@huawei-partners.com>
> Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
Applied and changed subject to:
nvdimm: Fix memleak of pmu attr_groups in unregister_nvdimm_pmu()
Also added fixes tag:
Fixes: 0fab1ba6ad6b ("drivers/nvdimm: Add perf interface to expose
nvdimm performance stats")
> ---
> drivers/nvdimm/nd_perf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/nvdimm/nd_perf.c b/drivers/nvdimm/nd_perf.c
> index 433bbb68a..14881c4e0 100644
> --- a/drivers/nvdimm/nd_perf.c
> +++ b/drivers/nvdimm/nd_perf.c
> @@ -323,7 +323,8 @@ EXPORT_SYMBOL_GPL(register_nvdimm_pmu);
> void unregister_nvdimm_pmu(struct nvdimm_pmu *nd_pmu)
> {
> perf_pmu_unregister(&nd_pmu->pmu);
> nvdimm_pmu_free_hotplug_memory(nd_pmu);
> + kfree(nd_pmu->pmu.attr_groups);
> kfree(nd_pmu);
> }
> EXPORT_SYMBOL_GPL(unregister_nvdimm_pmu);
prev parent reply other threads:[~2023-08-17 16:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 11:59 [PATCH] drivers: nvdimm: fix memleak Konstantin Meskhidze
2023-08-17 14:32 ` Jeff Moyer
2023-08-17 15:06 ` Dan Williams
2023-08-17 16:00 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5d425b0-9a23-e58a-52aa-db380234dc30@intel.com \
--to=dave.jiang@intel.com \
--cc=artem.kuzin@huawei.com \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=konstantin.meskhidze@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
--cc=yusongping@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).