From: Dave Jiang <dave.jiang@intel.com>
To: Ira Weiny <ira.weiny@intel.com>, Vishal Verma <vishal.l.verma@intel.com>
Cc: <linux-cxl@vger.kernel.org>, <nvdimm@lists.linux.dev>
Subject: Re: [PATCH ndctl] ndctl/cxl/region: Report max size for region creation
Date: Wed, 27 Sep 2023 07:39:53 -0700 [thread overview]
Message-ID: <b0714f5a-2969-38dc-42c8-f151c1111d5b@intel.com> (raw)
In-Reply-To: <20230926-max-size-create-region-v1-1-d3555e91087c@intel.com>
On 9/26/23 17:24, Ira Weiny wrote:
> When creating a region if the size exceeds the max an error is printed.
> However, the max available space is not reported which makes it harder
> to determine what is wrong.
>
> Add the max size available to the output error.
>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> cxl/region.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/cxl/region.c b/cxl/region.c
> index bcd703956207..cb6a547990fb 100644
> --- a/cxl/region.c
> +++ b/cxl/region.c
> @@ -623,8 +623,8 @@ static int create_region(struct cxl_ctx *ctx, int *count,
> }
> if (!default_size && size > max_extent) {
> log_err(&rl,
> - "%s: region size %#lx exceeds max available space\n",
> - cxl_decoder_get_devname(p->root_decoder), size);
> + "%s: region size %#lx exceeds max available space (%#lx)\n",
> + cxl_decoder_get_devname(p->root_decoder), size, max_extent);
> return -ENOSPC;
> }
>
>
> ---
> base-commit: a871e6153b11fe63780b37cdcb1eb347b296095c
> change-id: 20230926-max-size-create-region-1f57ff3bc53c
>
> Best regards,
prev parent reply other threads:[~2023-09-27 14:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 0:24 [PATCH ndctl] ndctl/cxl/region: Report max size for region creation Ira Weiny
2023-09-27 14:39 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0714f5a-2969-38dc-42c8-f151c1111d5b@intel.com \
--to=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).