From: alison.schofield@intel.com
To: Vishal Verma <vishal.l.verma@intel.com>
Cc: Alison Schofield <alison.schofield@intel.com>,
nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org
Subject: [ndctl PATCH v2 4/5] cxl/list: add --poison option to cxl list
Date: Sun, 1 Oct 2023 15:31:34 -0700 [thread overview]
Message-ID: <e341f21fb51826335360a0d54538f4b6814537dc.1696196382.git.alison.schofield@intel.com> (raw)
In-Reply-To: <cover.1696196382.git.alison.schofield@intel.com>
From: Alison Schofield <alison.schofield@intel.com>
The --poison option to 'cxl list' retrieves poison lists from
memory devices supporting the capability and displays the
returned poison records in the cxl list json. This option can
apply to memdevs or regions.
Example usage in the Documentation/cxl/cxl-list.txt update.
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
---
Documentation/cxl/cxl-list.txt | 64 ++++++++++++++++++++++++++++++++++
cxl/filter.h | 3 ++
cxl/list.c | 2 ++
3 files changed, 69 insertions(+)
diff --git a/Documentation/cxl/cxl-list.txt b/Documentation/cxl/cxl-list.txt
index 838de4086678..2a4a8fe2efaa 100644
--- a/Documentation/cxl/cxl-list.txt
+++ b/Documentation/cxl/cxl-list.txt
@@ -415,6 +415,70 @@ OPTIONS
--region::
Specify CXL region device name(s), or device id(s), to filter the listing.
+-L::
+--poison::
+ Include poison information. The poison list is retrieved from the
+ device(s) and poison records are added to the listing. Apply this
+ option to memdevs and regions where devices support the poison
+ list capability.
+
+----
+# cxl list -m mem11 --poison
+[
+ {
+ "memdev":"mem11",
+ "pmem_size":268435456,
+ "ram_size":0,
+ "serial":0,
+ "host":"0000:37:00.0",
+ "poison":{
+ "nr_poison_records":1,
+ "poison_records":[
+ {
+ "dpa":0,
+ "dpa_length":64,
+ "source":"Internal",
+ "flags":"",
+ "overflow_time":0
+ }
+ ]
+ }
+ }
+]
+# cxl list -r region5 --poison
+[
+ {
+ "region":"region5",
+ "resource":1035623989248,
+ "size":2147483648,
+ "interleave_ways":2,
+ "interleave_granularity":4096,
+ "decode_state":"commit",
+ "poison":{
+ "nr_poison_records":2,
+ "poison_records":[
+ {
+ "memdev":"mem2",
+ "dpa":0,
+ "dpa_length":64,
+ "source":"Internal",
+ "flags":"",
+ "overflow_time":0
+ },
+ {
+ "memdev":"mem5",
+ "dpa":0,
+ "length":512,
+ "source":"Vendor",
+ "flags":"",
+ "overflow_time":0
+ }
+ ]
+ }
+ }
+]
+----
+
-v::
--verbose::
Increase verbosity of the output. This can be specified
diff --git a/cxl/filter.h b/cxl/filter.h
index 3f65990f835a..f38470e39543 100644
--- a/cxl/filter.h
+++ b/cxl/filter.h
@@ -30,6 +30,7 @@ struct cxl_filter_params {
bool fw;
bool alert_config;
bool dax;
+ bool poison;
int verbose;
struct log_ctx ctx;
};
@@ -88,6 +89,8 @@ static inline unsigned long cxl_filter_to_flags(struct cxl_filter_params *param)
flags |= UTIL_JSON_ALERT_CONFIG;
if (param->dax)
flags |= UTIL_JSON_DAX | UTIL_JSON_DAX_DEVS;
+ if (param->poison)
+ flags |= UTIL_JSON_POISON_LIST;
return flags;
}
diff --git a/cxl/list.c b/cxl/list.c
index 93ba51ef895c..13fef8569340 100644
--- a/cxl/list.c
+++ b/cxl/list.c
@@ -57,6 +57,8 @@ static const struct option options[] = {
"include memory device firmware information"),
OPT_BOOLEAN('A', "alert-config", ¶m.alert_config,
"include alert configuration information"),
+ OPT_BOOLEAN('L', "poison", ¶m.poison,
+ "include poison information "),
OPT_INCR('v', "verbose", ¶m.verbose, "increase output detail"),
#ifdef ENABLE_DEBUG
OPT_BOOLEAN(0, "debug", &debug, "debug list walk"),
--
2.37.3
next prev parent reply other threads:[~2023-10-01 22:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-01 22:31 [ndctl PATCH v2 0/3] Support poison list retrieval alison.schofield
2023-10-01 22:31 ` [ndctl PATCH v2 1/5] libcxl: add interfaces for GET_POISON_LIST mailbox commands alison.schofield
2023-11-15 10:08 ` Verma, Vishal L
2023-11-17 16:21 ` Alison Schofield
2023-10-01 22:31 ` [ndctl PATCH v2 2/5] cxl: add an optional pid check to event parsing alison.schofield
2023-10-01 22:31 ` [ndctl PATCH v2 3/5] cxl/list: collect and parse the poison list records alison.schofield
2023-11-15 10:09 ` Verma, Vishal L
2023-11-17 16:44 ` Alison Schofield
2023-10-01 22:31 ` alison.schofield [this message]
2023-10-01 22:31 ` [ndctl PATCH v2 5/5] cxl/test: add cxl-poison.sh unit test alison.schofield
2023-11-15 10:13 ` Verma, Vishal L
2023-11-17 16:52 ` Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e341f21fb51826335360a0d54538f4b6814537dc.1696196382.git.alison.schofield@intel.com \
--to=alison.schofield@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).