From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Jiang, Dave" <dave.jiang@intel.com>,
"Schofield, Alison" <alison.schofield@intel.com>
Cc: "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>
Subject: Re: [NDCTL PATCH v6 1/4] ndctl: cxl: Add QoS class retrieval for the root decoder
Date: Wed, 7 Feb 2024 20:24:37 +0000 [thread overview]
Message-ID: <e3a64a23308aa70fd680729475cdbddc21bd2c8e.camel@intel.com> (raw)
In-Reply-To: <c24b91df-f94b-4455-9086-2cad26fc3400@intel.com>
On Wed, 2024-02-07 at 13:16 -0700, Dave Jiang wrote:
>
>
> On 2/7/24 1:13 PM, Alison Schofield wrote:
> > On Wed, Feb 07, 2024 at 12:05:17PM -0800, Alison Schofield wrote:
> > > On Wed, Feb 07, 2024 at 10:19:36AM -0700, Dave Jiang wrote:
> > > > Add libcxl API to retrieve the QoS class for the root decoder. Also add
> > > > support to display the QoS class for the root decoder through the 'cxl
> > > > list' command. The qos_class is the QTG ID of the CFMWS window that
> > > > represents the root decoder.
> > > >
> > > > Reviewed-by: Alison Schofield <alison.schofield@intel.com>
> > > > Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> > > > ---
> > >
> > > -snip-
> > >
> > > > @@ -136,6 +136,7 @@ int cmd_list(int argc, const char **argv, struct cxl_ctx *ctx)
> > > > param.regions = true;
> > > > /*fallthrough*/
> > > > case 0:
> > > > + param.qos = true;
> > > > break;
> > > > }
> > >
> > > Add qos to the -vvv explainer in Documentation/cxl/cxl-list.txt
> >
> > My comment is wrong, since it is now an 'always displayed', not a -vvv.
> > Why put it here at all then? I'm confused!
>
> Just remove param.qos entirely?
Yep agree, if it is always there by default, no need for a param.
>
next prev parent reply other threads:[~2024-02-07 20:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 17:19 [NDCTL PATCH v6 0/4] ndctl: Add support of qos_class for CXL CLI Dave Jiang
2024-02-07 17:19 ` [NDCTL PATCH v6 1/4] ndctl: cxl: Add QoS class retrieval for the root decoder Dave Jiang
2024-02-07 20:05 ` Alison Schofield
2024-02-07 20:13 ` Alison Schofield
2024-02-07 20:16 ` Dave Jiang
2024-02-07 20:24 ` Verma, Vishal L [this message]
2024-02-07 17:19 ` [NDCTL PATCH v6 2/4] ndctl: cxl: Add QoS class support for the memory device Dave Jiang
2024-02-07 17:19 ` [NDCTL PATCH v6 3/4] ndctl: cxl: add QoS class check for CXL region creation Dave Jiang
2024-02-07 21:02 ` Verma, Vishal L
2024-02-07 23:32 ` Dave Jiang
2024-02-07 17:19 ` [NDCTL PATCH v6 4/4] ndctl: add test for qos_class in CXL test suite Dave Jiang
2024-02-07 21:05 ` Verma, Vishal L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3a64a23308aa70fd680729475cdbddc21bd2c8e.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=alison.schofield@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).