From: David Hildenbrand <david@redhat.com>
To: Vishal Verma <vishal.l.verma@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Oscar Salvador <osalvador@suse.de>,
Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org,
Huang Ying <ying.huang@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Michal Hocko <mhocko@suse.com>,
Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
Jeff Moyer <jmoyer@redhat.com>
Subject: Re: [PATCH v4 1/2] mm/memory_hotplug: split memmap_on_memory requests across memblocks
Date: Mon, 2 Oct 2023 11:28:44 +0200 [thread overview]
Message-ID: <efe2acfd-f22f-f856-cd2a-32374af2053a@redhat.com> (raw)
In-Reply-To: <20230928-vv-kmem_memmap-v4-1-6ff73fec519a@intel.com>
> +
> +static int __ref try_remove_memory(u64 start, u64 size)
> +{
> + int rc, nid = NUMA_NO_NODE;
> +
> + BUG_ON(check_hotplug_memory_range(start, size));
> +
> + /*
> + * All memory blocks must be offlined before removing memory. Check
> + * whether all memory blocks in question are offline and return error
> + * if this is not the case.
> + *
> + * While at it, determine the nid. Note that if we'd have mixed nodes,
> + * we'd only try to offline the last determined one -- which is good
> + * enough for the cases we care about.
> + */
> + rc = walk_memory_blocks(start, size, &nid, check_memblock_offlined_cb);
> + if (rc)
> + return rc;
> +
> + /*
> + * For memmap_on_memory, the altmaps could have been added on
> + * a per-memblock basis. Loop through the entire range if so,
> + * and remove each memblock and its altmap.
> + */
> + if (mhp_memmap_on_memory()) {
> + unsigned long memblock_size = memory_block_size_bytes();
> + u64 cur_start;
> +
> + for (cur_start = start; cur_start < start + size;
> + cur_start += memblock_size)
> + __try_remove_memory(nid, cur_start, memblock_size);
> + } else {
> + __try_remove_memory(nid, start, size);
> + }
> +
> return 0;
> }
Why is the firmware, memblock and nid handling not kept in this outer
function?
We really shouldn't be doing per memory block what needs to be done per
memblock: remove_memory_block_devices() and arch_remove_memory().
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-10-02 9:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 20:30 [PATCH v4 0/2] mm: use memmap_on_memory semantics for dax/kmem Vishal Verma
2023-09-28 20:30 ` [PATCH v4 1/2] mm/memory_hotplug: split memmap_on_memory requests across memblocks Vishal Verma
2023-10-02 9:28 ` David Hildenbrand [this message]
2023-10-03 20:03 ` Verma, Vishal L
2023-10-06 12:33 ` David Hildenbrand
2023-09-28 20:30 ` [PATCH v4 2/2] dax/kmem: allow kmem to add memory with memmap_on_memory Vishal Verma
2023-10-02 9:21 ` David Hildenbrand
2023-10-03 4:04 ` Aneesh Kumar K V
2023-10-03 23:48 ` Verma, Vishal L
2023-10-04 5:12 ` Aneesh Kumar K V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efe2acfd-f22f-f856-cd2a-32374af2053a@redhat.com \
--to=david@redhat.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=jmoyer@redhat.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=nvdimm@lists.linux.dev \
--cc=osalvador@suse.de \
--cc=vishal.l.verma@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).