NVDIMM Device and Persistent Memory development
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@stgolabs.net>
To: Jehoon Park <jehoon.park@samsung.com>
Cc: linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev,
	 Alison Schofield <alison.schofield@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	 Ira Weiny <ira.weiny@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	 Dave Jiang <dave.jiang@intel.com>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	 Kyungsan Kim <ks0204.kim@samsung.com>,
	Junhyeok Im <junhyeok.im@samsung.com>
Subject: Re: [ndctl PATCH v2 1/3] libcxl: Update a revision by CXL 3.0 specification
Date: Thu, 24 Aug 2023 18:45:38 -0700	[thread overview]
Message-ID: <rqppgl33vfd3hprnvqfxnr27iv2mwxnsom27yyttyhowfepiry@yurvfa4bk6jp> (raw)
In-Reply-To: <20230807063549.5942-2-jehoon.park@samsung.com>

On Mon, 07 Aug 2023, Jehoon Park wrote:

>Update the predefined value for device temperature field when it is not
>implemented. (CXL 3.0.8.2.9.8.3.1)
>
>Signed-off-by: Jehoon Park <jehoon.park@samsung.com>

With Jonathan's feedback in the changelog,

Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>

>---
> cxl/lib/private.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/cxl/lib/private.h b/cxl/lib/private.h
>index a641727..a692fd5 100644
>--- a/cxl/lib/private.h
>+++ b/cxl/lib/private.h
>@@ -360,7 +360,7 @@ struct cxl_cmd_set_partition {
> #define CXL_CMD_HEALTH_INFO_EXT_CORRECTED_PERSISTENT_WARNING		(1)
>
> #define CXL_CMD_HEALTH_INFO_LIFE_USED_NOT_IMPL				0xff
>-#define CXL_CMD_HEALTH_INFO_TEMPERATURE_NOT_IMPL			0xffff
>+#define CXL_CMD_HEALTH_INFO_TEMPERATURE_NOT_IMPL			0x7fff
>
> static inline int check_kmod(struct kmod_ctx *kmod_ctx)
> {
>--
>2.17.1
>

  parent reply	other threads:[~2023-08-25  9:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230807063513epcas2p261ba4dfbfff34e99077596128eb6fc48@epcas2p2.samsung.com>
2023-08-07  6:35 ` [ndctl PATCH v2 0/3] Fix accessors for temperature field when it is negative Jehoon Park
     [not found]   ` <CGME20230807063523epcas2p45f74891b764d920b2a9bd22ddf6b6998@epcas2p4.samsung.com>
2023-08-07  6:35     ` [ndctl PATCH v2 1/3] libcxl: Update a revision by CXL 3.0 specification Jehoon Park
2023-08-07 13:02       ` Jonathan Cameron
2023-08-08  7:38         ` Jehoon Park
2023-08-25  1:45       ` Davidlohr Bueso [this message]
     [not found]   ` <CGME20230807063538epcas2p4965d5d117b8ef87ac4217bec53beff95@epcas2p4.samsung.com>
2023-08-07  6:35     ` [ndctl PATCH v2 2/3] libcxl: Fix accessors for temperature field to support negative value Jehoon Park
2023-08-07 13:14       ` Jonathan Cameron
2023-08-08  7:41         ` Jehoon Park
     [not found]   ` <CGME20230807063547epcas2p4ccb33e410e77a94e088f283b8c2925db@epcas2p4.samsung.com>
2023-08-07  6:35     ` [ndctl PATCH v2 3/3] cxl: Fix the checking value when listing device's health info Jehoon Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=rqppgl33vfd3hprnvqfxnr27iv2mwxnsom27yyttyhowfepiry@yurvfa4bk6jp \
    --to=dave@stgolabs.net \
    --cc=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=jehoon.park@samsung.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=junhyeok.im@samsung.com \
    --cc=ks0204.kim@samsung.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).