From: kernel test robot <lkp@intel.com>
To: KaiLong Wang <wangkailong@jari.cn>,
mark@fasheh.com, jlbec@evilplan.org, akpm@linux-foundation.org
Cc: oe-kbuild-all@lists.linux.dev, ocfs2-devel@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ocfs2/dlm: Clean up errors in dlmdomain.c
Date: Tue, 17 Oct 2023 15:12:20 +0800 [thread overview]
Message-ID: <202310171436.cr0GHO3X-lkp@intel.com> (raw)
In-Reply-To: <62e91e34.969.18b27f9ec40.Coremail.wangkailong@jari.cn>
Hi KaiLong,
kernel test robot noticed the following build warnings:
[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on linus/master v6.6-rc6 next-20231017]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/KaiLong-Wang/ocfs2-dlm-Clean-up-errors-in-dlmdomain-c/20231017-115916
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/62e91e34.969.18b27f9ec40.Coremail.wangkailong%40jari.cn
patch subject: [PATCH] ocfs2/dlm: Clean up errors in dlmdomain.c
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231017/202310171436.cr0GHO3X-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231017/202310171436.cr0GHO3X-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310171436.cr0GHO3X-lkp@intel.com/
All warnings (new ones prefixed by >>):
fs/ocfs2/dlm/dlmdomain.c: In function 'dlm_alloc_pagevec':
>> fs/ocfs2/dlm/dlmdomain.c:78:9: warning: this 'for' clause does not guard... [-Wmisleading-indentation]
78 | for (i = 0; i < pages; i++)
| ^~~
fs/ocfs2/dlm/dlmdomain.c:80:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'for'
80 | if (!(vec[i]))
| ^~
vim +/for +78 fs/ocfs2/dlm/dlmdomain.c
03d864c02c3ea8 Daniel Phillips 2006-03-10 69
03d864c02c3ea8 Daniel Phillips 2006-03-10 70 static void **dlm_alloc_pagevec(int pages)
03d864c02c3ea8 Daniel Phillips 2006-03-10 71 {
6da2ec56059c3c Kees Cook 2018-06-12 72 void **vec = kmalloc_array(pages, sizeof(void *), GFP_KERNEL);
03d864c02c3ea8 Daniel Phillips 2006-03-10 73 int i;
03d864c02c3ea8 Daniel Phillips 2006-03-10 74
03d864c02c3ea8 Daniel Phillips 2006-03-10 75 if (!vec)
03d864c02c3ea8 Daniel Phillips 2006-03-10 76 return NULL;
03d864c02c3ea8 Daniel Phillips 2006-03-10 77
03d864c02c3ea8 Daniel Phillips 2006-03-10 @78 for (i = 0; i < pages; i++)
8586048e6e9be0 KaiLong Wang 2023-10-13 79 vec[i] = (void *)__get_free_page(GFP_KERNEL);
8586048e6e9be0 KaiLong Wang 2023-10-13 80 if (!(vec[i]))
03d864c02c3ea8 Daniel Phillips 2006-03-10 81 goto out_free;
c8f33b6e86af74 Joel Becker 2006-03-16 82
685f1adb3872d9 Mark Fasheh 2006-03-23 83 mlog(0, "Allocated DLM hash pagevec; %d pages (%lu expected), %lu buckets per page\n",
f5a923d1ba648b Mark Fasheh 2006-11-28 84 pages, (unsigned long)DLM_HASH_PAGES,
f5a923d1ba648b Mark Fasheh 2006-11-28 85 (unsigned long)DLM_BUCKETS_PER_PAGE);
03d864c02c3ea8 Daniel Phillips 2006-03-10 86 return vec;
03d864c02c3ea8 Daniel Phillips 2006-03-10 87 out_free:
03d864c02c3ea8 Daniel Phillips 2006-03-10 88 dlm_free_pagevec(vec, i);
03d864c02c3ea8 Daniel Phillips 2006-03-10 89 return NULL;
03d864c02c3ea8 Daniel Phillips 2006-03-10 90 }
03d864c02c3ea8 Daniel Phillips 2006-03-10 91
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next parent reply other threads:[~2023-10-17 7:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <62e91e34.969.18b27f9ec40.Coremail.wangkailong@jari.cn>
2023-10-17 7:12 ` kernel test robot [this message]
2023-10-19 9:53 ` [PATCH] ocfs2/dlm: Clean up errors in dlmdomain.c kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202310171436.cr0GHO3X-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=jlbec@evilplan.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=wangkailong@jari.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).