From: Joseph Qi via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
To: Yangtao Li <frank.li@vivo.com>,
xiang@kernel.org, chao@kernel.org, huyue2@coolpad.com,
jefflexu@linux.alibaba.com, tytso@mit.edu,
adilger.kernel@dilger.ca, rpeterso@redhat.com,
agruenba@redhat.com, mark@fasheh.com, jlbec@evilplan.org,
viro@zeniv.linux.org.uk, brauner@kernel.org
Cc: linux-kernel@vger.kernel.org, cluster-devel@redhat.com,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-erofs@lists.ozlabs.org, ocfs2-devel@oss.oracle.com
Subject: Re: [Ocfs2-devel] [PATCH v4 4/5] ocfs2: convert to use i_blockmask()
Date: Fri, 10 Mar 2023 19:13:09 +0800 [thread overview]
Message-ID: <faca55dc-fe0d-9014-ede2-f55124cb4227@linux.alibaba.com> (raw)
In-Reply-To: <20230310054829.4241-4-frank.li@vivo.com>
On 3/10/23 1:48 PM, Yangtao Li wrote:
> Use i_blockmask() to simplify code. BTW convert ocfs2_is_io_unaligned
> to return bool type and the fact that the value will be the same
> (i.e. that ->i_blkbits is never changed by ocfs2).
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
> fs/ocfs2/file.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
> index efb09de4343d..7fd06a4d27d4 100644
> --- a/fs/ocfs2/file.c
> +++ b/fs/ocfs2/file.c
> @@ -2159,14 +2159,9 @@ int ocfs2_check_range_for_refcount(struct inode *inode, loff_t pos,
> return ret;
> }
>
> -static int ocfs2_is_io_unaligned(struct inode *inode, size_t count, loff_t pos)
> +static bool ocfs2_is_io_unaligned(struct inode *inode, size_t count, loff_t pos)
> {
> - int blockmask = inode->i_sb->s_blocksize - 1;
> - loff_t final_size = pos + count;
> -
> - if ((pos & blockmask) || (final_size & blockmask))
> - return 1;
> - return 0;
> + return ((pos | count) & i_blockmask(inode)) != 0;
Or !!((pos | count) & i_blockmask(inode))?
My concern is just like erofs, we'd better get vfs helper into mainline
first. Or can we fold the whole series into one patch? Since it's simple
enough I think.
Thanks,
Joseph
> }
>
> static int ocfs2_inode_lock_for_extent_tree(struct inode *inode,
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
next prev parent reply other threads:[~2023-03-10 11:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 5:48 [Ocfs2-devel] [PATCH v4 1/5] fs: add i_blockmask() Yangtao Li via Ocfs2-devel
2023-03-10 5:48 ` [Ocfs2-devel] [PATCH v4 2/5] erofs: convert to use i_blockmask() Yangtao Li via Ocfs2-devel
2023-03-10 6:01 ` Gao Xiang via Ocfs2-devel
2023-03-10 6:15 ` Yangtao Li via Ocfs2-devel
2023-03-10 6:20 ` Gao Xiang via Ocfs2-devel
2023-03-10 5:48 ` [Ocfs2-devel] [PATCH v4 3/5] gfs2: " Yangtao Li via Ocfs2-devel
2023-03-10 5:48 ` [Ocfs2-devel] [PATCH v4 4/5] ocfs2: " Yangtao Li via Ocfs2-devel
2023-03-10 11:13 ` Joseph Qi via Ocfs2-devel [this message]
2023-03-10 5:48 ` [Ocfs2-devel] [PATCH v4 5/5] fs/remap_range: " Yangtao Li via Ocfs2-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faca55dc-fe0d-9014-ede2-f55124cb4227@linux.alibaba.com \
--to=ocfs2-devel@oss.oracle.com \
--cc=adilger.kernel@dilger.ca \
--cc=agruenba@redhat.com \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=cluster-devel@redhat.com \
--cc=frank.li@vivo.com \
--cc=huyue2@coolpad.com \
--cc=jefflexu@linux.alibaba.com \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=rpeterso@redhat.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).