* Re: [PATCH v6 iwl-next 05/12] ice: Move CGU block
[not found] <20240405100648.144756-19-karol.kolacinski@intel.com>
@ 2024-04-05 13:58 ` kernel test robot
2024-04-05 15:11 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-04-05 13:58 UTC (permalink / raw
To: Karol Kolacinski, intel-wired-lan
Cc: oe-kbuild-all, netdev, anthony.l.nguyen, jesse.brandeburg,
Sergey Temerkhanov, Przemek Kitszel, Arkadiusz Kubalewski,
Karol Kolacinski
Hi Karol,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 0a3074e5b4b523fb60f4ae9fb32bb180ea1fb6ef]
url: https://github.com/intel-lab-lkp/linux/commits/Karol-Kolacinski/ice-Introduce-ice_ptp_hw-struct/20240405-180941
base: 0a3074e5b4b523fb60f4ae9fb32bb180ea1fb6ef
patch link: https://lore.kernel.org/r/20240405100648.144756-19-karol.kolacinski%40intel.com
patch subject: [PATCH v6 iwl-next 05/12] ice: Move CGU block
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240405/202404052136.o9Cbreqn-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240405/202404052136.o9Cbreqn-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404052136.o9Cbreqn-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/net/ethernet/intel/ice/ice_ptp_hw.c: In function 'ice_read_cgu_reg_e82x':
>> drivers/net/ethernet/intel/ice/ice_ptp_hw.c:244:25: warning: initialization of 'unsigned int' from 'u32 *' {aka 'unsigned int *'} makes integer from pointer without a cast [-Wint-conversion]
244 | .data = val
| ^~~
drivers/net/ethernet/intel/ice/ice_ptp_hw.c:244:25: note: (near initialization for 'cgu_msg.data')
In file included from <command-line>:
drivers/net/ethernet/intel/ice/ice_ptp_hw.c: In function 'ice_write_40b_phy_reg_e82x':
include/uapi/linux/bits.h:9:19: warning: right shift count is negative [-Wshift-count-negative]
9 | (~_UL(0) >> (__BITS_PER_LONG - 1 - (h))))
| ^~
include/linux/compiler_types.h:440:23: note: in definition of macro '__compiletime_assert'
440 | if (!(condition)) \
| ^~~~~~~~~
include/linux/compiler_types.h:460:9: note: in expansion of macro '_compiletime_assert'
460 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
| ^~~~~~~~~~~~~~~~~~
include/linux/bitfield.h:65:17: note: in expansion of macro 'BUILD_BUG_ON_MSG'
65 | BUILD_BUG_ON_MSG(!__builtin_constant_p(_mask), \
| ^~~~~~~~~~~~~~~~
include/linux/bitfield.h:155:17: note: in expansion of macro '__BF_FIELD_CHECK'
155 | __BF_FIELD_CHECK(_mask, _reg, 0U, "FIELD_GET: "); \
| ^~~~~~~~~~~~~~~~
drivers/net/ethernet/intel/ice/ice_ptp_hw.c:908:16: note: in expansion of macro 'FIELD_GET'
908 | high = FIELD_GET(P_REG_40B_HIGH_M, val);
| ^~~~~~~~~
include/linux/bits.h:35:38: note: in expansion of macro '__GENMASK'
35 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~
drivers/net/ethernet/intel/ice/ice_ptp_hw.h:381:41: note: in expansion of macro 'GENMASK'
381 | #define P_REG_40B_HIGH_M GENMASK(39, 8)
| ^~~~~~~
drivers/net/ethernet/intel/ice/ice_ptp_hw.c:908:26: note: in expansion of macro 'P_REG_40B_HIGH_M'
908 | high = FIELD_GET(P_REG_40B_HIGH_M, val);
| ^~~~~~~~~~~~~~~~
include/uapi/linux/bits.h:9:19: warning: right shift count is negative [-Wshift-count-negative]
9 | (~_UL(0) >> (__BITS_PER_LONG - 1 - (h))))
| ^~
include/linux/compiler_types.h:440:23: note: in definition of macro '__compiletime_assert'
440 | if (!(condition)) \
| ^~~~~~~~~
include/linux/compiler_types.h:460:9: note: in expansion of macro '_compiletime_assert'
460 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
| ^~~~~~~~~~~~~~~~~~
include/linux/bitfield.h:67:17: note: in expansion of macro 'BUILD_BUG_ON_MSG'
67 | BUILD_BUG_ON_MSG((_mask) == 0, _pfx "mask is zero"); \
| ^~~~~~~~~~~~~~~~
include/linux/bitfield.h:155:17: note: in expansion of macro '__BF_FIELD_CHECK'
155 | __BF_FIELD_CHECK(_mask, _reg, 0U, "FIELD_GET: "); \
| ^~~~~~~~~~~~~~~~
drivers/net/ethernet/intel/ice/ice_ptp_hw.c:908:16: note: in expansion of macro 'FIELD_GET'
908 | high = FIELD_GET(P_REG_40B_HIGH_M, val);
| ^~~~~~~~~
include/linux/bits.h:35:38: note: in expansion of macro '__GENMASK'
35 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~
drivers/net/ethernet/intel/ice/ice_ptp_hw.h:381:41: note: in expansion of macro 'GENMASK'
381 | #define P_REG_40B_HIGH_M GENMASK(39, 8)
| ^~~~~~~
drivers/net/ethernet/intel/ice/ice_ptp_hw.c:908:26: note: in expansion of macro 'P_REG_40B_HIGH_M'
908 | high = FIELD_GET(P_REG_40B_HIGH_M, val);
| ^~~~~~~~~~~~~~~~
include/uapi/linux/bits.h:9:19: warning: right shift count is negative [-Wshift-count-negative]
9 | (~_UL(0) >> (__BITS_PER_LONG - 1 - (h))))
| ^~
include/linux/compiler_types.h:440:23: note: in definition of macro '__compiletime_assert'
440 | if (!(condition)) \
| ^~~~~~~~~
include/linux/compiler_types.h:460:9: note: in expansion of macro '_compiletime_assert'
460 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
| ^~~~~~~~~~~~~~~~~~
include/linux/bitfield.h:68:17: note: in expansion of macro 'BUILD_BUG_ON_MSG'
68 | BUILD_BUG_ON_MSG(__builtin_constant_p(_val) ? \
| ^~~~~~~~~~~~~~~~
include/linux/bitfield.h:155:17: note: in expansion of macro '__BF_FIELD_CHECK'
155 | __BF_FIELD_CHECK(_mask, _reg, 0U, "FIELD_GET: "); \
| ^~~~~~~~~~~~~~~~
drivers/net/ethernet/intel/ice/ice_ptp_hw.c:908:16: note: in expansion of macro 'FIELD_GET'
908 | high = FIELD_GET(P_REG_40B_HIGH_M, val);
| ^~~~~~~~~
include/linux/bits.h:35:38: note: in expansion of macro '__GENMASK'
35 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~
drivers/net/ethernet/intel/ice/ice_ptp_hw.h:381:41: note: in expansion of macro 'GENMASK'
381 | #define P_REG_40B_HIGH_M GENMASK(39, 8)
| ^~~~~~~
drivers/net/ethernet/intel/ice/ice_ptp_hw.c:908:26: note: in expansion of macro 'P_REG_40B_HIGH_M'
908 | high = FIELD_GET(P_REG_40B_HIGH_M, val);
| ^~~~~~~~~~~~~~~~
include/uapi/linux/bits.h:9:19: warning: right shift count is negative [-Wshift-count-negative]
9 | (~_UL(0) >> (__BITS_PER_LONG - 1 - (h))))
| ^~
include/linux/compiler_types.h:440:23: note: in definition of macro '__compiletime_assert'
440 | if (!(condition)) \
vim +244 drivers/net/ethernet/intel/ice/ice_ptp_hw.c
228
229 /**
230 * ice_read_cgu_reg_e82x - Read a CGU register
231 * @hw: pointer to the HW struct
232 * @addr: Register address to read
233 * @val: storage for register value read
234 *
235 * Read the contents of a register of the Clock Generation Unit. Only
236 * applicable to E822 devices.
237 */
238 static int ice_read_cgu_reg_e82x(struct ice_hw *hw, u32 addr, u32 *val)
239 {
240 struct ice_sbq_msg_input cgu_msg = {
241 .opcode = ice_sbq_msg_rd,
242 .dest_dev = cgu,
243 .msg_addr_low = addr,
> 244 .data = val
245 };
246 int err;
247
248 cgu_msg.opcode = ice_sbq_msg_rd;
249 cgu_msg.dest_dev = cgu;
250 cgu_msg.msg_addr_low = addr;
251 cgu_msg.msg_addr_high = 0x0;
252
253 err = ice_sbq_rw_reg(hw, &cgu_msg);
254 if (err) {
255 ice_debug(hw, ICE_DBG_PTP, "Failed to read CGU register 0x%04x, err %d\n",
256 addr, err);
257 return err;
258 }
259
260 *val = cgu_msg.data;
261
262 return 0;
263 }
264
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v6 iwl-next 05/12] ice: Move CGU block
[not found] <20240405100648.144756-19-karol.kolacinski@intel.com>
2024-04-05 13:58 ` [PATCH v6 iwl-next 05/12] ice: Move CGU block kernel test robot
@ 2024-04-05 15:11 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-04-05 15:11 UTC (permalink / raw
To: Karol Kolacinski, intel-wired-lan
Cc: oe-kbuild-all, netdev, anthony.l.nguyen, jesse.brandeburg,
Sergey Temerkhanov, Przemek Kitszel, Arkadiusz Kubalewski,
Karol Kolacinski
Hi Karol,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 0a3074e5b4b523fb60f4ae9fb32bb180ea1fb6ef]
url: https://github.com/intel-lab-lkp/linux/commits/Karol-Kolacinski/ice-Introduce-ice_ptp_hw-struct/20240405-180941
base: 0a3074e5b4b523fb60f4ae9fb32bb180ea1fb6ef
patch link: https://lore.kernel.org/r/20240405100648.144756-19-karol.kolacinski%40intel.com
patch subject: [PATCH v6 iwl-next 05/12] ice: Move CGU block
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20240405/202404052226.aq0o8qIE-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240405/202404052226.aq0o8qIE-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404052226.aq0o8qIE-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/net/ethernet/intel/ice/ice_ptp_hw.c: In function 'ice_read_cgu_reg_e82x':
drivers/net/ethernet/intel/ice/ice_ptp_hw.c:244:25: warning: initialization of 'unsigned int' from 'u32 *' {aka 'unsigned int *'} makes integer from pointer without a cast [-Wint-conversion]
244 | .data = val
| ^~~
drivers/net/ethernet/intel/ice/ice_ptp_hw.c:244:25: note: (near initialization for 'cgu_msg.data')
drivers/net/ethernet/intel/ice/ice_ptp_hw.c: In function 'ice_ptp_reset_ts_memory_quad_e82x':
>> drivers/net/ethernet/intel/ice/ice_ptp_hw.c:1167:58: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551614' to '4294967294' [-Woverflow]
1167 | ice_write_quad_reg_e82x(hw, quad, Q_REG_TS_CTRL, ~Q_REG_TS_CTRL_M);
vim +1167 drivers/net/ethernet/intel/ice/ice_ptp_hw.c
1155
1156 /**
1157 * ice_ptp_reset_ts_memory_quad_e82x - Clear all timestamps from the quad block
1158 * @hw: pointer to the HW struct
1159 * @quad: the quad to read from
1160 *
1161 * Clear all timestamps from the PHY quad block that is shared between the
1162 * internal PHYs on the E822 devices.
1163 */
1164 void ice_ptp_reset_ts_memory_quad_e82x(struct ice_hw *hw, u8 quad)
1165 {
1166 ice_write_quad_reg_e82x(hw, quad, Q_REG_TS_CTRL, Q_REG_TS_CTRL_M);
> 1167 ice_write_quad_reg_e82x(hw, quad, Q_REG_TS_CTRL, ~Q_REG_TS_CTRL_M);
1168 }
1169
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-05 15:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240405100648.144756-19-karol.kolacinski@intel.com>
2024-04-05 13:58 ` [PATCH v6 iwl-next 05/12] ice: Move CGU block kernel test robot
2024-04-05 15:11 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).