oe-kbuild-all.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [chao:wip 5/7] fs/f2fs/segment.c:5489 destroy_curseg() warn: inconsistent indenting
@ 2024-04-06  1:43 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-04-06  1:43 UTC (permalink / raw
  To: Chao Yu, Chao Yu; +Cc: oe-kbuild-all, Chao Yu, Chao Yu

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git wip
head:   8609ac2462ce93cc59da4a019568b1e3af48ea4d
commit: fca6dad53ebbef9b679b217887bda329aa963254 [5/7] f2fs: zone: don't block IO if there is remained open zone
config: sparc64-randconfig-r081-20240406 (https://download.01.org/0day-ci/archive/20240406/202404060950.GKlnDiXp-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 13.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404060950.GKlnDiXp-lkp@intel.com/

New smatch warnings:
fs/f2fs/segment.c:5489 destroy_curseg() warn: inconsistent indenting

Old smatch warnings:
fs/f2fs/segment.c:801 __remove_dirty_segment() warn: check sign expansion for '-1'
fs/f2fs/segment.c:4198 write_compacted_summaries() warn: variable dereferenced before check 'page' (see line 4181)

vim +5489 fs/f2fs/segment.c

  5475	
  5476	static void destroy_curseg(struct f2fs_sb_info *sbi)
  5477	{
  5478		struct curseg_info *array = SM_I(sbi)->curseg_array;
  5479		int i;
  5480	
  5481		if (!array)
  5482			return;
  5483		SM_I(sbi)->curseg_array = NULL;
  5484		for (i = 0; i < NR_CURSEG_TYPE; i++) {
  5485			kfree(array[i].sum_blk);
  5486			kfree(array[i].journal);
  5487	
  5488	#ifdef CONFIG_BLK_DEV_ZONED
> 5489		if (f2fs_sb_has_blkzoned(sbi)) {
  5490			enum page_type ptype = PAGE_TYPE(i);
  5491			enum temp_type temp = type_to_temp(i);
  5492	
  5493			if (sbi->write_io[ptype][temp].zone_openned) {
  5494				up(&sbi->available_open_zones);
  5495				sbi->write_io[ptype][temp].zone_openned = false;
  5496			}
  5497		}
  5498	#endif
  5499	
  5500		}
  5501		kfree(array);
  5502	}
  5503	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-04-06  1:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-06  1:43 [chao:wip 5/7] fs/f2fs/segment.c:5489 destroy_curseg() warn: inconsistent indenting kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).